All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] f2fs: remove set but not used variable 'params'
@ 2020-04-02  6:15 ` Jason Yan
  0 siblings, 0 replies; 6+ messages in thread
From: Jason Yan @ 2020-04-02  6:15 UTC (permalink / raw)
  To: jaegeuk, chao, linux-f2fs-devel, linux-kernel; +Cc: Jason Yan

Fix the following gcc warning:

fs/f2fs/compress.c:375:18: warning: variable 'params' set but not used [-Wunused-but-set-variable]
  ZSTD_parameters params;
                  ^~~~~~

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 fs/f2fs/compress.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index f05ecf4cb899..df7b2d15eacd 100644
--- a/fs/f2fs/compress.c
+++ b/fs/f2fs/compress.c
@@ -372,12 +372,10 @@ static int zstd_compress_pages(struct compress_ctx *cc)
 
 static int zstd_init_decompress_ctx(struct decompress_io_ctx *dic)
 {
-	ZSTD_parameters params;
 	ZSTD_DStream *stream;
 	void *workspace;
 	unsigned int workspace_size;
 
-	params = ZSTD_getParams(F2FS_ZSTD_DEFAULT_CLEVEL, dic->clen, 0);
 	workspace_size = ZSTD_DStreamWorkspaceBound(MAX_COMPRESS_WINDOW_SIZE);
 
 	workspace = f2fs_kvmalloc(F2FS_I_SB(dic->inode),
-- 
2.17.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [f2fs-dev] [PATCH -next] f2fs: remove set but not used variable 'params'
@ 2020-04-02  6:15 ` Jason Yan
  0 siblings, 0 replies; 6+ messages in thread
From: Jason Yan @ 2020-04-02  6:15 UTC (permalink / raw)
  To: jaegeuk, chao, linux-f2fs-devel, linux-kernel; +Cc: Jason Yan

Fix the following gcc warning:

fs/f2fs/compress.c:375:18: warning: variable 'params' set but not used [-Wunused-but-set-variable]
  ZSTD_parameters params;
                  ^~~~~~

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 fs/f2fs/compress.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index f05ecf4cb899..df7b2d15eacd 100644
--- a/fs/f2fs/compress.c
+++ b/fs/f2fs/compress.c
@@ -372,12 +372,10 @@ static int zstd_compress_pages(struct compress_ctx *cc)
 
 static int zstd_init_decompress_ctx(struct decompress_io_ctx *dic)
 {
-	ZSTD_parameters params;
 	ZSTD_DStream *stream;
 	void *workspace;
 	unsigned int workspace_size;
 
-	params = ZSTD_getParams(F2FS_ZSTD_DEFAULT_CLEVEL, dic->clen, 0);
 	workspace_size = ZSTD_DStreamWorkspaceBound(MAX_COMPRESS_WINDOW_SIZE);
 
 	workspace = f2fs_kvmalloc(F2FS_I_SB(dic->inode),
-- 
2.17.2



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [f2fs-dev] [PATCH -next] f2fs: remove set but not used variable 'params'
  2020-04-02  6:15 ` [f2fs-dev] " Jason Yan
@ 2020-04-02  8:37   ` Chao Yu
  -1 siblings, 0 replies; 6+ messages in thread
From: Chao Yu @ 2020-04-02  8:37 UTC (permalink / raw)
  To: Jason Yan, jaegeuk, chao, linux-f2fs-devel, linux-kernel

Hi Jason,

On 2020/4/2 14:15, Jason Yan wrote:
> Fix the following gcc warning:
> 
> fs/f2fs/compress.c:375:18: warning: variable 'params' set but not used [-Wunused-but-set-variable]
>   ZSTD_parameters params;
>                   ^~~~~~
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

Thanks for the patch, would you mind that just merge this fix into
original path which is still in f2fs private git tree?

Thanks,

> ---
>  fs/f2fs/compress.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
> index f05ecf4cb899..df7b2d15eacd 100644
> --- a/fs/f2fs/compress.c
> +++ b/fs/f2fs/compress.c
> @@ -372,12 +372,10 @@ static int zstd_compress_pages(struct compress_ctx *cc)
>  
>  static int zstd_init_decompress_ctx(struct decompress_io_ctx *dic)
>  {
> -	ZSTD_parameters params;
>  	ZSTD_DStream *stream;
>  	void *workspace;
>  	unsigned int workspace_size;
>  
> -	params = ZSTD_getParams(F2FS_ZSTD_DEFAULT_CLEVEL, dic->clen, 0);
>  	workspace_size = ZSTD_DStreamWorkspaceBound(MAX_COMPRESS_WINDOW_SIZE);
>  
>  	workspace = f2fs_kvmalloc(F2FS_I_SB(dic->inode),
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [f2fs-dev] [PATCH -next] f2fs: remove set but not used variable 'params'
@ 2020-04-02  8:37   ` Chao Yu
  0 siblings, 0 replies; 6+ messages in thread
From: Chao Yu @ 2020-04-02  8:37 UTC (permalink / raw)
  To: Jason Yan, jaegeuk, chao, linux-f2fs-devel, linux-kernel

Hi Jason,

On 2020/4/2 14:15, Jason Yan wrote:
> Fix the following gcc warning:
> 
> fs/f2fs/compress.c:375:18: warning: variable 'params' set but not used [-Wunused-but-set-variable]
>   ZSTD_parameters params;
>                   ^~~~~~
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

Thanks for the patch, would you mind that just merge this fix into
original path which is still in f2fs private git tree?

Thanks,

> ---
>  fs/f2fs/compress.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
> index f05ecf4cb899..df7b2d15eacd 100644
> --- a/fs/f2fs/compress.c
> +++ b/fs/f2fs/compress.c
> @@ -372,12 +372,10 @@ static int zstd_compress_pages(struct compress_ctx *cc)
>  
>  static int zstd_init_decompress_ctx(struct decompress_io_ctx *dic)
>  {
> -	ZSTD_parameters params;
>  	ZSTD_DStream *stream;
>  	void *workspace;
>  	unsigned int workspace_size;
>  
> -	params = ZSTD_getParams(F2FS_ZSTD_DEFAULT_CLEVEL, dic->clen, 0);
>  	workspace_size = ZSTD_DStreamWorkspaceBound(MAX_COMPRESS_WINDOW_SIZE);
>  
>  	workspace = f2fs_kvmalloc(F2FS_I_SB(dic->inode),
> 


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [f2fs-dev] [PATCH -next] f2fs: remove set but not used variable 'params'
  2020-04-02  8:37   ` Chao Yu
@ 2020-04-02  9:14     ` Jason Yan
  -1 siblings, 0 replies; 6+ messages in thread
From: Jason Yan @ 2020-04-02  9:14 UTC (permalink / raw)
  To: Chao Yu, jaegeuk, chao, linux-f2fs-devel, linux-kernel

Hi Chao,

在 2020/4/2 16:37, Chao Yu 写道:
> Hi Jason,
> 
> On 2020/4/2 14:15, Jason Yan wrote:
>> Fix the following gcc warning:
>>
>> fs/f2fs/compress.c:375:18: warning: variable 'params' set but not used [-Wunused-but-set-variable]
>>    ZSTD_parameters params;
>>                    ^~~~~~
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> 
> Thanks for the patch, would you mind that just merge this fix into
> original path which is still in f2fs private git tree?
> 

It's ok to merge this into the original patch.

> Thanks,
> 
>> ---
>>   fs/f2fs/compress.c | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
>> index f05ecf4cb899..df7b2d15eacd 100644
>> --- a/fs/f2fs/compress.c
>> +++ b/fs/f2fs/compress.c
>> @@ -372,12 +372,10 @@ static int zstd_compress_pages(struct compress_ctx *cc)
>>   
>>   static int zstd_init_decompress_ctx(struct decompress_io_ctx *dic)
>>   {
>> -	ZSTD_parameters params;
>>   	ZSTD_DStream *stream;
>>   	void *workspace;
>>   	unsigned int workspace_size;
>>   
>> -	params = ZSTD_getParams(F2FS_ZSTD_DEFAULT_CLEVEL, dic->clen, 0);
>>   	workspace_size = ZSTD_DStreamWorkspaceBound(MAX_COMPRESS_WINDOW_SIZE);
>>   
>>   	workspace = f2fs_kvmalloc(F2FS_I_SB(dic->inode),
>>
> 
> .
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [f2fs-dev] [PATCH -next] f2fs: remove set but not used variable 'params'
@ 2020-04-02  9:14     ` Jason Yan
  0 siblings, 0 replies; 6+ messages in thread
From: Jason Yan @ 2020-04-02  9:14 UTC (permalink / raw)
  To: Chao Yu, jaegeuk, chao, linux-f2fs-devel, linux-kernel

Hi Chao,

在 2020/4/2 16:37, Chao Yu 写道:
> Hi Jason,
> 
> On 2020/4/2 14:15, Jason Yan wrote:
>> Fix the following gcc warning:
>>
>> fs/f2fs/compress.c:375:18: warning: variable 'params' set but not used [-Wunused-but-set-variable]
>>    ZSTD_parameters params;
>>                    ^~~~~~
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> 
> Thanks for the patch, would you mind that just merge this fix into
> original path which is still in f2fs private git tree?
> 

It's ok to merge this into the original patch.

> Thanks,
> 
>> ---
>>   fs/f2fs/compress.c | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
>> index f05ecf4cb899..df7b2d15eacd 100644
>> --- a/fs/f2fs/compress.c
>> +++ b/fs/f2fs/compress.c
>> @@ -372,12 +372,10 @@ static int zstd_compress_pages(struct compress_ctx *cc)
>>   
>>   static int zstd_init_decompress_ctx(struct decompress_io_ctx *dic)
>>   {
>> -	ZSTD_parameters params;
>>   	ZSTD_DStream *stream;
>>   	void *workspace;
>>   	unsigned int workspace_size;
>>   
>> -	params = ZSTD_getParams(F2FS_ZSTD_DEFAULT_CLEVEL, dic->clen, 0);
>>   	workspace_size = ZSTD_DStreamWorkspaceBound(MAX_COMPRESS_WINDOW_SIZE);
>>   
>>   	workspace = f2fs_kvmalloc(F2FS_I_SB(dic->inode),
>>
> 
> .
> 



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-02  9:14 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-02  6:15 [PATCH -next] f2fs: remove set but not used variable 'params' Jason Yan
2020-04-02  6:15 ` [f2fs-dev] " Jason Yan
2020-04-02  8:37 ` Chao Yu
2020-04-02  8:37   ` Chao Yu
2020-04-02  9:14   ` Jason Yan
2020-04-02  9:14     ` Jason Yan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.