From: Neil Armstrong <neil.armstrong@linaro.org> To: Abel Vesa <abel.vesa@linaro.org>, Stephen Boyd <sboyd@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org> Cc: Srini Kandagatla <srinivas.kandagatla@linaro.org>, Johan Hovold <johan@kernel.org>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH RESEND v6 0/5] spmi: pmic-arb: Add support for multiple buses Date: Thu, 28 Mar 2024 10:07:51 +0100 [thread overview] Message-ID: <ab749f2d-269f-40bb-b6ab-b19fd7243eed@linaro.org> (raw) In-Reply-To: <20240326-spmi-multi-master-support-v6-0-1c87d8306c5b@linaro.org> Hi Abel, On 26/03/2024 17:28, Abel Vesa wrote: > This RFC prepares for and adds support for 2 buses, which is supported > in HW starting with version 7. Until now, none of the currently > supported platforms in upstream have used the second bus. The X1E80100 > platform, on the other hand, needs the second bus for the USB2.0 to work > as there are 3 SMB2360 PMICs which provide eUSB2 repeaters and they are > all found on the second bus. @Dmitry, @Konrad, @Bjorn, could you apply those patches and test an devices you have to make sure there's no regression ? > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- > Changes in v6: > - Changed the compatible to platform specific (X1E80100) along with the > schema. Fixed the spmi buses unit addresses and added the empty ranges > property. Added missing properties to the spmi buses and the > "unevaluatedProperties: false". > - Deprecated the "qcom,bus-id" in the legacy schema. > - Changed the driver to check for legacy compatible first > - Link to v5: https://lore.kernel.org/r/20240221-spmi-multi-master-support-v5-0-3255ca413a0b@linaro.org > > Changes in v5: > - Dropped the RFC as there aren't any concerns about the approach anymore > - Dropped the unused dev and res variables from pmic_arb_get_obsrvr_chnls_v2 > - Link to v4: https://lore.kernel.org/r/20240220-spmi-multi-master-support-v4-0-dc813c878ba8@linaro.org > > Changes in v4: > - Fixed comment above pmic_arb_init_apid_v7 by dropping the extra "bus" word > - Swicthed to devm_platform_ioremap_resource_byname for obsrvr and chnls. > The core remains with platform_get_resource_byname as we need the core size. > - Dropped comment from probe related to the need of platform_get_resource_byname > as it not true anymore. > - Dropped the qcom,bus-id optional property. > - Link to v3: https://lore.kernel.org/r/20240214-spmi-multi-master-support-v3-0-0bae0ef04faf@linaro.org > > Changes in v3: > - Split the change into 3 separate patches. First 2 patches are moving > apid init and core resources into version specific ops. Third one is > adding the support for 2 buses and dedicated compatible. > - Added separate bindings patch > - Link to v2: https://lore.kernel.org/r/20240213-spmi-multi-master-support-v2-1-b3b102326906@linaro.org > > Changes in v2: > - Reworked it so that it registers a spmi controller for each bus > rather than relying on the generic framework to pass on the bus > (master) id. > - Link to v1: https://lore.kernel.org/r/20240207-spmi-multi-master-support-v1-0-ce57f301c7fd@linaro.org > > --- > Abel Vesa (5): > dt-bindings: spmi: Add X1E80100 SPMI PMIC ARB schema > dt-bindings: spmi: Deprecate qcom,bus-id Forgot to add, but please fix this in a v7: > spmi: pmic-arb: Make the APID init a version operation drivers/spmi/spmi-pmic-arb.c:180: warning: Function parameter or struct member 'core' not described in 'spmi_pmic_arb' drivers/spmi/spmi-pmic-arb.c:180: warning: Function parameter or struct member 'core_size' not described in 'spmi_pmic_arb' drivers/spmi/spmi-pmic-arb.c:180: warning: Function parameter or struct member 'mapping_table_valid' not described in 'spmi_pmic_arb' drivers/spmi/spmi-pmic-arb.c:243: warning: Function parameter or struct member 'pmic_arb' not described in 'pmic_arb_read_data' drivers/spmi/spmi-pmic-arb.c:257: warning: Function parameter or struct member 'pmic_arb' not described in 'pmic_arb_write_data' > spmi: pmic-arb: Make core resources acquiring a version operation drivers/spmi/spmi-pmic-arb.c:180: warning: Function parameter or struct member 'core' not described in 'spmi_pmic_arb' drivers/spmi/spmi-pmic-arb.c:180: warning: Function parameter or struct member 'core_size' not described in 'spmi_pmic_arb' drivers/spmi/spmi-pmic-arb.c:180: warning: Function parameter or struct member 'mapping_table_valid' not described in 'spmi_pmic_arb' drivers/spmi/spmi-pmic-arb.c:222: warning: Function parameter or struct member 'get_core_resources' not described in 'pmic_arb_ver_ops' drivers/spmi/spmi-pmic-arb.c:244: warning: Function parameter or struct member 'pmic_arb' not described in 'pmic_arb_read_data' drivers/spmi/spmi-pmic-arb.c:258: warning: Function parameter or struct member 'pmic_arb' not described in 'pmic_arb_write_data' > spmi: pmic-arb: Add multi bus support > > .../bindings/spmi/qcom,spmi-pmic-arb.yaml | 1 + > .../bindings/spmi/qcom,x1e80100-spmi-pmic-arb.yaml | 136 +++ > drivers/spmi/spmi-pmic-arb.c | 948 +++++++++++++-------- > 3 files changed, 715 insertions(+), 370 deletions(-) > --- > base-commit: 4893c639cc3659cefaa675bf1e59f4e7571afb5c > change-id: 20240207-spmi-multi-master-support-832a704b779b > > Best regards, Thanks, Neil
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <neil.armstrong@linaro.org> To: Abel Vesa <abel.vesa@linaro.org>, Stephen Boyd <sboyd@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org> Cc: Srini Kandagatla <srinivas.kandagatla@linaro.org>, Johan Hovold <johan@kernel.org>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH RESEND v6 0/5] spmi: pmic-arb: Add support for multiple buses Date: Thu, 28 Mar 2024 10:07:51 +0100 [thread overview] Message-ID: <ab749f2d-269f-40bb-b6ab-b19fd7243eed@linaro.org> (raw) In-Reply-To: <20240326-spmi-multi-master-support-v6-0-1c87d8306c5b@linaro.org> Hi Abel, On 26/03/2024 17:28, Abel Vesa wrote: > This RFC prepares for and adds support for 2 buses, which is supported > in HW starting with version 7. Until now, none of the currently > supported platforms in upstream have used the second bus. The X1E80100 > platform, on the other hand, needs the second bus for the USB2.0 to work > as there are 3 SMB2360 PMICs which provide eUSB2 repeaters and they are > all found on the second bus. @Dmitry, @Konrad, @Bjorn, could you apply those patches and test an devices you have to make sure there's no regression ? > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- > Changes in v6: > - Changed the compatible to platform specific (X1E80100) along with the > schema. Fixed the spmi buses unit addresses and added the empty ranges > property. Added missing properties to the spmi buses and the > "unevaluatedProperties: false". > - Deprecated the "qcom,bus-id" in the legacy schema. > - Changed the driver to check for legacy compatible first > - Link to v5: https://lore.kernel.org/r/20240221-spmi-multi-master-support-v5-0-3255ca413a0b@linaro.org > > Changes in v5: > - Dropped the RFC as there aren't any concerns about the approach anymore > - Dropped the unused dev and res variables from pmic_arb_get_obsrvr_chnls_v2 > - Link to v4: https://lore.kernel.org/r/20240220-spmi-multi-master-support-v4-0-dc813c878ba8@linaro.org > > Changes in v4: > - Fixed comment above pmic_arb_init_apid_v7 by dropping the extra "bus" word > - Swicthed to devm_platform_ioremap_resource_byname for obsrvr and chnls. > The core remains with platform_get_resource_byname as we need the core size. > - Dropped comment from probe related to the need of platform_get_resource_byname > as it not true anymore. > - Dropped the qcom,bus-id optional property. > - Link to v3: https://lore.kernel.org/r/20240214-spmi-multi-master-support-v3-0-0bae0ef04faf@linaro.org > > Changes in v3: > - Split the change into 3 separate patches. First 2 patches are moving > apid init and core resources into version specific ops. Third one is > adding the support for 2 buses and dedicated compatible. > - Added separate bindings patch > - Link to v2: https://lore.kernel.org/r/20240213-spmi-multi-master-support-v2-1-b3b102326906@linaro.org > > Changes in v2: > - Reworked it so that it registers a spmi controller for each bus > rather than relying on the generic framework to pass on the bus > (master) id. > - Link to v1: https://lore.kernel.org/r/20240207-spmi-multi-master-support-v1-0-ce57f301c7fd@linaro.org > > --- > Abel Vesa (5): > dt-bindings: spmi: Add X1E80100 SPMI PMIC ARB schema > dt-bindings: spmi: Deprecate qcom,bus-id Forgot to add, but please fix this in a v7: > spmi: pmic-arb: Make the APID init a version operation drivers/spmi/spmi-pmic-arb.c:180: warning: Function parameter or struct member 'core' not described in 'spmi_pmic_arb' drivers/spmi/spmi-pmic-arb.c:180: warning: Function parameter or struct member 'core_size' not described in 'spmi_pmic_arb' drivers/spmi/spmi-pmic-arb.c:180: warning: Function parameter or struct member 'mapping_table_valid' not described in 'spmi_pmic_arb' drivers/spmi/spmi-pmic-arb.c:243: warning: Function parameter or struct member 'pmic_arb' not described in 'pmic_arb_read_data' drivers/spmi/spmi-pmic-arb.c:257: warning: Function parameter or struct member 'pmic_arb' not described in 'pmic_arb_write_data' > spmi: pmic-arb: Make core resources acquiring a version operation drivers/spmi/spmi-pmic-arb.c:180: warning: Function parameter or struct member 'core' not described in 'spmi_pmic_arb' drivers/spmi/spmi-pmic-arb.c:180: warning: Function parameter or struct member 'core_size' not described in 'spmi_pmic_arb' drivers/spmi/spmi-pmic-arb.c:180: warning: Function parameter or struct member 'mapping_table_valid' not described in 'spmi_pmic_arb' drivers/spmi/spmi-pmic-arb.c:222: warning: Function parameter or struct member 'get_core_resources' not described in 'pmic_arb_ver_ops' drivers/spmi/spmi-pmic-arb.c:244: warning: Function parameter or struct member 'pmic_arb' not described in 'pmic_arb_read_data' drivers/spmi/spmi-pmic-arb.c:258: warning: Function parameter or struct member 'pmic_arb' not described in 'pmic_arb_write_data' > spmi: pmic-arb: Add multi bus support > > .../bindings/spmi/qcom,spmi-pmic-arb.yaml | 1 + > .../bindings/spmi/qcom,x1e80100-spmi-pmic-arb.yaml | 136 +++ > drivers/spmi/spmi-pmic-arb.c | 948 +++++++++++++-------- > 3 files changed, 715 insertions(+), 370 deletions(-) > --- > base-commit: 4893c639cc3659cefaa675bf1e59f4e7571afb5c > change-id: 20240207-spmi-multi-master-support-832a704b779b > > Best regards, Thanks, Neil _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-28 9:07 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-26 16:28 [PATCH RESEND v6 0/5] spmi: pmic-arb: Add support for multiple buses Abel Vesa 2024-03-26 16:28 ` Abel Vesa 2024-03-26 16:28 ` [PATCH RESEND v6 1/5] dt-bindings: spmi: Add X1E80100 SPMI PMIC ARB schema Abel Vesa 2024-03-26 16:28 ` Abel Vesa 2024-03-27 18:40 ` Krzysztof Kozlowski 2024-03-27 18:40 ` Krzysztof Kozlowski 2024-03-26 16:28 ` [PATCH RESEND v6 2/5] dt-bindings: spmi: Deprecate qcom,bus-id Abel Vesa 2024-03-26 16:28 ` Abel Vesa 2024-03-26 16:28 ` [PATCH RESEND v6 3/5] spmi: pmic-arb: Make the APID init a version operation Abel Vesa 2024-03-26 16:28 ` Abel Vesa 2024-03-28 8:51 ` Neil Armstrong 2024-03-28 8:51 ` Neil Armstrong 2024-03-29 16:32 ` Abel Vesa 2024-03-29 16:32 ` Abel Vesa 2024-03-26 16:28 ` [PATCH RESEND v6 4/5] spmi: pmic-arb: Make core resources acquiring " Abel Vesa 2024-03-26 16:28 ` Abel Vesa 2024-03-28 8:54 ` Neil Armstrong 2024-03-28 8:54 ` Neil Armstrong 2024-03-26 16:28 ` [PATCH RESEND v6 5/5] spmi: pmic-arb: Add multi bus support Abel Vesa 2024-03-26 16:28 ` Abel Vesa 2024-03-28 9:05 ` Neil Armstrong 2024-03-28 9:05 ` Neil Armstrong 2024-03-26 19:32 ` [PATCH RESEND v6 0/5] spmi: pmic-arb: Add support for multiple buses Rob Herring 2024-03-26 19:32 ` Rob Herring 2024-03-26 19:57 ` Abel Vesa 2024-03-26 19:57 ` Abel Vesa 2024-03-27 9:23 ` Krzysztof Kozlowski 2024-03-27 9:23 ` Krzysztof Kozlowski 2024-03-27 10:37 ` Abel Vesa 2024-03-27 10:37 ` Abel Vesa 2024-03-27 10:44 ` Krzysztof Kozlowski 2024-03-27 10:44 ` Krzysztof Kozlowski 2024-03-28 9:07 ` Neil Armstrong [this message] 2024-03-28 9:07 ` Neil Armstrong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ab749f2d-269f-40bb-b6ab-b19fd7243eed@linaro.org \ --to=neil.armstrong@linaro.org \ --cc=abel.vesa@linaro.org \ --cc=andersson@kernel.org \ --cc=angelogioacchino.delregno@collabora.com \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=johan@kernel.org \ --cc=konrad.dybcio@linaro.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=robh@kernel.org \ --cc=sboyd@kernel.org \ --cc=srinivas.kandagatla@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.