From: Sagi Grimberg <sagi@grimberg.me> To: Boris Pismenny <borisp@mellanox.com>, kuba@kernel.org, davem@davemloft.net, saeedm@nvidia.com, hch@lst.de, axboe@fb.com, kbusch@kernel.org, viro@zeniv.linux.org.uk, edumazet@google.com Cc: Yoray Zack <yorayz@mellanox.com>, Ben Ben-Ishay <benishay@mellanox.com>, boris.pismenny@gmail.com, linux-nvme@lists.infradead.org, netdev@vger.kernel.org, Or Gerlitz <ogerlitz@mellanox.com> Subject: Re: [PATCH net-next RFC v1 02/10] net: Introduce direct data placement tcp offload Date: Thu, 8 Oct 2020 14:47:08 -0700 [thread overview] Message-ID: <ab791897-6398-f38e-c2a6-f54c5ca5e1c5@grimberg.me> (raw) In-Reply-To: <20200930162010.21610-3-borisp@mellanox.com> > + * tcp_ddp.h > + * Author: Boris Pismenny <borisp@mellanox.com> > + * Copyright (C) 2020 Mellanox Technologies. > + */ > +#ifndef _TCP_DDP_H > +#define _TCP_DDP_H > + > +#include <linux/blkdev.h> Why is blkdev.h needed? > +#include <linux/netdevice.h> > +#include <net/inet_connection_sock.h> > +#include <net/sock.h> > + > +/* limits returned by the offload driver, zero means don't care */ > +struct tcp_ddp_limits { > + int max_ddp_sgl_len; > +}; > + > +enum tcp_ddp_type { > + TCP_DDP_NVME = 1, > +}; > + > +struct tcp_ddp_config { > + enum tcp_ddp_type type; > + unsigned char buf[]; A little kdoc may help here as its not exactly clear what is buf used for (at this point at least)... > +}; > + > +struct nvme_tcp_config { struct nvme_tcp_ddp_config > + struct tcp_ddp_config cfg; > + > + u16 pfv; > + u8 cpda; > + u8 dgst; > + int queue_size; > + int queue_id; > + int io_cpu; > +}; > + Other than that this looks good to me.
WARNING: multiple messages have this Message-ID (diff)
From: Sagi Grimberg <sagi@grimberg.me> To: Boris Pismenny <borisp@mellanox.com>, kuba@kernel.org, davem@davemloft.net, saeedm@nvidia.com, hch@lst.de, axboe@fb.com, kbusch@kernel.org, viro@zeniv.linux.org.uk, edumazet@google.com Cc: Yoray Zack <yorayz@mellanox.com>, Ben Ben-Ishay <benishay@mellanox.com>, boris.pismenny@gmail.com, linux-nvme@lists.infradead.org, netdev@vger.kernel.org, Or Gerlitz <ogerlitz@mellanox.com> Subject: Re: [PATCH net-next RFC v1 02/10] net: Introduce direct data placement tcp offload Date: Thu, 8 Oct 2020 14:47:08 -0700 [thread overview] Message-ID: <ab791897-6398-f38e-c2a6-f54c5ca5e1c5@grimberg.me> (raw) In-Reply-To: <20200930162010.21610-3-borisp@mellanox.com> > + * tcp_ddp.h > + * Author: Boris Pismenny <borisp@mellanox.com> > + * Copyright (C) 2020 Mellanox Technologies. > + */ > +#ifndef _TCP_DDP_H > +#define _TCP_DDP_H > + > +#include <linux/blkdev.h> Why is blkdev.h needed? > +#include <linux/netdevice.h> > +#include <net/inet_connection_sock.h> > +#include <net/sock.h> > + > +/* limits returned by the offload driver, zero means don't care */ > +struct tcp_ddp_limits { > + int max_ddp_sgl_len; > +}; > + > +enum tcp_ddp_type { > + TCP_DDP_NVME = 1, > +}; > + > +struct tcp_ddp_config { > + enum tcp_ddp_type type; > + unsigned char buf[]; A little kdoc may help here as its not exactly clear what is buf used for (at this point at least)... > +}; > + > +struct nvme_tcp_config { struct nvme_tcp_ddp_config > + struct tcp_ddp_config cfg; > + > + u16 pfv; > + u8 cpda; > + u8 dgst; > + int queue_size; > + int queue_id; > + int io_cpu; > +}; > + Other than that this looks good to me. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-10-08 21:47 UTC|newest] Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-30 16:20 [PATCH net-next RFC v1 00/10] nvme-tcp receive offloads Boris Pismenny 2020-09-30 16:20 ` Boris Pismenny 2020-09-30 16:20 ` [PATCH net-next RFC v1 01/10] iov_iter: Skip copy in memcpy_to_page if src==dst Boris Pismenny 2020-09-30 16:20 ` Boris Pismenny 2020-10-08 23:05 ` Sagi Grimberg 2020-10-08 23:05 ` Sagi Grimberg 2020-09-30 16:20 ` [PATCH net-next RFC v1 02/10] net: Introduce direct data placement tcp offload Boris Pismenny 2020-09-30 16:20 ` Boris Pismenny 2020-10-08 21:47 ` Sagi Grimberg [this message] 2020-10-08 21:47 ` Sagi Grimberg 2020-10-11 14:44 ` Boris Pismenny 2020-10-11 14:44 ` Boris Pismenny 2020-09-30 16:20 ` [PATCH net-next RFC v1 03/10] net: Introduce crc offload for tcp ddp ulp Boris Pismenny 2020-09-30 16:20 ` Boris Pismenny 2020-10-08 21:51 ` Sagi Grimberg 2020-10-08 21:51 ` Sagi Grimberg 2020-10-11 14:58 ` Boris Pismenny 2020-10-11 14:58 ` Boris Pismenny 2020-09-30 16:20 ` [PATCH net-next RFC v1 04/10] net/tls: expose get_netdev_for_sock Boris Pismenny 2020-09-30 16:20 ` Boris Pismenny 2020-10-08 21:56 ` Sagi Grimberg 2020-10-08 21:56 ` Sagi Grimberg 2020-09-30 16:20 ` [PATCH net-next RFC v1 05/10] nvme-tcp: Add DDP offload control path Boris Pismenny 2020-09-30 16:20 ` Boris Pismenny 2020-10-08 22:19 ` Sagi Grimberg 2020-10-08 22:19 ` Sagi Grimberg 2020-10-19 18:28 ` Boris Pismenny 2020-10-19 18:28 ` Boris Pismenny [not found] ` <PH0PR18MB3845430DDF572E0DD4832D06CCED0@PH0PR18MB3845.namprd18.prod.outlook.com> 2020-11-08 6:51 ` Shai Malin 2020-11-08 6:51 ` Shai Malin 2020-11-09 23:23 ` Sagi Grimberg 2020-11-09 23:23 ` Sagi Grimberg 2020-11-11 5:12 ` FW: " Shai Malin 2020-11-11 5:12 ` Shai Malin 2020-11-11 5:43 ` Shai Malin 2020-11-11 5:43 ` Shai Malin 2020-09-30 16:20 ` [PATCH net-next RFC v1 06/10] nvme-tcp: Add DDP data-path Boris Pismenny 2020-09-30 16:20 ` Boris Pismenny 2020-10-08 22:29 ` Sagi Grimberg 2020-10-08 22:29 ` Sagi Grimberg 2020-10-08 23:00 ` Sagi Grimberg 2020-10-08 23:00 ` Sagi Grimberg 2020-11-08 13:59 ` Boris Pismenny 2020-11-08 13:59 ` Boris Pismenny 2020-11-08 9:44 ` Boris Pismenny 2020-11-08 9:44 ` Boris Pismenny 2020-11-09 23:18 ` Sagi Grimberg 2020-11-09 23:18 ` Sagi Grimberg 2020-09-30 16:20 ` [PATCH net-next RFC v1 07/10] nvme-tcp : Recalculate crc in the end of the capsule Boris Pismenny 2020-09-30 16:20 ` Boris Pismenny 2020-10-08 22:44 ` Sagi Grimberg 2020-10-08 22:44 ` Sagi Grimberg [not found] ` <PH0PR18MB3845764B48FD24C87FA34304CCED0@PH0PR18MB3845.namprd18.prod.outlook.com> [not found] ` <PH0PR18MB38458FD325BD77983D2623D4CCEB0@PH0PR18MB3845.namprd18.prod.outlook.com> 2020-11-08 6:59 ` Shai Malin 2020-11-08 6:59 ` Shai Malin 2020-11-08 7:28 ` Boris Pismenny 2020-11-08 7:28 ` Boris Pismenny 2020-11-08 14:46 ` Boris Pismenny 2020-11-08 14:46 ` Boris Pismenny 2020-09-30 16:20 ` [PATCH net-next RFC v1 08/10] nvme-tcp: Deal with netdevice DOWN events Boris Pismenny 2020-09-30 16:20 ` Boris Pismenny 2020-10-08 22:47 ` Sagi Grimberg 2020-10-08 22:47 ` Sagi Grimberg 2020-10-11 6:54 ` Or Gerlitz 2020-10-11 6:54 ` Or Gerlitz 2020-09-30 16:20 ` [PATCH net-next RFC v1 09/10] net/mlx5e: Add NVMEoTCP offload Boris Pismenny 2020-09-30 16:20 ` Boris Pismenny 2020-09-30 22:33 ` kernel test robot 2020-10-01 0:26 ` kernel test robot 2020-09-30 16:20 ` [PATCH net-next RFC v1 10/10] net/mlx5e: NVMEoTCP, data-path for DDP offload Boris Pismenny 2020-09-30 16:20 ` Boris Pismenny 2020-10-01 1:10 ` kernel test robot 2020-10-09 0:08 ` [PATCH net-next RFC v1 00/10] nvme-tcp receive offloads Sagi Grimberg 2020-10-09 0:08 ` Sagi Grimberg
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ab791897-6398-f38e-c2a6-f54c5ca5e1c5@grimberg.me \ --to=sagi@grimberg.me \ --cc=axboe@fb.com \ --cc=benishay@mellanox.com \ --cc=boris.pismenny@gmail.com \ --cc=borisp@mellanox.com \ --cc=davem@davemloft.net \ --cc=edumazet@google.com \ --cc=hch@lst.de \ --cc=kbusch@kernel.org \ --cc=kuba@kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=netdev@vger.kernel.org \ --cc=ogerlitz@mellanox.com \ --cc=saeedm@nvidia.com \ --cc=viro@zeniv.linux.org.uk \ --cc=yorayz@mellanox.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.