All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Jens Axboe <axboe@kernel.dk>,
	Damien Le Moal <damien.lemoal@wdc.com>,
	linux-block@vger.kernel.org,
	Paolo Valente <paolo.valente@linaro.org>,
	linux-f2fs-devel@lists.sourceforge.net,
	Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <yuchao0@huawei.com>
Subject: Re: [PATCH v3 2/4] block: fix ioprio interface
Date: Sun, 8 Aug 2021 15:29:41 +0900	[thread overview]
Message-ID: <ab7925cb-c6a3-0c32-093b-9ac8f17f0c3f@opensource.wdc.com> (raw)
In-Reply-To: <0141fb21-c0dc-d743-6af9-c2b26d34c4ba@kernel.dk>

On 2021/08/08 1:18, Jens Axboe wrote:
> On 8/6/21 5:18 AM, Damien Le Moal wrote:
>> An iocb aio_reqprio field is 16-bits (u16) but often handled as an int
>> in the block layer. E.g. ioprio_check_cap() takes an int as argument.
> 
> I'd just reference kiocb->ki_ioprio, that's transport agnostic.
> 
> Apart from that, this one looks fine to me. A better commit title
> would do wonders too, though, it's very non-descript.

OK. Will cleanup commit title and message.


-- 
Damien Le Moal
Western Digital Research

WARNING: multiple messages have this Message-ID (diff)
From: Damien Le Moal via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Jens Axboe <axboe@kernel.dk>,
	Damien Le Moal <damien.lemoal@wdc.com>,
	linux-block@vger.kernel.org,
	Paolo Valente <paolo.valente@linaro.org>,
	linux-f2fs-devel@lists.sourceforge.net,
	Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <yuchao0@huawei.com>
Subject: Re: [f2fs-dev] [PATCH v3 2/4] block: fix ioprio interface
Date: Sun, 8 Aug 2021 15:29:41 +0900	[thread overview]
Message-ID: <ab7925cb-c6a3-0c32-093b-9ac8f17f0c3f@opensource.wdc.com> (raw)
In-Reply-To: <0141fb21-c0dc-d743-6af9-c2b26d34c4ba@kernel.dk>

On 2021/08/08 1:18, Jens Axboe wrote:
> On 8/6/21 5:18 AM, Damien Le Moal wrote:
>> An iocb aio_reqprio field is 16-bits (u16) but often handled as an int
>> in the block layer. E.g. ioprio_check_cap() takes an int as argument.
> 
> I'd just reference kiocb->ki_ioprio, that's transport agnostic.
> 
> Apart from that, this one looks fine to me. A better commit title
> would do wonders too, though, it's very non-descript.

OK. Will cleanup commit title and message.


-- 
Damien Le Moal
Western Digital Research


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2021-08-08  6:29 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-06 11:18 [PATCH v3 0/4] IO priority fixes and improvements Damien Le Moal
2021-08-06 11:18 ` [f2fs-dev] " Damien Le Moal
2021-08-06 11:18 ` [PATCH v3 1/4] block: bfq: fix bfq_set_next_ioprio_data() Damien Le Moal
2021-08-06 11:18   ` [f2fs-dev] " Damien Le Moal
2021-08-06 11:18 ` [PATCH v3 2/4] block: fix ioprio interface Damien Le Moal
2021-08-06 11:18   ` [f2fs-dev] " Damien Le Moal
2021-08-07 16:18   ` Jens Axboe
2021-08-07 16:18     ` [f2fs-dev] " Jens Axboe
2021-08-08  6:29     ` Damien Le Moal [this message]
2021-08-08  6:29       ` Damien Le Moal via Linux-f2fs-devel
2021-08-06 11:18 ` [PATCH v3 3/4] block: rename IOPRIO_BE_NR Damien Le Moal
2021-08-06 11:18   ` [f2fs-dev] " Damien Le Moal
2021-08-06 11:38   ` Hannes Reinecke
2021-08-06 11:38     ` [f2fs-dev] " Hannes Reinecke
2021-08-07 16:16   ` Jens Axboe
2021-08-07 16:16     ` [f2fs-dev] " Jens Axboe
2021-08-08  6:29     ` Damien Le Moal
2021-08-08  6:29       ` [f2fs-dev] " Damien Le Moal via Linux-f2fs-devel
2021-08-09  7:45     ` Christoph Hellwig
2021-08-09  7:45       ` [f2fs-dev] " Christoph Hellwig
2021-08-06 11:18 ` [PATCH v3 4/4] block: fix default IO priority handling Damien Le Moal
2021-08-06 11:18   ` [f2fs-dev] " Damien Le Moal
2021-08-07 16:19   ` Jens Axboe
2021-08-07 16:19     ` [f2fs-dev] " Jens Axboe
2021-08-08  6:31     ` Damien Le Moal
2021-08-08  6:31       ` [f2fs-dev] " Damien Le Moal via Linux-f2fs-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab7925cb-c6a3-0c32-093b-9ac8f17f0c3f@opensource.wdc.com \
    --to=damien.lemoal@opensource.wdc.com \
    --cc=axboe@kernel.dk \
    --cc=damien.lemoal@wdc.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=paolo.valente@linaro.org \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.