From: Tal Gilboa <talgi@mellanox.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, tariqt@mellanox.com,
andrew.gospodarek@broadcom.com, saeedm@mellanox.com
Subject: Re: [PATCH net-next 0/4] Introduce adaptive TX interrupt moderation to net DIM
Date: Sun, 1 Apr 2018 09:49:21 +0300 [thread overview]
Message-ID: <ab7dafdf-e21d-183a-d032-fca89678574b@mellanox.com> (raw)
In-Reply-To: <20180331.231929.1875689505974197531.davem@davemloft.net>
On 4/1/2018 6:19 AM, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Sat, 31 Mar 2018 22:02:55 -0400 (EDT)
>
>> From: Tal Gilboa <talgi@mellanox.com>
>> Date: Fri, 30 Mar 2018 09:37:29 +0300
>>
>>> Net DIM is a library designed for dynamic interrupt moderation. It was
>>> implemented and optimized with receive side interrupts in mind, since these
>>> are usually the CPU expensive ones. This patch-set introduces adaptive transmit
>>> interrupt moderation to net DIM, complete with a usage in the mlx5e driver.
>>> Using adaptive TX behavior would reduce interrupt rate for multiple scenarios.
>>> Furthermore, it is essential for increasing bandwidth on cases where payload
>>> aggregation is required.
>>
>> Series applied.
>
> This breaks the build:
>
> drivers/net/ethernet/broadcom/bcmsysport.c: In function ‘bcm_sysport_set_coalesce’:
> drivers/net/ethernet/broadcom/bcmsysport.c:657:11: error: implicit declaration of function ‘net_dim_get_def_profile’; did you mean ‘net_dim_exit_parking’? [-Werror=implicit-function-declaration]
> moder = net_dim_get_def_profile(priv->dim.dim.mode);
> ^~~~~~~~~~~~~~~~~~~~~~~
>
Rebase issues, sorry.
Sent a fixup patch.
prev parent reply other threads:[~2018-04-01 6:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 6:37 [PATCH net-next 0/4] Introduce adaptive TX interrupt moderation to net DIM Tal Gilboa
2018-03-30 6:37 ` [PATCH net-next 1/4] net/dim: Rename *_get_profile() functions to *_get_rx_moderation() Tal Gilboa
2018-03-30 6:37 ` [PATCH net-next 2/4] net/dim: Add "enabled" field to net_dim struct Tal Gilboa
2018-03-30 6:37 ` [PATCH net-next 3/4] net/dim: Support adaptive TX moderation Tal Gilboa
2018-03-30 6:37 ` [PATCH net-next 4/4] net/mlx5e: Enable adaptive-TX moderation Tal Gilboa
2018-03-30 6:43 ` [PATCH net-next 0/4] Introduce adaptive TX interrupt moderation to net DIM Tal Gilboa
2018-04-01 2:02 ` David Miller
2018-04-01 3:19 ` David Miller
2018-04-01 6:49 ` Tal Gilboa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab7dafdf-e21d-183a-d032-fca89678574b@mellanox.com \
--to=talgi@mellanox.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.