From: houlong wei <houlong.wei@mediatek.com>
To: Eizan Miyamoto <eizan@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "wenst@chromium.org" <wenst@chromium.org>,
"Yong Wu (吴勇)" <Yong.Wu@mediatek.com>,
"enric.balletbo@collabora.com" <enric.balletbo@collabora.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
"Andrew-CT Chen (陳智迪)" <Andrew-CT.Chen@mediatek.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Minghsiu Tsai (蔡明修)" <Minghsiu.Tsai@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
houlong.wei@mediatek.com
Subject: Re: [PATCH v6 3/9] mtk-mdp: use pm_runtime in MDP component driver
Date: Mon, 16 Aug 2021 09:07:42 +0800 [thread overview]
Message-ID: <ab83cb2c6fd8fa89b72a1cd215e8258c2b4d2c63.camel@mediatek.com> (raw)
In-Reply-To: <20210802220943.v6.3.I909f5375d930f5d0cc877128e30e2a67078b674c@changeid>
On Mon, 2021-08-02 at 20:12 +0800, Eizan Miyamoto wrote:
> Without this change, the MDP components are not fully integrated into
> the runtime power management subsystem, and the MDP driver does not
> work.
>
> For each of the component device drivers to be able to call
> pm_runtime_get/put_sync() a pointer to the component's device struct
> had to be added to struct mtk_mdp_comp, set by mtk_mdp_comp_init().
>
> Note that the dev argument to mtk_mdp_comp_clock_on/off() has been
> removed. Those functions used to be called from the "master" mdp
> driver
> in mtk_mdp_core.c, but the component's device pointer no longer
> corresponds to the mdp master device pointer, which is not the right
> device to pass to pm_runtime_put/get_sync() which we had to add to
> get
> the driver to work properly.
>
> Signed-off-by: Eizan Miyamoto <eizan@chromium.org>
> ---
>
Reviewed-by: Houlong Wei <houlong.wei@mediatek.com>
> (no changes since v1)
>
[...]
WARNING: multiple messages have this Message-ID (diff)
From: houlong wei <houlong.wei@mediatek.com>
To: Eizan Miyamoto <eizan@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "wenst@chromium.org" <wenst@chromium.org>,
"Yong Wu (吴勇)" <Yong.Wu@mediatek.com>,
"enric.balletbo@collabora.com" <enric.balletbo@collabora.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
"Andrew-CT Chen (陳智迪)" <Andrew-CT.Chen@mediatek.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Minghsiu Tsai (蔡明修)" <Minghsiu.Tsai@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
houlong.wei@mediatek.com
Subject: Re: [PATCH v6 3/9] mtk-mdp: use pm_runtime in MDP component driver
Date: Mon, 16 Aug 2021 09:07:42 +0800 [thread overview]
Message-ID: <ab83cb2c6fd8fa89b72a1cd215e8258c2b4d2c63.camel@mediatek.com> (raw)
In-Reply-To: <20210802220943.v6.3.I909f5375d930f5d0cc877128e30e2a67078b674c@changeid>
On Mon, 2021-08-02 at 20:12 +0800, Eizan Miyamoto wrote:
> Without this change, the MDP components are not fully integrated into
> the runtime power management subsystem, and the MDP driver does not
> work.
>
> For each of the component device drivers to be able to call
> pm_runtime_get/put_sync() a pointer to the component's device struct
> had to be added to struct mtk_mdp_comp, set by mtk_mdp_comp_init().
>
> Note that the dev argument to mtk_mdp_comp_clock_on/off() has been
> removed. Those functions used to be called from the "master" mdp
> driver
> in mtk_mdp_core.c, but the component's device pointer no longer
> corresponds to the mdp master device pointer, which is not the right
> device to pass to pm_runtime_put/get_sync() which we had to add to
> get
> the driver to work properly.
>
> Signed-off-by: Eizan Miyamoto <eizan@chromium.org>
> ---
>
Reviewed-by: Houlong Wei <houlong.wei@mediatek.com>
> (no changes since v1)
>
[...]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: houlong wei <houlong.wei@mediatek.com>
To: Eizan Miyamoto <eizan@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "wenst@chromium.org" <wenst@chromium.org>,
"Yong Wu (吴勇)" <Yong.Wu@mediatek.com>,
"enric.balletbo@collabora.com" <enric.balletbo@collabora.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
"Andrew-CT Chen (陳智迪)" <Andrew-CT.Chen@mediatek.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Minghsiu Tsai (蔡明修)" <Minghsiu.Tsai@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
houlong.wei@mediatek.com
Subject: Re: [PATCH v6 3/9] mtk-mdp: use pm_runtime in MDP component driver
Date: Mon, 16 Aug 2021 09:07:42 +0800 [thread overview]
Message-ID: <ab83cb2c6fd8fa89b72a1cd215e8258c2b4d2c63.camel@mediatek.com> (raw)
In-Reply-To: <20210802220943.v6.3.I909f5375d930f5d0cc877128e30e2a67078b674c@changeid>
On Mon, 2021-08-02 at 20:12 +0800, Eizan Miyamoto wrote:
> Without this change, the MDP components are not fully integrated into
> the runtime power management subsystem, and the MDP driver does not
> work.
>
> For each of the component device drivers to be able to call
> pm_runtime_get/put_sync() a pointer to the component's device struct
> had to be added to struct mtk_mdp_comp, set by mtk_mdp_comp_init().
>
> Note that the dev argument to mtk_mdp_comp_clock_on/off() has been
> removed. Those functions used to be called from the "master" mdp
> driver
> in mtk_mdp_core.c, but the component's device pointer no longer
> corresponds to the mdp master device pointer, which is not the right
> device to pass to pm_runtime_put/get_sync() which we had to add to
> get
> the driver to work properly.
>
> Signed-off-by: Eizan Miyamoto <eizan@chromium.org>
> ---
>
Reviewed-by: Houlong Wei <houlong.wei@mediatek.com>
> (no changes since v1)
>
[...]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-16 1:07 UTC|newest]
Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 12:12 [PATCH v6 0/9] Refactor MTK MDP driver into core/components Eizan Miyamoto
2021-08-02 12:12 ` Eizan Miyamoto
2021-08-02 12:12 ` Eizan Miyamoto
2021-08-02 12:12 ` [PATCH v6 1/9] mtk-mdp: propagate errors from clock_on Eizan Miyamoto
2021-08-02 12:12 ` Eizan Miyamoto
2021-08-02 12:12 ` Eizan Miyamoto
2021-08-03 10:26 ` Enric Balletbo Serra
2021-08-03 10:26 ` Enric Balletbo Serra
2021-08-03 10:26 ` Enric Balletbo Serra
2021-08-05 6:06 ` Dafna Hirschfeld
2021-08-05 6:06 ` Dafna Hirschfeld
2021-08-05 6:06 ` Dafna Hirschfeld
2021-08-09 3:23 ` Eizan Miyamoto
2021-08-09 3:23 ` Eizan Miyamoto
2021-08-09 3:23 ` Eizan Miyamoto
2021-08-09 7:42 ` Dafna Hirschfeld
2021-08-09 7:42 ` Dafna Hirschfeld
2021-08-09 7:42 ` Dafna Hirschfeld
2021-08-16 0:46 ` houlong wei
2021-08-16 0:46 ` houlong wei
2021-08-16 0:46 ` houlong wei
2021-08-02 12:12 ` [PATCH v6 2/9] mtk-mdp: add driver to probe mdp components Eizan Miyamoto
2021-08-02 12:12 ` Eizan Miyamoto
2021-08-02 12:12 ` Eizan Miyamoto
2021-08-03 10:26 ` Enric Balletbo Serra
2021-08-03 10:26 ` Enric Balletbo Serra
2021-08-03 10:26 ` Enric Balletbo Serra
2021-08-05 6:40 ` Dafna Hirschfeld
2021-08-05 6:40 ` Dafna Hirschfeld
2021-08-05 6:40 ` Dafna Hirschfeld
2021-08-09 3:23 ` Eizan Miyamoto
2021-08-09 3:23 ` Eizan Miyamoto
2021-08-09 3:23 ` Eizan Miyamoto
2021-08-09 7:53 ` Dafna Hirschfeld
2021-08-09 7:53 ` Dafna Hirschfeld
2021-08-09 7:53 ` Dafna Hirschfeld
2021-08-11 11:15 ` Eizan Miyamoto
2021-08-11 11:15 ` Eizan Miyamoto
2021-08-11 11:15 ` Eizan Miyamoto
2021-08-16 1:05 ` houlong wei
2021-08-16 1:05 ` houlong wei
2021-08-16 1:05 ` houlong wei
2021-08-02 12:12 ` [PATCH v6 3/9] mtk-mdp: use pm_runtime in MDP component driver Eizan Miyamoto
2021-08-02 12:12 ` Eizan Miyamoto
2021-08-02 12:12 ` Eizan Miyamoto
2021-08-03 10:26 ` Enric Balletbo Serra
2021-08-03 10:26 ` Enric Balletbo Serra
2021-08-03 10:26 ` Enric Balletbo Serra
2021-08-16 1:07 ` houlong wei [this message]
2021-08-16 1:07 ` houlong wei
2021-08-16 1:07 ` houlong wei
2021-08-02 12:12 ` [PATCH v6 4/9] media: mtk-mdp: don't pm_run_time_get/put for master comp in clock_on Eizan Miyamoto
2021-08-02 12:12 ` Eizan Miyamoto
2021-08-02 12:12 ` Eizan Miyamoto
2021-08-03 10:27 ` Enric Balletbo Serra
2021-08-03 10:27 ` Enric Balletbo Serra
2021-08-03 10:27 ` Enric Balletbo Serra
2021-08-16 1:10 ` houlong wei
2021-08-16 1:10 ` houlong wei
2021-08-16 1:10 ` houlong wei
2021-08-02 12:12 ` [PATCH v6 5/9] mtk-mdp: make mdp driver to be loadable by platform_device_register*() Eizan Miyamoto
2021-08-02 12:12 ` Eizan Miyamoto
2021-08-02 12:12 ` Eizan Miyamoto
2021-08-03 10:27 ` Enric Balletbo Serra
2021-08-03 10:27 ` Enric Balletbo Serra
2021-08-03 10:27 ` Enric Balletbo Serra
2021-08-16 1:15 ` houlong wei
2021-08-16 1:15 ` houlong wei
2021-08-16 1:15 ` houlong wei
2021-08-16 3:37 ` houlong wei
2021-08-16 3:37 ` houlong wei
2021-08-16 3:37 ` houlong wei
2021-08-02 12:12 ` [PATCH v6 6/9] soc: mediatek: mmsys: instantiate mdp virtual device from mmsys Eizan Miyamoto
2021-08-02 12:12 ` Eizan Miyamoto
2021-08-02 12:12 ` Eizan Miyamoto
2021-08-03 10:27 ` Enric Balletbo Serra
2021-08-03 10:27 ` Enric Balletbo Serra
2021-08-03 10:27 ` Enric Balletbo Serra
2021-08-16 1:18 ` houlong wei
2021-08-16 1:18 ` houlong wei
2021-08-16 1:18 ` houlong wei
2021-08-02 12:12 ` [PATCH v6 7/9] media: mtk-mdp: use mdp-rdma0 alias to point to MDP master Eizan Miyamoto
2021-08-02 12:12 ` Eizan Miyamoto
2021-08-02 12:12 ` Eizan Miyamoto
2021-08-03 10:27 ` Enric Balletbo Serra
2021-08-03 10:27 ` Enric Balletbo Serra
2021-08-03 10:27 ` Enric Balletbo Serra
2021-08-03 11:46 ` Eizan Miyamoto
2021-08-03 11:46 ` Eizan Miyamoto
2021-08-03 11:46 ` Eizan Miyamoto
2021-08-16 3:00 ` houlong wei
2021-08-16 3:00 ` houlong wei
2021-08-16 3:00 ` houlong wei
2021-08-16 4:52 ` houlong wei
2021-08-16 4:52 ` houlong wei
2021-08-16 4:52 ` houlong wei
2021-08-18 7:50 ` Eizan Miyamoto
2021-08-18 7:50 ` Eizan Miyamoto
2021-08-18 7:50 ` Eizan Miyamoto
2021-08-18 15:42 ` houlong wei
2021-08-18 15:42 ` houlong wei
2021-08-18 15:42 ` houlong wei
2021-08-18 7:43 ` Eizan Miyamoto
2021-08-18 7:43 ` Eizan Miyamoto
2021-08-18 7:43 ` Eizan Miyamoto
2021-08-18 15:34 ` houlong wei
2021-08-18 15:34 ` houlong wei
2021-08-18 15:34 ` houlong wei
2021-08-02 12:12 ` [PATCH v6 8/9] dts: mtk-mdp: remove mediatek,vpu property from primary MDP device Eizan Miyamoto
2021-08-02 12:12 ` [PATCH v6 8/9] dts: mtk-mdp: remove mediatek, vpu " Eizan Miyamoto
2021-08-02 12:12 ` Eizan Miyamoto
2021-08-03 10:27 ` [PATCH v6 8/9] dts: mtk-mdp: remove mediatek,vpu " Enric Balletbo Serra
2021-08-03 10:27 ` Enric Balletbo Serra
2021-08-03 10:27 ` Enric Balletbo Serra
2021-08-02 12:12 ` [PATCH v6 9/9] dt-bindings: mediatek: remove vpu requirement from mtk-mdp Eizan Miyamoto
2021-08-02 12:12 ` Eizan Miyamoto
2021-08-02 12:12 ` Eizan Miyamoto
2021-08-03 10:27 ` Enric Balletbo Serra
2021-08-03 10:27 ` Enric Balletbo Serra
2021-08-03 10:27 ` Enric Balletbo Serra
2021-08-06 21:47 ` Rob Herring
2021-08-06 21:47 ` Rob Herring
2021-08-06 21:47 ` Rob Herring
2021-08-03 10:29 ` [PATCH v6 0/9] Refactor MTK MDP driver into core/components Enric Balletbo Serra
2021-08-03 10:29 ` Enric Balletbo Serra
2021-08-03 10:29 ` Enric Balletbo Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab83cb2c6fd8fa89b72a1cd215e8258c2b4d2c63.camel@mediatek.com \
--to=houlong.wei@mediatek.com \
--cc=Andrew-CT.Chen@mediatek.com \
--cc=Minghsiu.Tsai@mediatek.com \
--cc=Yong.Wu@mediatek.com \
--cc=chunkuang.hu@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eizan@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.