All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	Hyun Kwon <hyun.kwon@xilinx.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Michal Simek <michal.simek@xilinx.com>,
	<dri-devel@lists.freedesktop.org>,
	<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] drm: xlnx: zynqmp: fix a memset in zynqmp_dp_train()
Date: Wed, 7 Apr 2021 12:17:49 +0200	[thread overview]
Message-ID: <abae16c0-6d76-f78f-133c-0a0d54bc60a9@xilinx.com> (raw)
In-Reply-To: <YGLwCBMotnrKZu6P@mwanda>



On 3/30/21 11:31 AM, Dan Carpenter wrote:
> The dp->train_set[] for this driver is only two characters, not four so
> this memsets too much.  Fortunately, this ends up corrupting a struct
> hole and not anything important.
> 
> Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> index 99158ee67d02..59d1fb017da0 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> @@ -866,7 +866,7 @@ static int zynqmp_dp_train(struct zynqmp_dp *dp)
>  		return ret;
>  
>  	zynqmp_dp_write(dp, ZYNQMP_DP_SCRAMBLING_DISABLE, 1);
> -	memset(dp->train_set, 0, 4);
> +	memset(dp->train_set, 0, sizeof(dp->train_set));
>  	ret = zynqmp_dp_link_train_cr(dp);
>  	if (ret)
>  		return ret;
> 

Reviewed-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <michal.simek@xilinx.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	Hyun Kwon <hyun.kwon@xilinx.com>
Cc: David Airlie <airlied@linux.ie>,
	kernel-janitors@vger.kernel.org,
	Michal Simek <michal.simek@xilinx.com>,
	dri-devel@lists.freedesktop.org,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] drm: xlnx: zynqmp: fix a memset in zynqmp_dp_train()
Date: Wed, 7 Apr 2021 12:17:49 +0200	[thread overview]
Message-ID: <abae16c0-6d76-f78f-133c-0a0d54bc60a9@xilinx.com> (raw)
In-Reply-To: <YGLwCBMotnrKZu6P@mwanda>



On 3/30/21 11:31 AM, Dan Carpenter wrote:
> The dp->train_set[] for this driver is only two characters, not four so
> this memsets too much.  Fortunately, this ends up corrupting a struct
> hole and not anything important.
> 
> Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> index 99158ee67d02..59d1fb017da0 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> @@ -866,7 +866,7 @@ static int zynqmp_dp_train(struct zynqmp_dp *dp)
>  		return ret;
>  
>  	zynqmp_dp_write(dp, ZYNQMP_DP_SCRAMBLING_DISABLE, 1);
> -	memset(dp->train_set, 0, 4);
> +	memset(dp->train_set, 0, sizeof(dp->train_set));
>  	ret = zynqmp_dp_link_train_cr(dp);
>  	if (ret)
>  		return ret;
> 

Reviewed-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2021-04-07 10:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-30  9:31 [PATCH] drm: xlnx: zynqmp: fix a memset in zynqmp_dp_train() Dan Carpenter
2021-03-30  9:31 ` Dan Carpenter
2021-04-07 10:17 ` Michal Simek [this message]
2021-04-07 10:17   ` Michal Simek
2021-04-08 10:53   ` Daniel Vetter
2021-04-08 10:53     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abae16c0-6d76-f78f-133c-0a0d54bc60a9@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=airlied@linux.ie \
    --cc=dan.carpenter@oracle.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hyun.kwon@xilinx.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.