All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>,
	jfs-discussion@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Dave Kleikamp <shaggy@kernel.org>
Subject: Re: [PATCH] fs: jfs: fix a possible data race in txBegin()
Date: Tue, 5 May 2020 12:10:20 +0800	[thread overview]
Message-ID: <abbb03ec-7ce3-08b6-7d08-420743067f19@gmail.com> (raw)
In-Reply-To: <5ef374a5-0e2e-5c74-a827-0148c384f6e3@web.de>



On 2020/5/5 0:15, Markus Elfring wrote:
>> Thus, a data race can occur for tblk->flag.
>>
>> To fix this data race, the spinlock log->gclock is used in
>> txBegin().
>>
>> This data race is found by our concurrency fuzzer.
> How do you think about a wording variant like the following?
>
>     Change description:
>     A data race can occur for the data structure member “flag”.
>     This data race was found by our concurrency fuzzer.
>
>     Thus use the spin lock “gclock” for the resetting of five
>     data structure members in this function implementation.
>
>
> Would you like to add the tag “Fixes” to the commit message?
>

Thanks, Markus.
I am not sure how to add the tag "Fixes"...
I need to find which previous commit add the code about txBegin()?


Best wishes,
Jia-Ju Bai

WARNING: multiple messages have this Message-ID (diff)
From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>,
	jfs-discussion@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Dave Kleikamp <shaggy@kernel.org>
Subject: Re: [PATCH] fs: jfs: fix a possible data race in txBegin()
Date: Tue, 05 May 2020 04:10:20 +0000	[thread overview]
Message-ID: <abbb03ec-7ce3-08b6-7d08-420743067f19@gmail.com> (raw)
In-Reply-To: <5ef374a5-0e2e-5c74-a827-0148c384f6e3@web.de>



On 2020/5/5 0:15, Markus Elfring wrote:
>> Thus, a data race can occur for tblk->flag.
>>
>> To fix this data race, the spinlock log->gclock is used in
>> txBegin().
>>
>> This data race is found by our concurrency fuzzer.
> How do you think about a wording variant like the following?
>
>     Change description:
>     A data race can occur for the data structure member “flag”.
>     This data race was found by our concurrency fuzzer.
>
>     Thus use the spin lock “gclock” for the resetting of five
>     data structure members in this function implementation.
>
>
> Would you like to add the tag “Fixes” to the commit message?
>

Thanks, Markus.
I am not sure how to add the tag "Fixes"...
I need to find which previous commit add the code about txBegin()?


Best wishes,
Jia-Ju Bai

  reply	other threads:[~2020-05-05  4:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-04 16:15 [PATCH] fs: jfs: fix a possible data race in txBegin() Markus Elfring
2020-05-04 16:15 ` Markus Elfring
2020-05-05  4:10 ` Jia-Ju Bai [this message]
2020-05-05  4:10   ` Jia-Ju Bai
2020-05-05  5:12   ` Markus Elfring
2020-05-05  5:12     ` Markus Elfring
2020-05-05 13:04     ` Jia-Ju Bai
2020-05-05 13:04       ` Jia-Ju Bai
2020-05-05 13:23     ` Dave Kleikamp
2020-05-05 13:23       ` Dave Kleikamp
2020-05-05 13:32       ` Jia-Ju Bai
2020-05-05 13:32         ` Jia-Ju Bai
  -- strict thread matches above, loose matches on Subject: below --
2020-05-04 16:33 [PATCH] fs: jfs: fix a possible data race in metapage_writepage() Markus Elfring
2020-05-04 16:33 ` Markus Elfring
2020-05-04 15:34 [PATCH] fs: jfs: fix a possible data race in txBegin() Jia-Ju Bai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abbb03ec-7ce3-08b6-7d08-420743067f19@gmail.com \
    --to=baijiaju1990@gmail.com \
    --cc=Markus.Elfring@web.de \
    --cc=jfs-discussion@lists.sourceforge.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shaggy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.