All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Berger <opendmb@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	"open list:BROADCOM GENET ETHERNET DRIVER" 
	<bcm-kernel-feedback-list@broadcom.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: bcmgenet: Use netif_tx_napi_add() for TX NAPI
Date: Thu, 23 Jan 2020 14:05:05 -0800	[thread overview]
Message-ID: <abbd691d-592f-f58d-215b-0f40da485e76@gmail.com> (raw)
In-Reply-To: <20200123174934.29500-1-f.fainelli@gmail.com>

On 1/23/20 9:49 AM, Florian Fainelli wrote:
> Before commit 7587935cfa11 ("net: bcmgenet: move NAPI initialization to
> ring initialization") moved the code, this used to be
> netif_tx_napi_add(), but we lost that small semantic change in the
> process, restore that.
> 
> Fixes: 7587935cfa11 ("net: bcmgenet: move NAPI initialization to ring initialization")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> index 120fa05a39ff..0a8624be44a9 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> @@ -2164,8 +2164,8 @@ static void bcmgenet_init_tx_ring(struct bcmgenet_priv *priv,
>  				  DMA_END_ADDR);
>  
>  	/* Initialize Tx NAPI */
> -	netif_napi_add(priv->dev, &ring->napi, bcmgenet_tx_poll,
> -		       NAPI_POLL_WEIGHT);
> +	netif_tx_napi_add(priv->dev, &ring->napi, bcmgenet_tx_poll,
> +			  NAPI_POLL_WEIGHT);
>  }
>  
>  /* Initialize a RDMA ring */
> 

Acked-by: Doug Berger <opendmb@gmail.com>

Thanks Florian!

  reply	other threads:[~2020-01-23 22:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-23 17:49 [PATCH net] net: bcmgenet: Use netif_tx_napi_add() for TX NAPI Florian Fainelli
2020-01-23 22:05 ` Doug Berger [this message]
2020-01-25  9:32 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abbd691d-592f-f58d-215b-0f40da485e76@gmail.com \
    --to=opendmb@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.