* [PATCH net] net: bcmgenet: Use netif_tx_napi_add() for TX NAPI
@ 2020-01-23 17:49 Florian Fainelli
2020-01-23 22:05 ` Doug Berger
2020-01-25 9:32 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Florian Fainelli @ 2020-01-23 17:49 UTC (permalink / raw)
To: netdev
Cc: Florian Fainelli, Doug Berger, David S. Miller,
open list:BROADCOM GENET ETHERNET DRIVER, open list
Before commit 7587935cfa11 ("net: bcmgenet: move NAPI initialization to
ring initialization") moved the code, this used to be
netif_tx_napi_add(), but we lost that small semantic change in the
process, restore that.
Fixes: 7587935cfa11 ("net: bcmgenet: move NAPI initialization to ring initialization")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
index 120fa05a39ff..0a8624be44a9 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
@@ -2164,8 +2164,8 @@ static void bcmgenet_init_tx_ring(struct bcmgenet_priv *priv,
DMA_END_ADDR);
/* Initialize Tx NAPI */
- netif_napi_add(priv->dev, &ring->napi, bcmgenet_tx_poll,
- NAPI_POLL_WEIGHT);
+ netif_tx_napi_add(priv->dev, &ring->napi, bcmgenet_tx_poll,
+ NAPI_POLL_WEIGHT);
}
/* Initialize a RDMA ring */
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] net: bcmgenet: Use netif_tx_napi_add() for TX NAPI
2020-01-23 17:49 [PATCH net] net: bcmgenet: Use netif_tx_napi_add() for TX NAPI Florian Fainelli
@ 2020-01-23 22:05 ` Doug Berger
2020-01-25 9:32 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Doug Berger @ 2020-01-23 22:05 UTC (permalink / raw)
To: Florian Fainelli, netdev
Cc: David S. Miller, open list:BROADCOM GENET ETHERNET DRIVER, open list
On 1/23/20 9:49 AM, Florian Fainelli wrote:
> Before commit 7587935cfa11 ("net: bcmgenet: move NAPI initialization to
> ring initialization") moved the code, this used to be
> netif_tx_napi_add(), but we lost that small semantic change in the
> process, restore that.
>
> Fixes: 7587935cfa11 ("net: bcmgenet: move NAPI initialization to ring initialization")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> index 120fa05a39ff..0a8624be44a9 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> @@ -2164,8 +2164,8 @@ static void bcmgenet_init_tx_ring(struct bcmgenet_priv *priv,
> DMA_END_ADDR);
>
> /* Initialize Tx NAPI */
> - netif_napi_add(priv->dev, &ring->napi, bcmgenet_tx_poll,
> - NAPI_POLL_WEIGHT);
> + netif_tx_napi_add(priv->dev, &ring->napi, bcmgenet_tx_poll,
> + NAPI_POLL_WEIGHT);
> }
>
> /* Initialize a RDMA ring */
>
Acked-by: Doug Berger <opendmb@gmail.com>
Thanks Florian!
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] net: bcmgenet: Use netif_tx_napi_add() for TX NAPI
2020-01-23 17:49 [PATCH net] net: bcmgenet: Use netif_tx_napi_add() for TX NAPI Florian Fainelli
2020-01-23 22:05 ` Doug Berger
@ 2020-01-25 9:32 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-01-25 9:32 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev, opendmb, bcm-kernel-feedback-list, linux-kernel
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Thu, 23 Jan 2020 09:49:34 -0800
> Before commit 7587935cfa11 ("net: bcmgenet: move NAPI initialization to
> ring initialization") moved the code, this used to be
> netif_tx_napi_add(), but we lost that small semantic change in the
> process, restore that.
>
> Fixes: 7587935cfa11 ("net: bcmgenet: move NAPI initialization to ring initialization")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied, thanks Florian.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-25 9:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-23 17:49 [PATCH net] net: bcmgenet: Use netif_tx_napi_add() for TX NAPI Florian Fainelli
2020-01-23 22:05 ` Doug Berger
2020-01-25 9:32 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.