All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu/sdma: fix typo in packet setup
@ 2016-11-14 18:13 Alex Deucher
       [not found] ` <1479147215-2151-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Alex Deucher @ 2016-11-14 18:13 UTC (permalink / raw)
  To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Alex Deucher

Use the correct define.  No functional change as both
defines are equivalent.

Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 2 +-
 drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c b/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c
index e81aa46..1b44d5b 100644
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c
@@ -775,7 +775,7 @@ static void sdma_v2_4_vm_write_pte(struct amdgpu_ib *ib, uint64_t pe,
 	unsigned ndw = count * 2;
 
 	ib->ptr[ib->length_dw++] = SDMA_PKT_HEADER_OP(SDMA_OP_WRITE) |
-		SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_COPY_LINEAR);
+		SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_WRITE_LINEAR);
 	ib->ptr[ib->length_dw++] = pe;
 	ib->ptr[ib->length_dw++] = upper_32_bits(pe);
 	ib->ptr[ib->length_dw++] = ndw;
diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
index 77f1465..9425c69 100644
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
@@ -977,7 +977,7 @@ static void sdma_v3_0_vm_write_pte(struct amdgpu_ib *ib, uint64_t pe,
 	unsigned ndw = count * 2;
 
 	ib->ptr[ib->length_dw++] = SDMA_PKT_HEADER_OP(SDMA_OP_WRITE) |
-		SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_COPY_LINEAR);
+		SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_WRITE_LINEAR);
 	ib->ptr[ib->length_dw++] = lower_32_bits(pe);
 	ib->ptr[ib->length_dw++] = upper_32_bits(pe);
 	ib->ptr[ib->length_dw++] = ndw;
-- 
2.5.5

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu/sdma: fix typo in packet setup
       [not found] ` <1479147215-2151-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
@ 2016-11-15  1:55   ` zhoucm1
       [not found]     ` <582A6B03.60306-5C7GfCeVMHo@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: zhoucm1 @ 2016-11-15  1:55 UTC (permalink / raw)
  To: Alex Deucher, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Alex Deucher



On 2016年11月15日 02:13, Alex Deucher wrote:
> Use the correct define.  No functional change as both
> defines are equivalent.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Chunming Zhou <david1.zhou@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 2 +-
>   drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c b/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c
> index e81aa46..1b44d5b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c
> @@ -775,7 +775,7 @@ static void sdma_v2_4_vm_write_pte(struct amdgpu_ib *ib, uint64_t pe,
>   	unsigned ndw = count * 2;
>   
>   	ib->ptr[ib->length_dw++] = SDMA_PKT_HEADER_OP(SDMA_OP_WRITE) |
> -		SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_COPY_LINEAR);
> +		SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_WRITE_LINEAR);
>   	ib->ptr[ib->length_dw++] = pe;
>   	ib->ptr[ib->length_dw++] = upper_32_bits(pe);
>   	ib->ptr[ib->length_dw++] = ndw;
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> index 77f1465..9425c69 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> @@ -977,7 +977,7 @@ static void sdma_v3_0_vm_write_pte(struct amdgpu_ib *ib, uint64_t pe,
>   	unsigned ndw = count * 2;
>   
>   	ib->ptr[ib->length_dw++] = SDMA_PKT_HEADER_OP(SDMA_OP_WRITE) |
> -		SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_COPY_LINEAR);
> +		SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_WRITE_LINEAR);
>   	ib->ptr[ib->length_dw++] = lower_32_bits(pe);
>   	ib->ptr[ib->length_dw++] = upper_32_bits(pe);
>   	ib->ptr[ib->length_dw++] = ndw;

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu/sdma: fix typo in packet setup
       [not found]     ` <582A6B03.60306-5C7GfCeVMHo@public.gmane.org>
@ 2016-11-15  8:11       ` Christian König
  0 siblings, 0 replies; 3+ messages in thread
From: Christian König @ 2016-11-15  8:11 UTC (permalink / raw)
  To: zhoucm1, Alex Deucher, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
  Cc: Alex Deucher

Am 15.11.2016 um 02:55 schrieb zhoucm1:
>
>
> On 2016年11月15日 02:13, Alex Deucher wrote:
>> Use the correct define.  No functional change as both
>> defines are equivalent.
>>
>> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Reviewed-by: Chunming Zhou <david1.zhou@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>.

>> ---
>>   drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 2 +-
>>   drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c 
>> b/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c
>> index e81aa46..1b44d5b 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c
>> @@ -775,7 +775,7 @@ static void sdma_v2_4_vm_write_pte(struct 
>> amdgpu_ib *ib, uint64_t pe,
>>       unsigned ndw = count * 2;
>>         ib->ptr[ib->length_dw++] = SDMA_PKT_HEADER_OP(SDMA_OP_WRITE) |
>> -        SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_COPY_LINEAR);
>> +        SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_WRITE_LINEAR);
>>       ib->ptr[ib->length_dw++] = pe;
>>       ib->ptr[ib->length_dw++] = upper_32_bits(pe);
>>       ib->ptr[ib->length_dw++] = ndw;
>> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c 
>> b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
>> index 77f1465..9425c69 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
>> @@ -977,7 +977,7 @@ static void sdma_v3_0_vm_write_pte(struct 
>> amdgpu_ib *ib, uint64_t pe,
>>       unsigned ndw = count * 2;
>>         ib->ptr[ib->length_dw++] = SDMA_PKT_HEADER_OP(SDMA_OP_WRITE) |
>> -        SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_COPY_LINEAR);
>> +        SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_WRITE_LINEAR);
>>       ib->ptr[ib->length_dw++] = lower_32_bits(pe);
>>       ib->ptr[ib->length_dw++] = upper_32_bits(pe);
>>       ib->ptr[ib->length_dw++] = ndw;
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-15  8:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-14 18:13 [PATCH] drm/amdgpu/sdma: fix typo in packet setup Alex Deucher
     [not found] ` <1479147215-2151-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2016-11-15  1:55   ` zhoucm1
     [not found]     ` <582A6B03.60306-5C7GfCeVMHo@public.gmane.org>
2016-11-15  8:11       ` Christian König

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.