All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Robin Murphy <robin.murphy@arm.com>,
	will@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com
Cc: catalin.marinas@arm.com, thierry.reding@gmail.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 5/5] dt-bindings: perf: Add compatible for Arm DSU-110
Date: Tue, 14 Dec 2021 14:42:36 +0000	[thread overview]
Message-ID: <abcc021f-e1f4-f097-e6a1-29240de3cd84@arm.com> (raw)
In-Reply-To: <51a8060493e1220886dcd468fad9a2b603607297.1639490264.git.robin.murphy@arm.com>

On 14/12/2021 14:16, Robin Murphy wrote:
> DSU-110 is the newest and shiniest for Armv9. Its programmer's model is
> largely identical to the previous generation of DSUs, so we can treat it
> as compatible, but it does have a a handful of extra IMP-DEF PMU events
> to call its own. Thanks to the new notion of core complexes, the maximum
> number of supported CPUs goes up as well.
> 
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
> 
> v2: Also make it complete and valid
> 
>   Documentation/devicetree/bindings/perf/arm,dsu-pmu.yaml | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/perf/arm,dsu-pmu.yaml b/Documentation/devicetree/bindings/perf/arm,dsu-pmu.yaml
> index 09ddeb6a3ccc..7f31bcecedb5 100644
> --- a/Documentation/devicetree/bindings/perf/arm,dsu-pmu.yaml
> +++ b/Documentation/devicetree/bindings/perf/arm,dsu-pmu.yaml
> @@ -21,7 +21,11 @@ description:
>   
>   properties:
>     compatible:
> -    const: arm,dsu-pmu
> +    oneOf:
> +      - const: arm,dsu-pmu
> +      - items:
> +          - const: arm,dsu-110-pmu
> +          - const: arm,dsu-pmu

Couldn't this be :

	compatible:
	  oneOf:
	    - const: arm,dsu-110-pmu
	    - const: arm,dsu-pmu

Otherwise, looks good to me.

Suzuki

WARNING: multiple messages have this Message-ID (diff)
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Robin Murphy <robin.murphy@arm.com>,
	will@kernel.org, robh+dt@kernel.org,  mark.rutland@arm.com
Cc: catalin.marinas@arm.com, thierry.reding@gmail.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 5/5] dt-bindings: perf: Add compatible for Arm DSU-110
Date: Tue, 14 Dec 2021 14:42:36 +0000	[thread overview]
Message-ID: <abcc021f-e1f4-f097-e6a1-29240de3cd84@arm.com> (raw)
In-Reply-To: <51a8060493e1220886dcd468fad9a2b603607297.1639490264.git.robin.murphy@arm.com>

On 14/12/2021 14:16, Robin Murphy wrote:
> DSU-110 is the newest and shiniest for Armv9. Its programmer's model is
> largely identical to the previous generation of DSUs, so we can treat it
> as compatible, but it does have a a handful of extra IMP-DEF PMU events
> to call its own. Thanks to the new notion of core complexes, the maximum
> number of supported CPUs goes up as well.
> 
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
> 
> v2: Also make it complete and valid
> 
>   Documentation/devicetree/bindings/perf/arm,dsu-pmu.yaml | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/perf/arm,dsu-pmu.yaml b/Documentation/devicetree/bindings/perf/arm,dsu-pmu.yaml
> index 09ddeb6a3ccc..7f31bcecedb5 100644
> --- a/Documentation/devicetree/bindings/perf/arm,dsu-pmu.yaml
> +++ b/Documentation/devicetree/bindings/perf/arm,dsu-pmu.yaml
> @@ -21,7 +21,11 @@ description:
>   
>   properties:
>     compatible:
> -    const: arm,dsu-pmu
> +    oneOf:
> +      - const: arm,dsu-pmu
> +      - items:
> +          - const: arm,dsu-110-pmu
> +          - const: arm,dsu-pmu

Couldn't this be :

	compatible:
	  oneOf:
	    - const: arm,dsu-110-pmu
	    - const: arm,dsu-pmu

Otherwise, looks good to me.

Suzuki

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-12-14 14:42 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-14 14:16 [PATCH v2 0/5] arm64: PMU updates Robin Murphy
2021-12-14 14:16 ` Robin Murphy
2021-12-14 14:16 ` [PATCH v2 1/5] arm64: perf: Support Denver and Carmel PMUs Robin Murphy
2021-12-14 14:16   ` Robin Murphy
2021-12-14 14:16 ` [PATCH v2 2/5] arm64: perf: Simplify registration boilerplate Robin Murphy
2021-12-14 14:16   ` Robin Murphy
2021-12-14 14:16 ` [PATCH v2 3/5] arm64: perf: Support new DT compatibles Robin Murphy
2021-12-14 14:16   ` Robin Murphy
2021-12-14 14:16 ` [PATCH v2 4/5] dt-bindings: perf: Convert Arm DSU to schema Robin Murphy
2021-12-14 14:16   ` Robin Murphy
2021-12-14 14:36   ` Suzuki K Poulose
2021-12-14 14:36     ` Suzuki K Poulose
2021-12-14 20:38   ` Rob Herring
2021-12-14 20:38     ` Rob Herring
2021-12-14 14:16 ` [PATCH v2 5/5] dt-bindings: perf: Add compatible for Arm DSU-110 Robin Murphy
2021-12-14 14:16   ` Robin Murphy
2021-12-14 14:42   ` Suzuki K Poulose [this message]
2021-12-14 14:42     ` Suzuki K Poulose
2021-12-14 14:59     ` Robin Murphy
2021-12-14 14:59       ` Robin Murphy
2021-12-14 18:54       ` Suzuki K Poulose
2021-12-14 18:54         ` Suzuki K Poulose
2021-12-14 20:41   ` Rob Herring
2021-12-14 20:41     ` Rob Herring
2021-12-14 18:33 ` [PATCH v2 0/5] arm64: PMU updates Will Deacon
2021-12-14 18:33   ` Will Deacon
2021-12-14 19:02   ` Robin Murphy
2021-12-14 19:02     ` Robin Murphy
2021-12-14 19:32     ` Will Deacon
2021-12-14 19:32       ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abcc021f-e1f4-f097-e6a1-29240de3cd84@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=thierry.reding@gmail.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.