[RFC 4/8] clk: qcom: gcc-sm8450: Keep usb30 prim gdsc on during runtime suspend

* [RFC 4/8] clk: qcom: gcc-sm8450: Keep usb30 prim gdsc on during runtime suspend
@ 2023-10-17 13:19 Krishna Kurapati
  2023-10-19  0:58 ` Stephen Boyd
  0 siblings, 1 reply; 4+ messages in thread
From: Krishna Kurapati @ 2023-10-17 13:19 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Michael Turquette,
	Stephen Boyd
  Cc: linux-clk, linux-kernel, linux-arm-msm, quic_ppratap, quic_jackp,
	Krishna Kurapati

When runtime suspend happens in host mode, if cable is removed at this
instant, it triggers a resume where a xhci register access is done when
gdsc is not on leading to a crash. Keep usb30 prim gdsc as on during
runtime suspend to avoid this crash.

Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
---
Note: I am not sure if this is the right way or setting GDSC flags to
PWRSTS_RET_ON is the right approach. So for now made this change to
keep GDSC during host mode runtime suspend.

 drivers/clk/qcom/gcc-sm8450.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/qcom/gcc-sm8450.c b/drivers/clk/qcom/gcc-sm8450.c
index 75635d40a12d..47cde2de93a2 100644
--- a/drivers/clk/qcom/gcc-sm8450.c
+++ b/drivers/clk/qcom/gcc-sm8450.c
@@ -2996,6 +2996,7 @@ static struct gdsc usb30_prim_gdsc = {
 	.gdscr = 0x49004,
 	.pd = {
 		.name = "usb30_prim_gdsc",
+		.flags = GENPD_FLAG_RPM_ALWAYS_ON,
 	},
 	.pwrsts = PWRSTS_OFF_ON,
 };
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread