* [PATCH] fs: GFS2: constify attribute_group structures.
@ 2017-06-30 5:28 ` Arvind Yadav
0 siblings, 0 replies; 4+ messages in thread
From: Arvind Yadav @ 2017-06-30 5:28 UTC (permalink / raw)
To: swhiteho, rpeterso, torvalds; +Cc: cluster-devel, linux-kernel
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
5259 1344 8 6611 19d3 fs/gfs2/sys.o
File size After adding 'const':
text data bss dec hex filename
5371 1216 8 6595 19c3 fs/gfs2/sys.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
fs/gfs2/sys.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c
index 7a51534..01dc027 100644
--- a/fs/gfs2/sys.c
+++ b/fs/gfs2/sys.c
@@ -637,12 +637,12 @@ static ssize_t tune_set(struct gfs2_sbd *sdp, unsigned int *field,
NULL,
};
-static struct attribute_group tune_group = {
+static const struct attribute_group tune_group = {
.name = "tune",
.attrs = tune_attrs,
};
-static struct attribute_group lock_module_group = {
+static const struct attribute_group lock_module_group = {
.name = "lock_module",
.attrs = lock_module_attrs,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Cluster-devel] [PATCH] fs: GFS2: constify attribute_group structures.
@ 2017-06-30 5:28 ` Arvind Yadav
0 siblings, 0 replies; 4+ messages in thread
From: Arvind Yadav @ 2017-06-30 5:28 UTC (permalink / raw)
To: cluster-devel.redhat.com
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
5259 1344 8 6611 19d3 fs/gfs2/sys.o
File size After adding 'const':
text data bss dec hex filename
5371 1216 8 6595 19c3 fs/gfs2/sys.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
fs/gfs2/sys.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c
index 7a51534..01dc027 100644
--- a/fs/gfs2/sys.c
+++ b/fs/gfs2/sys.c
@@ -637,12 +637,12 @@ static ssize_t tune_set(struct gfs2_sbd *sdp, unsigned int *field,
NULL,
};
-static struct attribute_group tune_group = {
+static const struct attribute_group tune_group = {
.name = "tune",
.attrs = tune_attrs,
};
-static struct attribute_group lock_module_group = {
+static const struct attribute_group lock_module_group = {
.name = "lock_module",
.attrs = lock_module_attrs,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fs: GFS2: constify attribute_group structures.
2017-06-30 5:28 ` [Cluster-devel] " Arvind Yadav
@ 2017-06-30 13:42 ` Bob Peterson
-1 siblings, 0 replies; 4+ messages in thread
From: Bob Peterson @ 2017-06-30 13:42 UTC (permalink / raw)
To: Arvind Yadav; +Cc: swhiteho, torvalds, cluster-devel, linux-kernel
----- Original Message -----
| attribute_groups are not supposed to change at runtime. All functions
| working with attribute_groups provided by <linux/sysfs.h> work with const
| attribute_group. So mark the non-const structs as const.
|
| File size before:
| text data bss dec hex filename
| 5259 1344 8 6611 19d3 fs/gfs2/sys.o
|
| File size After adding 'const':
| text data bss dec hex filename
| 5371 1216 8 6595 19c3 fs/gfs2/sys.o
|
| Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Hi,
Thanks. This is now applied to the for-next branch of the linux-gfs2 tree:
1fc2e87 GFS2: constify attribute_group structures.
Regards,
Bob Peterson
Red Hat File Systems
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Cluster-devel] [PATCH] fs: GFS2: constify attribute_group structures.
@ 2017-06-30 13:42 ` Bob Peterson
0 siblings, 0 replies; 4+ messages in thread
From: Bob Peterson @ 2017-06-30 13:42 UTC (permalink / raw)
To: cluster-devel.redhat.com
----- Original Message -----
| attribute_groups are not supposed to change at runtime. All functions
| working with attribute_groups provided by <linux/sysfs.h> work with const
| attribute_group. So mark the non-const structs as const.
|
| File size before:
| text data bss dec hex filename
| 5259 1344 8 6611 19d3 fs/gfs2/sys.o
|
| File size After adding 'const':
| text data bss dec hex filename
| 5371 1216 8 6595 19c3 fs/gfs2/sys.o
|
| Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Hi,
Thanks. This is now applied to the for-next branch of the linux-gfs2 tree:
1fc2e87 GFS2: constify attribute_group structures.
Regards,
Bob Peterson
Red Hat File Systems
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-30 13:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-30 5:28 [PATCH] fs: GFS2: constify attribute_group structures Arvind Yadav
2017-06-30 5:28 ` [Cluster-devel] " Arvind Yadav
2017-06-30 13:42 ` Bob Peterson
2017-06-30 13:42 ` [Cluster-devel] " Bob Peterson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.