All of lore.kernel.org
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-scsi@vger.kernel.org,
	"James E. J. Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Vinayak Holikatti <vinholikatti@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 1/3] scsi: ufs: Use devm_kcalloc() in ufshcd_memory_alloc()
Date: Tue, 25 Apr 2017 22:26:05 +0200	[thread overview]
Message-ID: <ac344c69-44ef-07e3-a039-ad4e9a99b1d6@users.sourceforge.net> (raw)
In-Reply-To: <75622f45-f46c-e52f-2b9e-6ff5ce32184a@users.sourceforge.net>

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 25 Apr 2017 21:45:25 +0200

* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "devm_kcalloc".

* Replace the specification of a data structure by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/scsi/ufs/ufshcd.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 9ef8ce7f01a2..ce385911a20e 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -3270,8 +3270,7 @@ static int ufshcd_memory_alloc(struct ufs_hba *hba)
 	}
 
 	/* Allocate memory for local reference block */
-	hba->lrb = devm_kzalloc(hba->dev,
-				hba->nutrs * sizeof(struct ufshcd_lrb),
+	hba->lrb = devm_kcalloc(hba->dev, hba->nutrs, sizeof(*hba->lrb),
 				GFP_KERNEL);
 	if (!hba->lrb) {
 		dev_err(hba->dev, "LRB Memory allocation failed\n");
-- 
2.12.2

WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-scsi@vger.kernel.org,
	"James E. J. Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Vinayak Holikatti <vinholikatti@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 1/3] scsi: ufs: Use devm_kcalloc() in ufshcd_memory_alloc()
Date: Tue, 25 Apr 2017 20:26:05 +0000	[thread overview]
Message-ID: <ac344c69-44ef-07e3-a039-ad4e9a99b1d6@users.sourceforge.net> (raw)
In-Reply-To: <75622f45-f46c-e52f-2b9e-6ff5ce32184a@users.sourceforge.net>

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 25 Apr 2017 21:45:25 +0200

* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "devm_kcalloc".

* Replace the specification of a data structure by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/scsi/ufs/ufshcd.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 9ef8ce7f01a2..ce385911a20e 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -3270,8 +3270,7 @@ static int ufshcd_memory_alloc(struct ufs_hba *hba)
 	}
 
 	/* Allocate memory for local reference block */
-	hba->lrb = devm_kzalloc(hba->dev,
-				hba->nutrs * sizeof(struct ufshcd_lrb),
+	hba->lrb = devm_kcalloc(hba->dev, hba->nutrs, sizeof(*hba->lrb),
 				GFP_KERNEL);
 	if (!hba->lrb) {
 		dev_err(hba->dev, "LRB Memory allocation failed\n");
-- 
2.12.2


  reply	other threads:[~2017-04-25 20:26 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25 20:24 [PATCH 0/3] SCSI-UFSHCD: Fine-tuning for two function implementations SF Markus Elfring
2017-04-25 20:24 ` SF Markus Elfring
2017-04-25 20:26 ` SF Markus Elfring [this message]
2017-04-25 20:26   ` [PATCH 1/3] scsi: ufs: Use devm_kcalloc() in ufshcd_memory_alloc() SF Markus Elfring
2017-04-26 17:52   ` Subhash Jadavani
2017-04-26 17:52     ` Subhash Jadavani
2017-04-25 20:28 ` [PATCH 2/3] scsi: ufs: Delete an error message for a failed memory allocation " SF Markus Elfring
2017-04-25 20:28   ` [PATCH 2/3] scsi: ufs: Delete an error message for a failed memory allocation in ufshcd_memory_alloc SF Markus Elfring
2017-04-26 17:57   ` [PATCH 2/3] scsi: ufs: Delete an error message for a failed memory allocation in ufshcd_memory_alloc() Subhash Jadavani
2017-04-26 17:57     ` [PATCH 2/3] scsi: ufs: Delete an error message for a failed memory allocation in ufshcd_memory_a Subhash Jadavani
2017-04-26 18:11     ` scsi: ufs: Delete an error message for a failed memory allocation in ufshcd_memory_alloc() SF Markus Elfring
2017-04-26 18:11       ` SF Markus Elfring
2017-04-26 18:27     ` [PATCH 2/3] " Joe Perches
2017-04-26 18:27       ` [PATCH 2/3] scsi: ufs: Delete an error message for a failed memory allocation in ufshcd_memory_a Joe Perches
2017-04-26 18:50       ` Checking error messages for failed memory allocations SF Markus Elfring
2017-04-26 18:50         ` SF Markus Elfring
2017-04-26 19:05         ` Joe Perches
2017-04-26 19:05           ` Joe Perches
2017-04-26 19:14           ` SF Markus Elfring
2017-04-26 19:14             ` SF Markus Elfring
2017-08-26 11:17       ` scsi: ufs: Delete an error message for a failed memory allocation in ufshcd_memory_alloc() SF Markus Elfring
2017-08-26 11:17         ` SF Markus Elfring
2017-04-25 20:30 ` [PATCH 3/3] scsi: ufs: Delete an unnecessary return statement in ufshcd_exception_event_handler() SF Markus Elfring
2017-04-25 20:30   ` SF Markus Elfring
2017-04-26 17:59   ` Subhash Jadavani
2017-04-26 17:59     ` [PATCH 3/3] scsi: ufs: Delete an unnecessary return statement in ufshcd_exception_event_handler( Subhash Jadavani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac344c69-44ef-07e3-a039-ad4e9a99b1d6@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=vinholikatti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.