* [PATCH] kernel: cobalt: replace access_ok with corresponding wrappers
@ 2019-03-11 14:37 roman.stratiienko
2019-03-11 14:37 ` [PATCH v3] travis: add basic CI support roman.stratiienko
2019-03-19 20:03 ` [PATCH] kernel: cobalt: replace access_ok with corresponding wrappers Jan Kiszka
0 siblings, 2 replies; 12+ messages in thread
From: roman.stratiienko @ 2019-03-11 14:37 UTC (permalink / raw)
To: xenomai; +Cc: Roman Stratiienko
From: Roman Stratiienko <roman.stratiienko@globallogic.com>
Use access_wok / access_rok wrappers to enable support for kernel v5.0
Signed-off-by: Roman Stratiienko <roman.stratiienko@globallogic.com>
---
This patch is also required to support v5.0
kernel/cobalt/pipe.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/kernel/cobalt/pipe.c b/kernel/cobalt/pipe.c
index 0b8f8cbf8..16e85125c 100644
--- a/kernel/cobalt/pipe.c
+++ b/kernel/cobalt/pipe.c
@@ -28,6 +28,7 @@
#include <linux/device.h>
#include <linux/uaccess.h>
#include <asm/io.h>
+#include <asm/xenomai/syscall.h>
#include <cobalt/kernel/sched.h>
#include <cobalt/kernel/heap.h>
#include <cobalt/kernel/pipe.h>
@@ -795,7 +796,7 @@ static ssize_t xnpipe_read(struct file *file,
ssize_t ret;
spl_t s;
- if (!access_ok(VERIFY_WRITE, buf, count))
+ if (!access_wok(buf, count))
return -EFAULT;
xnlock_get_irqsave(&nklock, s);
@@ -903,7 +904,7 @@ static ssize_t xnpipe_write(struct file *file,
if (count == 0)
return 0;
- if (!access_ok(VERIFY_READ, buf, count))
+ if (!access_rok(buf, count))
return -EFAULT;
xnlock_get_irqsave(&nklock, s);
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3] travis: add basic CI support
2019-03-11 14:37 [PATCH] kernel: cobalt: replace access_ok with corresponding wrappers roman.stratiienko
@ 2019-03-11 14:37 ` roman.stratiienko
2019-03-18 12:59 ` Jan Kiszka
2019-03-19 20:03 ` [PATCH] kernel: cobalt: replace access_ok with corresponding wrappers Jan Kiszka
1 sibling, 1 reply; 12+ messages in thread
From: roman.stratiienko @ 2019-03-11 14:37 UTC (permalink / raw)
To: xenomai; +Cc: Roman Stratiienko
From: Roman Stratiienko <roman.stratiienko@globallogic.com>
Signed-off-by: Roman Stratiienko <roman.stratiienko@globallogic.com>
---
Changes since v2
Removed redundand "CONFIG_" prefix
Added building of the drivers
Currently CAN bus driver build fails on v4.20 and v5.0,
(https://travis-ci.org/devel-opi/xenomai-fork/builds/504429157)
Please suggest which configs should be also enabled in
CI to cover as much as possible code lines
.travis.yml | 99 +++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 99 insertions(+)
create mode 100644 .travis.yml
diff --git a/.travis.yml b/.travis.yml
new file mode 100644
index 000000000..8d3eba2c3
--- /dev/null
+++ b/.travis.yml
@@ -0,0 +1,99 @@
+language: c
+dist: xenial
+
+addons:
+ apt:
+ packages:
+ - gcc-aarch64-linux-gnu
+ - gcc-arm-linux-gnueabihf
+ - patch
+ - quilt
+ - wget
+
+env:
+ global:
+ - KDIR=/tmp/kernel
+
+install:
+ - if [[ "${KERNEL_VERSION}" == *-rc* ]]; then
+ KERNEL_URL=https://git.kernel.org/torvalds/t/linux-${KERNEL_VERSION}.tar.gz;
+ else
+ KERNEL_URL=https://www.kernel.org/pub/linux/kernel/v${KERNEL_VERSION::1}.x/linux-${KERNEL_VERSION}.tar.xz;
+ fi
+ - wget -O kernel.tar.xz ${KERNEL_URL} && mkdir ${KDIR} && tar -C ${KDIR} --strip=1 -xf kernel.tar.xz
+ - wget -O /tmp/ipipe.patch ${IPIPE_URL}
+
+before_script:
+ - case "${ARCH}" in
+ "arm64") export CROSS_COMPILE=aarch64-linux-gnu-
+ ;;
+ "arm" ) export CROSS_COMPILE=arm-linux-gnueabihf-
+ ;;
+ "x86" ) export CROSS_COMPILE=
+ ;;
+ esac
+ - pushd ${KDIR}
+ - make -j $(nproc) ${KERNEL_DEFCONFIG}
+ - ./scripts/config -e IPIPE
+ - ./scripts/config -e XENOMAI
+ - ./scripts/config -e XENO_DRIVERS_ANALOGY
+ - ./scripts/config -e XENO_DRIVERS_ANALOGY_DEBUG
+ - ./scripts/config -e XENO_DRIVERS_ANALOGY_DEBUG_FTRACE
+ - ./scripts/config -e XENO_DRIVERS_ANALOGY_8255
+ - ./scripts/config -e XENO_DRIVERS_ANALOGY_PARPORT
+ - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_MITE
+ - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_TIO
+ - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_MIO
+ - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_PCIMIO
+ - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_670x
+ - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_660x
+ - ./scripts/config -e XENO_DRIVERS_ANALOGY_S526
+ - ./scripts/config -e XENO_DRIVERS_ANALOGY_FAKE
+ - ./scripts/config -e XENO_DRIVERS_AUTOTUNE
+ - ./scripts/config -e XENO_DRIVERS_CAN
+ - ./scripts/config -e XENO_DRIVERS_CAN_DEBUG
+ - ./scripts/config -e XENO_DRIVERS_CAN_LOOPBACK
+ - ./scripts/config -e XENO_DRIVERS_CAN_BUS_ERR
+ - ./scripts/config -e XENO_DRIVERS_CAN_VIRT
+ - ./scripts/config -e XENO_DRIVERS_CAN_FLEXCAN
+ - ./scripts/config -e XENO_DRIVERS_GPIO
+ - ./scripts/config -e XENO_DRIVERS_GPIO_SUN8I_H3
+ - ./scripts/config -e XENO_DRIVERS_GPIO_DEBUG
+ - ./scripts/config -e XENO_DRIVERS_GPIOPWM
+ - ./scripts/config -e XENO_DRIVERS_RTIPC
+ - ./scripts/config -e XENO_DRIVERS_NET
+ - ./scripts/config -e XENO_DRIVERS_16550A
+ - ./scripts/config -e XENO_DRIVERS_SPI
+ - ./scripts/config -e XENO_DRIVERS_TIMERBENCH
+ - ./scripts/config -e XENO_DRIVERS_UDD
+
+ - popd
+
+script:
+ - ./scripts/prepare-kernel.sh --ipipe=/tmp/ipipe.patch --arch=${ARCH} --linux=${KDIR}
+ - cd ${KDIR}
+ - make -j $(nproc) olddefconfig
+ - make -j $(nproc) all
+
+matrix:
+ include:
+ - env:
+ - ARCH: arm
+ KERNEL_VERSION: 4.14.85
+ KERNEL_DEFCONFIG: multi_v7_defconfig
+ IPIPE_URL: https://xenomai.org/downloads/ipipe/v4.x/arm/ipipe-core-4.14.85-arm-6.patch
+ - env:
+ - ARCH: arm
+ KERNEL_VERSION: 4.1.18
+ KERNEL_DEFCONFIG: multi_v7_defconfig
+ IPIPE_URL: https://xenomai.org/downloads/ipipe/v4.x/arm/older/ipipe-core-4.1.18-arm-9.patch
+ - env:
+ - ARCH: x86
+ KERNEL_VERSION: 4.14.89
+ KERNEL_DEFCONFIG: x86_64_defconfig
+ IPIPE_URL: https://xenomai.org/downloads/ipipe/v4.x/x86/ipipe-core-4.14.89-x86-2.patch
+ - env:
+ - ARCH: x86
+ KERNEL_VERSION: 4.4.166
+ KERNEL_DEFCONFIG: i386_defconfig
+ IPIPE_URL: https://xenomai.org/downloads/ipipe/v4.x/x86/ipipe-core-4.4.166-x86-12.patch
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v3] travis: add basic CI support
2019-03-11 14:37 ` [PATCH v3] travis: add basic CI support roman.stratiienko
@ 2019-03-18 12:59 ` Jan Kiszka
2019-03-18 13:25 ` Jan Kiszka
0 siblings, 1 reply; 12+ messages in thread
From: Jan Kiszka @ 2019-03-18 12:59 UTC (permalink / raw)
To: roman.stratiienko, xenomai
On 11.03.19 15:37, roman.stratiienko--- via Xenomai wrote:
> From: Roman Stratiienko <roman.stratiienko@globallogic.com>
>
> Signed-off-by: Roman Stratiienko <roman.stratiienko@globallogic.com>
> ---
>
> Changes since v2
>
> Removed redundand "CONFIG_" prefix
> Added building of the drivers
>
> Currently CAN bus driver build fails on v4.20 and v5.0,
> (https://travis-ci.org/devel-opi/xenomai-fork/builds/504429157)
>
> Please suggest which configs should be also enabled in
> CI to cover as much as possible code lines
>
> .travis.yml | 99 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 99 insertions(+)
> create mode 100644 .travis.yml
>
> diff --git a/.travis.yml b/.travis.yml
> new file mode 100644
> index 000000000..8d3eba2c3
> --- /dev/null
> +++ b/.travis.yml
> @@ -0,0 +1,99 @@
> +language: c
> +dist: xenial
> +
> +addons:
> + apt:
> + packages:
> + - gcc-aarch64-linux-gnu
> + - gcc-arm-linux-gnueabihf
> + - patch
> + - quilt
> + - wget
> +
> +env:
> + global:
> + - KDIR=/tmp/kernel
> +
> +install:
> + - if [[ "${KERNEL_VERSION}" == *-rc* ]]; then
> + KERNEL_URL=https://git.kernel.org/torvalds/t/linux-${KERNEL_VERSION}.tar.gz;
> + else
> + KERNEL_URL=https://www.kernel.org/pub/linux/kernel/v${KERNEL_VERSION::1}.x/linux-${KERNEL_VERSION}.tar.xz;
> + fi
> + - wget -O kernel.tar.xz ${KERNEL_URL} && mkdir ${KDIR} && tar -C ${KDIR} --strip=1 -xf kernel.tar.xz
> + - wget -O /tmp/ipipe.patch ${IPIPE_URL}
> +
> +before_script:
> + - case "${ARCH}" in
> + "arm64") export CROSS_COMPILE=aarch64-linux-gnu-
> + ;;
> + "arm" ) export CROSS_COMPILE=arm-linux-gnueabihf-
> + ;;
> + "x86" ) export CROSS_COMPILE=
> + ;;
> + esac
> + - pushd ${KDIR}
> + - make -j $(nproc) ${KERNEL_DEFCONFIG}
> + - ./scripts/config -e IPIPE
> + - ./scripts/config -e XENOMAI
> + - ./scripts/config -e XENO_DRIVERS_ANALOGY
> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_DEBUG
> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_DEBUG_FTRACE
> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_8255
> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_PARPORT
> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_MITE
> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_TIO
> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_MIO
> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_PCIMIO
> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_670x
> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_660x
> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_S526
> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_FAKE
> + - ./scripts/config -e XENO_DRIVERS_AUTOTUNE
> + - ./scripts/config -e XENO_DRIVERS_CAN
> + - ./scripts/config -e XENO_DRIVERS_CAN_DEBUG
> + - ./scripts/config -e XENO_DRIVERS_CAN_LOOPBACK
> + - ./scripts/config -e XENO_DRIVERS_CAN_BUS_ERR
> + - ./scripts/config -e XENO_DRIVERS_CAN_VIRT
> + - ./scripts/config -e XENO_DRIVERS_CAN_FLEXCAN
> + - ./scripts/config -e XENO_DRIVERS_GPIO
> + - ./scripts/config -e XENO_DRIVERS_GPIO_SUN8I_H3
> + - ./scripts/config -e XENO_DRIVERS_GPIO_DEBUG
> + - ./scripts/config -e XENO_DRIVERS_GPIOPWM
> + - ./scripts/config -e XENO_DRIVERS_RTIPC
> + - ./scripts/config -e XENO_DRIVERS_NET
> + - ./scripts/config -e XENO_DRIVERS_16550A
> + - ./scripts/config -e XENO_DRIVERS_SPI
> + - ./scripts/config -e XENO_DRIVERS_TIMERBENCH
> + - ./scripts/config -e XENO_DRIVERS_UDD
> +
> + - popd
> +
> +script:
> + - ./scripts/prepare-kernel.sh --ipipe=/tmp/ipipe.patch --arch=${ARCH} --linux=${KDIR}
> + - cd ${KDIR}
> + - make -j $(nproc) olddefconfig
> + - make -j $(nproc) all
> +
> +matrix:
> + include:
> + - env:
> + - ARCH: arm
> + KERNEL_VERSION: 4.14.85
> + KERNEL_DEFCONFIG: multi_v7_defconfig
> + IPIPE_URL: https://xenomai.org/downloads/ipipe/v4.x/arm/ipipe-core-4.14.85-arm-6.patch
> + - env:
> + - ARCH: arm
> + KERNEL_VERSION: 4.1.18
> + KERNEL_DEFCONFIG: multi_v7_defconfig
> + IPIPE_URL: https://xenomai.org/downloads/ipipe/v4.x/arm/older/ipipe-core-4.1.18-arm-9.patch
> + - env:
> + - ARCH: x86
> + KERNEL_VERSION: 4.14.89
> + KERNEL_DEFCONFIG: x86_64_defconfig
> + IPIPE_URL: https://xenomai.org/downloads/ipipe/v4.x/x86/ipipe-core-4.14.89-x86-2.patch
> + - env:
> + - ARCH: x86
> + KERNEL_VERSION: 4.4.166
> + KERNEL_DEFCONFIG: i386_defconfig
> + IPIPE_URL: https://xenomai.org/downloads/ipipe/v4.x/x86/ipipe-core-4.4.166-x86-12.patch
>
Starting to process my backlog with adding this commit to next. I had to create
a mirror in github for that, but now we have
https://travis-ci.com/xenomai-ci/xenomai
fed by
https://github.com/xenomai-ci/xenomai
which is automatically updated when I push to the official repo. When everything
runs smoothly, we likely want to set some links, maybe including a build badge,
in our docs.
Thanks for starting this!
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3] travis: add basic CI support
2019-03-18 12:59 ` Jan Kiszka
@ 2019-03-18 13:25 ` Jan Kiszka
2019-03-18 14:21 ` Roman Stratiienko
0 siblings, 1 reply; 12+ messages in thread
From: Jan Kiszka @ 2019-03-18 13:25 UTC (permalink / raw)
To: roman.stratiienko, xenomai
On 18.03.19 13:59, Jan Kiszka wrote:
> On 11.03.19 15:37, roman.stratiienko--- via Xenomai wrote:
>> From: Roman Stratiienko <roman.stratiienko@globallogic.com>
>>
>> Signed-off-by: Roman Stratiienko <roman.stratiienko@globallogic.com>
>> ---
>>
>> Changes since v2
>>
>> Removed redundand "CONFIG_" prefix
>> Added building of the drivers
>>
>> Currently CAN bus driver build fails on v4.20 and v5.0,
>> (https://travis-ci.org/devel-opi/xenomai-fork/builds/504429157)
>>
>> Please suggest which configs should be also enabled in
>> CI to cover as much as possible code lines
>>
>> .travis.yml | 99 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 99 insertions(+)
>> create mode 100644 .travis.yml
>>
>> diff --git a/.travis.yml b/.travis.yml
>> new file mode 100644
>> index 000000000..8d3eba2c3
>> --- /dev/null
>> +++ b/.travis.yml
>> @@ -0,0 +1,99 @@
>> +language: c
>> +dist: xenial
>> +
>> +addons:
>> + apt:
>> + packages:
>> + - gcc-aarch64-linux-gnu
>> + - gcc-arm-linux-gnueabihf
>> + - patch
>> + - quilt
>> + - wget
>> +
>> +env:
>> + global:
>> + - KDIR=/tmp/kernel
>> +
>> +install:
>> + - if [[ "${KERNEL_VERSION}" == *-rc* ]]; then
>> +
>> KERNEL_URL=https://git.kernel.org/torvalds/t/linux-${KERNEL_VERSION}.tar.gz;
>> + else
>> +
>> KERNEL_URL=https://www.kernel.org/pub/linux/kernel/v${KERNEL_VERSION::1}.x/linux-${KERNEL_VERSION}.tar.xz;
>>
>> + fi
>> + - wget -O kernel.tar.xz ${KERNEL_URL} && mkdir ${KDIR} && tar -C ${KDIR}
>> --strip=1 -xf kernel.tar.xz
>> + - wget -O /tmp/ipipe.patch ${IPIPE_URL}
>> +
>> +before_script:
>> + - case "${ARCH}" in
>> + "arm64") export CROSS_COMPILE=aarch64-linux-gnu-
>> + ;;
>> + "arm" ) export CROSS_COMPILE=arm-linux-gnueabihf-
>> + ;;
>> + "x86" ) export CROSS_COMPILE=
>> + ;;
>> + esac
>> + - pushd ${KDIR}
>> + - make -j $(nproc) ${KERNEL_DEFCONFIG}
>> + - ./scripts/config -e IPIPE
>> + - ./scripts/config -e XENOMAI
>> + - ./scripts/config -e XENO_DRIVERS_ANALOGY
>> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_DEBUG
>> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_DEBUG_FTRACE
>> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_8255
>> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_PARPORT
>> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_MITE
>> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_TIO
>> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_MIO
>> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_PCIMIO
>> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_670x
>> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_660x
>> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_S526
>> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_FAKE
>> + - ./scripts/config -e XENO_DRIVERS_AUTOTUNE
>> + - ./scripts/config -e XENO_DRIVERS_CAN
>> + - ./scripts/config -e XENO_DRIVERS_CAN_DEBUG
>> + - ./scripts/config -e XENO_DRIVERS_CAN_LOOPBACK
>> + - ./scripts/config -e XENO_DRIVERS_CAN_BUS_ERR
>> + - ./scripts/config -e XENO_DRIVERS_CAN_VIRT
>> + - ./scripts/config -e XENO_DRIVERS_CAN_FLEXCAN
>> + - ./scripts/config -e XENO_DRIVERS_GPIO
>> + - ./scripts/config -e XENO_DRIVERS_GPIO_SUN8I_H3
>> + - ./scripts/config -e XENO_DRIVERS_GPIO_DEBUG
>> + - ./scripts/config -e XENO_DRIVERS_GPIOPWM
>> + - ./scripts/config -e XENO_DRIVERS_RTIPC
>> + - ./scripts/config -e XENO_DRIVERS_NET
>> + - ./scripts/config -e XENO_DRIVERS_16550A
>> + - ./scripts/config -e XENO_DRIVERS_SPI
>> + - ./scripts/config -e XENO_DRIVERS_TIMERBENCH
>> + - ./scripts/config -e XENO_DRIVERS_UDD
>> +
>> + - popd
>> +
>> +script:
>> + - ./scripts/prepare-kernel.sh --ipipe=/tmp/ipipe.patch --arch=${ARCH}
>> --linux=${KDIR}
>> + - cd ${KDIR}
>> + - make -j $(nproc) olddefconfig
>> + - make -j $(nproc) all
>> +
>> +matrix:
>> + include:
>> + - env:
>> + - ARCH: arm
>> + KERNEL_VERSION: 4.14.85
>> + KERNEL_DEFCONFIG: multi_v7_defconfig
>> + IPIPE_URL:
>> https://xenomai.org/downloads/ipipe/v4.x/arm/ipipe-core-4.14.85-arm-6.patch
>> + - env:
>> + - ARCH: arm
>> + KERNEL_VERSION: 4.1.18
>> + KERNEL_DEFCONFIG: multi_v7_defconfig
>> + IPIPE_URL:
>> https://xenomai.org/downloads/ipipe/v4.x/arm/older/ipipe-core-4.1.18-arm-9.patch
>> + - env:
>> + - ARCH: x86
>> + KERNEL_VERSION: 4.14.89
>> + KERNEL_DEFCONFIG: x86_64_defconfig
>> + IPIPE_URL:
>> https://xenomai.org/downloads/ipipe/v4.x/x86/ipipe-core-4.14.89-x86-2.patch
>> + - env:
>> + - ARCH: x86
>> + KERNEL_VERSION: 4.4.166
>> + KERNEL_DEFCONFIG: i386_defconfig
>> + IPIPE_URL:
>> https://xenomai.org/downloads/ipipe/v4.x/x86/ipipe-core-4.4.166-x86-12.patch
>>
>
> Starting to process my backlog with adding this commit to next. I had to create
> a mirror in github for that, but now we have
>
> https://travis-ci.com/xenomai-ci/xenomai
Seems we have some tracing-related build issues. I suppose the default configs
are without tracing on, and that may trigger some issues.
Did you test your commit separately as well?
Regarding the other patches from your queue: Are there any updates pending?
Jan
>
> fed by
>
> https://github.com/xenomai-ci/xenomai
>
> which is automatically updated when I push to the official repo. When everything
> runs smoothly, we likely want to set some links, maybe including a build badge,
> in our docs.
>
> Thanks for starting this!
> Jan
>
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3] travis: add basic CI support
2019-03-18 13:25 ` Jan Kiszka
@ 2019-03-18 14:21 ` Roman Stratiienko
2019-03-18 14:24 ` Jan Kiszka
0 siblings, 1 reply; 12+ messages in thread
From: Roman Stratiienko @ 2019-03-18 14:21 UTC (permalink / raw)
To: Jan Kiszka; +Cc: xenomai
Hello Jan,
Build failure is caused by "cobalt: Add sched-quota tracepoints".
I had to revert it to continue with testing
You can check my fork:
https://travis-ci.org/devel-opi/xenomai-fork
https://github.com/devel-opi/xenomai-fork/commits/v4.20-fixes
I didn't test the commits separately, but they should not cause build fails
when applied one-by-one
If no more comments from your side, then other patches are final
Regards,
Roman
On Mon, Mar 18, 2019 at 3:25 PM Jan Kiszka <jan.kiszka@siemens.com> wrote:
> On 18.03.19 13:59, Jan Kiszka wrote:
> > On 11.03.19 15:37, roman.stratiienko--- via Xenomai wrote:
> >> From: Roman Stratiienko <roman.stratiienko@globallogic.com>
> >>
> >> Signed-off-by: Roman Stratiienko <roman.stratiienko@globallogic.com>
> >> ---
> >>
> >> Changes since v2
> >>
> >> Removed redundand "CONFIG_" prefix
> >> Added building of the drivers
> >>
> >> Currently CAN bus driver build fails on v4.20 and v5.0,
> >> (https://travis-ci.org/devel-opi/xenomai-fork/builds/504429157)
> >>
> >> Please suggest which configs should be also enabled in
> >> CI to cover as much as possible code lines
> >>
> >> .travis.yml | 99 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> >> 1 file changed, 99 insertions(+)
> >> create mode 100644 .travis.yml
> >>
> >> diff --git a/.travis.yml b/.travis.yml
> >> new file mode 100644
> >> index 000000000..8d3eba2c3
> >> --- /dev/null
> >> +++ b/.travis.yml
> >> @@ -0,0 +1,99 @@
> >> +language: c
> >> +dist: xenial
> >> +
> >> +addons:
> >> + apt:
> >> + packages:
> >> + - gcc-aarch64-linux-gnu
> >> + - gcc-arm-linux-gnueabihf
> >> + - patch
> >> + - quilt
> >> + - wget
> >> +
> >> +env:
> >> + global:
> >> + - KDIR=/tmp/kernel
> >> +
> >> +install:
> >> + - if [[ "${KERNEL_VERSION}" == *-rc* ]]; then
> >> +
> >> KERNEL_URL=
> https://git.kernel.org/torvalds/t/linux-${KERNEL_VERSION}.tar.gz;
> >> + else
> >> +
> >> KERNEL_URL=
> https://www.kernel.org/pub/linux/kernel/v${KERNEL_VERSION::1}.x/linux-${KERNEL_VERSION}.tar.xz;
>
> >>
> >> + fi
> >> + - wget -O kernel.tar.xz ${KERNEL_URL} && mkdir ${KDIR} && tar -C
> ${KDIR}
> >> --strip=1 -xf kernel.tar.xz
> >> + - wget -O /tmp/ipipe.patch ${IPIPE_URL}
> >> +
> >> +before_script:
> >> + - case "${ARCH}" in
> >> + "arm64") export CROSS_COMPILE=aarch64-linux-gnu-
> >> + ;;
> >> + "arm" ) export CROSS_COMPILE=arm-linux-gnueabihf-
> >> + ;;
> >> + "x86" ) export CROSS_COMPILE=
> >> + ;;
> >> + esac
> >> + - pushd ${KDIR}
> >> + - make -j $(nproc) ${KERNEL_DEFCONFIG}
> >> + - ./scripts/config -e IPIPE
> >> + - ./scripts/config -e XENOMAI
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_DEBUG
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_DEBUG_FTRACE
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_8255
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_PARPORT
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_MITE
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_TIO
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_MIO
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_PCIMIO
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_670x
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_660x
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_S526
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_FAKE
> >> + - ./scripts/config -e XENO_DRIVERS_AUTOTUNE
> >> + - ./scripts/config -e XENO_DRIVERS_CAN
> >> + - ./scripts/config -e XENO_DRIVERS_CAN_DEBUG
> >> + - ./scripts/config -e XENO_DRIVERS_CAN_LOOPBACK
> >> + - ./scripts/config -e XENO_DRIVERS_CAN_BUS_ERR
> >> + - ./scripts/config -e XENO_DRIVERS_CAN_VIRT
> >> + - ./scripts/config -e XENO_DRIVERS_CAN_FLEXCAN
> >> + - ./scripts/config -e XENO_DRIVERS_GPIO
> >> + - ./scripts/config -e XENO_DRIVERS_GPIO_SUN8I_H3
> >> + - ./scripts/config -e XENO_DRIVERS_GPIO_DEBUG
> >> + - ./scripts/config -e XENO_DRIVERS_GPIOPWM
> >> + - ./scripts/config -e XENO_DRIVERS_RTIPC
> >> + - ./scripts/config -e XENO_DRIVERS_NET
> >> + - ./scripts/config -e XENO_DRIVERS_16550A
> >> + - ./scripts/config -e XENO_DRIVERS_SPI
> >> + - ./scripts/config -e XENO_DRIVERS_TIMERBENCH
> >> + - ./scripts/config -e XENO_DRIVERS_UDD
> >> +
> >> + - popd
> >> +
> >> +script:
> >> + - ./scripts/prepare-kernel.sh --ipipe=/tmp/ipipe.patch
> --arch=${ARCH}
> >> --linux=${KDIR}
> >> + - cd ${KDIR}
> >> + - make -j $(nproc) olddefconfig
> >> + - make -j $(nproc) all
> >> +
> >> +matrix:
> >> + include:
> >> + - env:
> >> + - ARCH: arm
> >> + KERNEL_VERSION: 4.14.85
> >> + KERNEL_DEFCONFIG: multi_v7_defconfig
> >> + IPIPE_URL:
> >>
> https://xenomai.org/downloads/ipipe/v4.x/arm/ipipe-core-4.14.85-arm-6.patch
> >> + - env:
> >> + - ARCH: arm
> >> + KERNEL_VERSION: 4.1.18
> >> + KERNEL_DEFCONFIG: multi_v7_defconfig
> >> + IPIPE_URL:
> >>
> https://xenomai.org/downloads/ipipe/v4.x/arm/older/ipipe-core-4.1.18-arm-9.patch
> >> + - env:
> >> + - ARCH: x86
> >> + KERNEL_VERSION: 4.14.89
> >> + KERNEL_DEFCONFIG: x86_64_defconfig
> >> + IPIPE_URL:
> >>
> https://xenomai.org/downloads/ipipe/v4.x/x86/ipipe-core-4.14.89-x86-2.patch
> >> + - env:
> >> + - ARCH: x86
> >> + KERNEL_VERSION: 4.4.166
> >> + KERNEL_DEFCONFIG: i386_defconfig
> >> + IPIPE_URL:
> >>
> https://xenomai.org/downloads/ipipe/v4.x/x86/ipipe-core-4.4.166-x86-12.patch
> >>
> >
> > Starting to process my backlog with adding this commit to next. I had to
> create
> > a mirror in github for that, but now we have
> >
> > https://travis-ci.com/xenomai-ci/xenomai
>
> Seems we have some tracing-related build issues. I suppose the default
> configs
> are without tracing on, and that may trigger some issues.
>
> Did you test your commit separately as well?
>
> Regarding the other patches from your queue: Are there any updates pending?
>
> Jan
>
> >
> > fed by
> >
> > https://github.com/xenomai-ci/xenomai
> >
> > which is automatically updated when I push to the official repo. When
> everything
> > runs smoothly, we likely want to set some links, maybe including a build
> badge,
> > in our docs.
> >
> > Thanks for starting this!
> > Jan
> >
>
> --
> Siemens AG, Corporate Technology, CT RDA IOT SES-DE
> Corporate Competence Center Embedded Linux
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3] travis: add basic CI support
2019-03-18 14:21 ` Roman Stratiienko
@ 2019-03-18 14:24 ` Jan Kiszka
2019-03-18 15:39 ` Jan Kiszka
0 siblings, 1 reply; 12+ messages in thread
From: Jan Kiszka @ 2019-03-18 14:24 UTC (permalink / raw)
To: Roman Stratiienko; +Cc: xenomai
On 18.03.19 15:21, Roman Stratiienko wrote:
> Hello Jan,
>
> Build failure is caused by "cobalt: Add sched-quota tracepoints".
> I had to revert it to continue with testing
>
Ah, that's a good trace. We might be missing some include... One minute...
Jan
> You can check my fork:
> https://travis-ci.org/devel-opi/xenomai-fork
> https://github.com/devel-opi/xenomai-fork/commits/v4.20-fixes
>
> I didn't test the commits separately, but they should not cause build fails when
> applied one-by-one
>
> If no more comments from your side, then other patches are final
>
> Regards,
> Roman
>
> On Mon, Mar 18, 2019 at 3:25 PM Jan Kiszka <jan.kiszka@siemens.com
> <mailto:jan.kiszka@siemens.com>> wrote:
>
> On 18.03.19 13:59, Jan Kiszka wrote:
> > On 11.03.19 15:37, roman.stratiienko--- via Xenomai wrote:
> >> From: Roman Stratiienko <roman.stratiienko@globallogic.com
> <mailto:roman.stratiienko@globallogic.com>>
> >>
> >> Signed-off-by: Roman Stratiienko <roman.stratiienko@globallogic.com
> <mailto:roman.stratiienko@globallogic.com>>
> >> ---
> >>
> >> Changes since v2
> >>
> >> Removed redundand "CONFIG_" prefix
> >> Added building of the drivers
> >>
> >> Currently CAN bus driver build fails on v4.20 and v5.0,
> >> (https://travis-ci.org/devel-opi/xenomai-fork/builds/504429157)
> >>
> >> Please suggest which configs should be also enabled in
> >> CI to cover as much as possible code lines
> >>
> >> .travis.yml | 99 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> >> 1 file changed, 99 insertions(+)
> >> create mode 100644 .travis.yml
> >>
> >> diff --git a/.travis.yml b/.travis.yml
> >> new file mode 100644
> >> index 000000000..8d3eba2c3
> >> --- /dev/null
> >> +++ b/.travis.yml
> >> @@ -0,0 +1,99 @@
> >> +language: c
> >> +dist: xenial
> >> +
> >> +addons:
> >> + apt:
> >> + packages:
> >> + - gcc-aarch64-linux-gnu
> >> + - gcc-arm-linux-gnueabihf
> >> + - patch
> >> + - quilt
> >> + - wget
> >> +
> >> +env:
> >> + global:
> >> + - KDIR=/tmp/kernel
> >> +
> >> +install:
> >> + - if [[ "${KERNEL_VERSION}" == *-rc* ]]; then
> >> +
> >>
> KERNEL_URL=https://git.kernel.org/torvalds/t/linux-${KERNEL_VERSION}.tar.gz
> <https://git.kernel.org/torvalds/t/linux-$%7BKERNEL_VERSION%7D.tar.gz>;
> >> + else
> >> +
> >>
> KERNEL_URL=https://www.kernel.org/pub/linux/kernel/v${KERNEL_VERSION::1}.x/linux-${KERNEL_VERSION}.tar.xz
> <https://www.kernel.org/pub/linux/kernel/v$%7BKERNEL_VERSION::1%7D.x/linux-$%7BKERNEL_VERSION%7D.tar.xz>;
>
> >>
> >> + fi
> >> + - wget -O kernel.tar.xz ${KERNEL_URL} && mkdir ${KDIR} && tar -C ${KDIR}
> >> --strip=1 -xf kernel.tar.xz
> >> + - wget -O /tmp/ipipe.patch ${IPIPE_URL}
> >> +
> >> +before_script:
> >> + - case "${ARCH}" in
> >> + "arm64") export CROSS_COMPILE=aarch64-linux-gnu-
> >> + ;;
> >> + "arm" ) export CROSS_COMPILE=arm-linux-gnueabihf-
> >> + ;;
> >> + "x86" ) export CROSS_COMPILE=
> >> + ;;
> >> + esac
> >> + - pushd ${KDIR}
> >> + - make -j $(nproc) ${KERNEL_DEFCONFIG}
> >> + - ./scripts/config -e IPIPE
> >> + - ./scripts/config -e XENOMAI
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_DEBUG
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_DEBUG_FTRACE
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_8255
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_PARPORT
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_MITE
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_TIO
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_MIO
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_PCIMIO
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_670x
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_NI_660x
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_S526
> >> + - ./scripts/config -e XENO_DRIVERS_ANALOGY_FAKE
> >> + - ./scripts/config -e XENO_DRIVERS_AUTOTUNE
> >> + - ./scripts/config -e XENO_DRIVERS_CAN
> >> + - ./scripts/config -e XENO_DRIVERS_CAN_DEBUG
> >> + - ./scripts/config -e XENO_DRIVERS_CAN_LOOPBACK
> >> + - ./scripts/config -e XENO_DRIVERS_CAN_BUS_ERR
> >> + - ./scripts/config -e XENO_DRIVERS_CAN_VIRT
> >> + - ./scripts/config -e XENO_DRIVERS_CAN_FLEXCAN
> >> + - ./scripts/config -e XENO_DRIVERS_GPIO
> >> + - ./scripts/config -e XENO_DRIVERS_GPIO_SUN8I_H3
> >> + - ./scripts/config -e XENO_DRIVERS_GPIO_DEBUG
> >> + - ./scripts/config -e XENO_DRIVERS_GPIOPWM
> >> + - ./scripts/config -e XENO_DRIVERS_RTIPC
> >> + - ./scripts/config -e XENO_DRIVERS_NET
> >> + - ./scripts/config -e XENO_DRIVERS_16550A
> >> + - ./scripts/config -e XENO_DRIVERS_SPI
> >> + - ./scripts/config -e XENO_DRIVERS_TIMERBENCH
> >> + - ./scripts/config -e XENO_DRIVERS_UDD
> >> +
> >> + - popd
> >> +
> >> +script:
> >> + - ./scripts/prepare-kernel.sh --ipipe=/tmp/ipipe.patch --arch=${ARCH}
> >> --linux=${KDIR}
> >> + - cd ${KDIR}
> >> + - make -j $(nproc) olddefconfig
> >> + - make -j $(nproc) all
> >> +
> >> +matrix:
> >> + include:
> >> + - env:
> >> + - ARCH: arm
> >> + KERNEL_VERSION: 4.14.85
> >> + KERNEL_DEFCONFIG: multi_v7_defconfig
> >> + IPIPE_URL:
> >> https://xenomai.org/downloads/ipipe/v4.x/arm/ipipe-core-4.14.85-arm-6.patch
> >> + - env:
> >> + - ARCH: arm
> >> + KERNEL_VERSION: 4.1.18
> >> + KERNEL_DEFCONFIG: multi_v7_defconfig
> >> + IPIPE_URL:
> >>
> https://xenomai.org/downloads/ipipe/v4.x/arm/older/ipipe-core-4.1.18-arm-9.patch
> >> + - env:
> >> + - ARCH: x86
> >> + KERNEL_VERSION: 4.14.89
> >> + KERNEL_DEFCONFIG: x86_64_defconfig
> >> + IPIPE_URL:
> >> https://xenomai.org/downloads/ipipe/v4.x/x86/ipipe-core-4.14.89-x86-2.patch
> >> + - env:
> >> + - ARCH: x86
> >> + KERNEL_VERSION: 4.4.166
> >> + KERNEL_DEFCONFIG: i386_defconfig
> >> + IPIPE_URL:
> >> https://xenomai.org/downloads/ipipe/v4.x/x86/ipipe-core-4.4.166-x86-12.patch
> >>
> >
> > Starting to process my backlog with adding this commit to next. I had to
> create
> > a mirror in github for that, but now we have
> >
> > https://travis-ci.com/xenomai-ci/xenomai
>
> Seems we have some tracing-related build issues. I suppose the default configs
> are without tracing on, and that may trigger some issues.
>
> Did you test your commit separately as well?
>
> Regarding the other patches from your queue: Are there any updates pending?
>
> Jan
>
> >
> > fed by
> >
> > https://github.com/xenomai-ci/xenomai
> >
> > which is automatically updated when I push to the official repo. When
> everything
> > runs smoothly, we likely want to set some links, maybe including a build
> badge,
> > in our docs.
> >
> > Thanks for starting this!
> > Jan
> >
>
> --
> Siemens AG, Corporate Technology, CT RDA IOT SES-DE
> Corporate Competence Center Embedded Linux
>
>
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3] travis: add basic CI support
2019-03-18 14:24 ` Jan Kiszka
@ 2019-03-18 15:39 ` Jan Kiszka
2019-03-18 16:47 ` Roman Stratiienko
0 siblings, 1 reply; 12+ messages in thread
From: Jan Kiszka @ 2019-03-18 15:39 UTC (permalink / raw)
To: Roman Stratiienko; +Cc: xenomai
On 18.03.19 15:24, Jan Kiszka wrote:
> On 18.03.19 15:21, Roman Stratiienko wrote:
>> Hello Jan,
>>
>> Build failure is caused by "cobalt: Add sched-quota tracepoints".
>> I had to revert it to continue with testing
>>
>
> Ah, that's a good trace. We might be missing some include... One minute...
>
All green now with v2 of my tracepoint patch.
So we can move forward: Any updates on the fixes for newer kernels?
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3] travis: add basic CI support
2019-03-18 15:39 ` Jan Kiszka
@ 2019-03-18 16:47 ` Roman Stratiienko
2019-03-18 16:51 ` Jan Kiszka
0 siblings, 1 reply; 12+ messages in thread
From: Roman Stratiienko @ 2019-03-18 16:47 UTC (permalink / raw)
To: Jan Kiszka; +Cc: xenomai
On Mon, Mar 18, 2019 at 5:39 PM Jan Kiszka <jan.kiszka@siemens.com> wrote:
> On 18.03.19 15:24, Jan Kiszka wrote:
> > On 18.03.19 15:21, Roman Stratiienko wrote:
> >> Hello Jan,
> >>
> >> Build failure is caused by "cobalt: Add sched-quota tracepoints".
> >> I had to revert it to continue with testing
> >>
> >
> > Ah, that's a good trace. We might be missing some include... One
> minute...
> >
>
> All green now with v2 of my tracepoint patch.
>
> So we can move forward: Any updates on the fixes for newer kernels?
>
Currently not. I started to make clean port of ipipe-noarch onto 4.19, so I
hope to open it for review soon.
>
> Jan
>
> --
> Siemens AG, Corporate Technology, CT RDA IOT SES-DE
> Corporate Competence Center Embedded Linux
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3] travis: add basic CI support
2019-03-18 16:47 ` Roman Stratiienko
@ 2019-03-18 16:51 ` Jan Kiszka
2019-03-18 17:22 ` Roman Stratiienko
0 siblings, 1 reply; 12+ messages in thread
From: Jan Kiszka @ 2019-03-18 16:51 UTC (permalink / raw)
To: Roman Stratiienko, Philippe Gerum; +Cc: xenomai
On 18.03.19 17:47, Roman Stratiienko wrote:
>
>
> On Mon, Mar 18, 2019 at 5:39 PM Jan Kiszka <jan.kiszka@siemens.com
> <mailto:jan.kiszka@siemens.com>> wrote:
>
> On 18.03.19 15:24, Jan Kiszka wrote:
> > On 18.03.19 15:21, Roman Stratiienko wrote:
> >> Hello Jan,
> >>
> >> Build failure is caused by "cobalt: Add sched-quota tracepoints".
> >> I had to revert it to continue with testing
> >>
> >
> > Ah, that's a good trace. We might be missing some include... One minute...
> >
>
> All green now with v2 of my tracepoint patch.
>
> So we can move forward: Any updates on the fixes for newer kernels?
>
>
>
> Currently not. I started to make clean port of ipipe-noarch onto 4.19, so I hope
> to open it for review soon.
So, I will wait for updates then, ok?
Regarding the port on 4.19: Please sync with Philippe, he plans something as
well. It would be good if you two could work together so that you, Roman, know
what you, Philippe, would like to have to the target branches.
Thanks,
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3] travis: add basic CI support
2019-03-18 16:51 ` Jan Kiszka
@ 2019-03-18 17:22 ` Roman Stratiienko
2019-03-18 17:45 ` Philippe Gerum
0 siblings, 1 reply; 12+ messages in thread
From: Roman Stratiienko @ 2019-03-18 17:22 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Philippe Gerum, xenomai
I mean that I do not have any more updates,
But I will appreciate you if already sent patches would be applied.
@Philippe, ,
Thanks you for initial review of my draft branch.
Are you currently porting ipipe on 4.19?
If so, I will stop my similar activity and will focus on fixing build
issues of CAN Bus and other driver on Xenomai repository.
Regards,
Roman
On Mon, Mar 18, 2019 at 6:51 PM Jan Kiszka <jan.kiszka@siemens.com> wrote:
> On 18.03.19 17:47, Roman Stratiienko wrote:
> >
> >
> > On Mon, Mar 18, 2019 at 5:39 PM Jan Kiszka <jan.kiszka@siemens.com
> > <mailto:jan.kiszka@siemens.com>> wrote:
> >
> > On 18.03.19 15:24, Jan Kiszka wrote:
> > > On 18.03.19 15:21, Roman Stratiienko wrote:
> > >> Hello Jan,
> > >>
> > >> Build failure is caused by "cobalt: Add sched-quota tracepoints".
> > >> I had to revert it to continue with testing
> > >>
> > >
> > > Ah, that's a good trace. We might be missing some include... One
> minute...
> > >
> >
> > All green now with v2 of my tracepoint patch.
> >
> > So we can move forward: Any updates on the fixes for newer kernels?
> >
> >
> >
> > Currently not. I started to make clean port of ipipe-noarch onto 4.19,
> so I hope
> > to open it for review soon.
>
> So, I will wait for updates then, ok?
>
> Regarding the port on 4.19: Please sync with Philippe, he plans something
> as
> well. It would be good if you two could work together so that you, Roman,
> know
> what you, Philippe, would like to have to the target branches.
>
> Thanks,
> Jan
>
> --
> Siemens AG, Corporate Technology, CT RDA IOT SES-DE
> Corporate Competence Center Embedded Linux
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3] travis: add basic CI support
2019-03-18 17:22 ` Roman Stratiienko
@ 2019-03-18 17:45 ` Philippe Gerum
0 siblings, 0 replies; 12+ messages in thread
From: Philippe Gerum @ 2019-03-18 17:45 UTC (permalink / raw)
To: Roman Stratiienko, Jan Kiszka; +Cc: xenomai
On 3/18/19 6:22 PM, Roman Stratiienko wrote:
> I mean that I do not have any more updates,
> But I will appreciate you if already sent patches would be applied.
>
> @Philippe, ,
> Thanks you for initial review of my draft branch.
> Are you currently porting ipipe on 4.19?
I started to have a look at this a couple of hours ago only, but yes,
I'd like to have this running over ARM and ARM64 asap now.
--
Philippe.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] kernel: cobalt: replace access_ok with corresponding wrappers
2019-03-11 14:37 [PATCH] kernel: cobalt: replace access_ok with corresponding wrappers roman.stratiienko
2019-03-11 14:37 ` [PATCH v3] travis: add basic CI support roman.stratiienko
@ 2019-03-19 20:03 ` Jan Kiszka
1 sibling, 0 replies; 12+ messages in thread
From: Jan Kiszka @ 2019-03-19 20:03 UTC (permalink / raw)
To: roman.stratiienko, xenomai
On 11.03.19 15:37, roman.stratiienko--- via Xenomai wrote:
> From: Roman Stratiienko <roman.stratiienko@globallogic.com>
>
> Use access_wok / access_rok wrappers to enable support for kernel v5.0
>
> Signed-off-by: Roman Stratiienko <roman.stratiienko@globallogic.com>
> ---
>
> This patch is also required to support v5.0
>
> kernel/cobalt/pipe.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/cobalt/pipe.c b/kernel/cobalt/pipe.c
> index 0b8f8cbf8..16e85125c 100644
> --- a/kernel/cobalt/pipe.c
> +++ b/kernel/cobalt/pipe.c
> @@ -28,6 +28,7 @@
> #include <linux/device.h>
> #include <linux/uaccess.h>
> #include <asm/io.h>
> +#include <asm/xenomai/syscall.h>
> #include <cobalt/kernel/sched.h>
> #include <cobalt/kernel/heap.h>
> #include <cobalt/kernel/pipe.h>
> @@ -795,7 +796,7 @@ static ssize_t xnpipe_read(struct file *file,
> ssize_t ret;
> spl_t s;
>
> - if (!access_ok(VERIFY_WRITE, buf, count))
> + if (!access_wok(buf, count))
> return -EFAULT;
>
> xnlock_get_irqsave(&nklock, s);
> @@ -903,7 +904,7 @@ static ssize_t xnpipe_write(struct file *file,
> if (count == 0)
> return 0;
>
> - if (!access_ok(VERIFY_READ, buf, count))
> + if (!access_rok(buf, count))
> return -EFAULT;
>
> xnlock_get_irqsave(&nklock, s);
>
And this one is in now as well.
Thanks,
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-03-19 20:03 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-11 14:37 [PATCH] kernel: cobalt: replace access_ok with corresponding wrappers roman.stratiienko
2019-03-11 14:37 ` [PATCH v3] travis: add basic CI support roman.stratiienko
2019-03-18 12:59 ` Jan Kiszka
2019-03-18 13:25 ` Jan Kiszka
2019-03-18 14:21 ` Roman Stratiienko
2019-03-18 14:24 ` Jan Kiszka
2019-03-18 15:39 ` Jan Kiszka
2019-03-18 16:47 ` Roman Stratiienko
2019-03-18 16:51 ` Jan Kiszka
2019-03-18 17:22 ` Roman Stratiienko
2019-03-18 17:45 ` Philippe Gerum
2019-03-19 20:03 ` [PATCH] kernel: cobalt: replace access_ok with corresponding wrappers Jan Kiszka
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.