* [Buildroot] [PATCH v2, 1/1] package/connman: disable wireguard support
@ 2020-03-26 15:25 Mikael Bourhis-Cloarec
2020-03-26 17:01 ` Romain Naour
2020-03-26 19:01 ` Yann E. MORIN
0 siblings, 2 replies; 6+ messages in thread
From: Mikael Bourhis-Cloarec @ 2020-03-26 15:25 UTC (permalink / raw)
To: buildroot
The new Connman 1.38 release uses 'WireGuard' and 'libmnl' by default now.
But to keep the same 'Connman' setup as previous setup, we need to
explicitly disable the 'WireGuard' support.
The support of all the new 'Connman' options will be added by follow-up commits
(or patches).
Fixes:
http://autobuild.buildroot.org/?reason=connman-1.38
Signed-off-by: Mikael Bourhis-Cloarec <mikael.bourhis@smile.fr>
---
Changes v1 -> v2 (after review of Romain Naour)
- this fix concerns all Arch, not only x86_64
- do not add a new '_CONF_OPTS' line but use the previous one
package/connman/connman.mk | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/connman/connman.mk b/package/connman/connman.mk
index 701be8b59d..62ae919862 100644
--- a/package/connman/connman.mk
+++ b/package/connman/connman.mk
@@ -12,7 +12,8 @@ CONNMAN_INSTALL_STAGING = YES
CONNMAN_LICENSE = GPL-2.0
CONNMAN_LICENSE_FILES = COPYING
-CONNMAN_CONF_OPTS = --with-dbusconfdir=/etc
+CONNMAN_CONF_OPTS = --with-dbusconfdir=/etc \
+ --disable-wireguard
ifeq ($(BR2_INIT_SYSTEMD),y)
CONNMAN_CONF_OPTS += --with-systemdunitdir=/usr/lib/systemd/system
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2, 1/1] package/connman: disable wireguard support
2020-03-26 15:25 [Buildroot] [PATCH v2, 1/1] package/connman: disable wireguard support Mikael Bourhis-Cloarec
@ 2020-03-26 17:01 ` Romain Naour
2020-03-26 19:01 ` Yann E. MORIN
1 sibling, 0 replies; 6+ messages in thread
From: Romain Naour @ 2020-03-26 17:01 UTC (permalink / raw)
To: buildroot
Hi Mikael,
Le 26/03/2020 ? 16:25, Mikael Bourhis-Cloarec a ?crit?:
> The new Connman 1.38 release uses 'WireGuard' and 'libmnl' by default now.
>
> But to keep the same 'Connman' setup as previous setup, we need to
> explicitly disable the 'WireGuard' support.
>
> The support of all the new 'Connman' options will be added by follow-up commits
> (or patches).
>
> Fixes:
> http://autobuild.buildroot.org/?reason=connman-1.38
>
> Signed-off-by: Mikael Bourhis-Cloarec <mikael.bourhis@smile.fr>
Reviewed-by: Romain Naour <romain.naour@smile.fr>
Best regards,
Romain
> ---
> Changes v1 -> v2 (after review of Romain Naour)
> - this fix concerns all Arch, not only x86_64
> - do not add a new '_CONF_OPTS' line but use the previous one
>
> package/connman/connman.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/connman/connman.mk b/package/connman/connman.mk
> index 701be8b59d..62ae919862 100644
> --- a/package/connman/connman.mk
> +++ b/package/connman/connman.mk
> @@ -12,7 +12,8 @@ CONNMAN_INSTALL_STAGING = YES
> CONNMAN_LICENSE = GPL-2.0
> CONNMAN_LICENSE_FILES = COPYING
>
> -CONNMAN_CONF_OPTS = --with-dbusconfdir=/etc
> +CONNMAN_CONF_OPTS = --with-dbusconfdir=/etc \
> + --disable-wireguard
>
> ifeq ($(BR2_INIT_SYSTEMD),y)
> CONNMAN_CONF_OPTS += --with-systemdunitdir=/usr/lib/systemd/system
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2, 1/1] package/connman: disable wireguard support
2020-03-26 15:25 [Buildroot] [PATCH v2, 1/1] package/connman: disable wireguard support Mikael Bourhis-Cloarec
2020-03-26 17:01 ` Romain Naour
@ 2020-03-26 19:01 ` Yann E. MORIN
2020-03-26 20:30 ` Romain Naour
1 sibling, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2020-03-26 19:01 UTC (permalink / raw)
To: buildroot
On 2020-03-26 16:25 +0100, Mikael Bourhis-Cloarec spake thusly:
> The new Connman 1.38 release uses 'WireGuard' and 'libmnl' by default now.
For the libmnl part, we already have a pending patch:
https://patchwork.ozlabs.org/patch/1251106/
> But to keep the same 'Connman' setup as previous setup, we need to
> explicitly disable the 'WireGuard' support.
>
> The support of all the new 'Connman' options will be added by follow-up commits
> (or patches).
>
> Fixes:
> http://autobuild.buildroot.org/?reason=connman-1.38
AFAICS, all the failures have iptable support enabled, which should be
solved by the patch above...
I don't see how wireguard fits in the picture...
Regards,
Yann E. MORIN.
> Signed-off-by: Mikael Bourhis-Cloarec <mikael.bourhis@smile.fr>
> ---
> Changes v1 -> v2 (after review of Romain Naour)
> - this fix concerns all Arch, not only x86_64
> - do not add a new '_CONF_OPTS' line but use the previous one
>
> package/connman/connman.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/connman/connman.mk b/package/connman/connman.mk
> index 701be8b59d..62ae919862 100644
> --- a/package/connman/connman.mk
> +++ b/package/connman/connman.mk
> @@ -12,7 +12,8 @@ CONNMAN_INSTALL_STAGING = YES
> CONNMAN_LICENSE = GPL-2.0
> CONNMAN_LICENSE_FILES = COPYING
>
> -CONNMAN_CONF_OPTS = --with-dbusconfdir=/etc
> +CONNMAN_CONF_OPTS = --with-dbusconfdir=/etc \
> + --disable-wireguard
>
> ifeq ($(BR2_INIT_SYSTEMD),y)
> CONNMAN_CONF_OPTS += --with-systemdunitdir=/usr/lib/systemd/system
> --
> 2.20.1
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2, 1/1] package/connman: disable wireguard support
2020-03-26 19:01 ` Yann E. MORIN
@ 2020-03-26 20:30 ` Romain Naour
2020-03-26 20:37 ` Yann E. MORIN
0 siblings, 1 reply; 6+ messages in thread
From: Romain Naour @ 2020-03-26 20:30 UTC (permalink / raw)
To: buildroot
Hi Yann, All,
Le 26/03/2020 ? 20:01, Yann E. MORIN a ?crit?:
> On 2020-03-26 16:25 +0100, Mikael Bourhis-Cloarec spake thusly:
>> The new Connman 1.38 release uses 'WireGuard' and 'libmnl' by default now.
>
> For the libmnl part, we already have a pending patch:
> https://patchwork.ozlabs.org/patch/1251106/
>
>> But to keep the same 'Connman' setup as previous setup, we need to
>> explicitly disable the 'WireGuard' support.
>>
>> The support of all the new 'Connman' options will be added by follow-up commits
>> (or patches).
>>
>> Fixes:
>> http://autobuild.buildroot.org/?reason=connman-1.38
>
> AFAICS, all the failures have iptable support enabled, which should be
> solved by the patch above...
>
> I don't see how wireguard fits in the picture...
Sorry but our build still failing on current master with:
checking for LIBMNL... no
configure: error: libmnl >= 1.0.0 not found.
Here is the defconfig
BR2_aarch64=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_CONNMAN=y
BR2_PACKAGE_CONNMAN_WIFI=y
BR2_PACKAGE_CONNMAN_CLIENT=y
That's because wiregard is enabled by default and BR2_PACKAGE_CONNMAN_IPTABLES
is set.
See:
https://git.kernel.org/pub/scm/network/connman/connman.git/commit/?id=3f156e39cb79e2e60ec88cab87692dab5153efd6
It's unfortunate but we have several issues with the same error.
The case fixed by James Hilliard is when BR2_PACKAGE_CONNMAN_NFTABLES is set.
Best regards,
Romain
>
> Regards,
> Yann E. MORIN.
>
>> Signed-off-by: Mikael Bourhis-Cloarec <mikael.bourhis@smile.fr>
>> ---
>> Changes v1 -> v2 (after review of Romain Naour)
>> - this fix concerns all Arch, not only x86_64
>> - do not add a new '_CONF_OPTS' line but use the previous one
>>
>> package/connman/connman.mk | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/connman/connman.mk b/package/connman/connman.mk
>> index 701be8b59d..62ae919862 100644
>> --- a/package/connman/connman.mk
>> +++ b/package/connman/connman.mk
>> @@ -12,7 +12,8 @@ CONNMAN_INSTALL_STAGING = YES
>> CONNMAN_LICENSE = GPL-2.0
>> CONNMAN_LICENSE_FILES = COPYING
>>
>> -CONNMAN_CONF_OPTS = --with-dbusconfdir=/etc
>> +CONNMAN_CONF_OPTS = --with-dbusconfdir=/etc \
>> + --disable-wireguard
>>
>> ifeq ($(BR2_INIT_SYSTEMD),y)
>> CONNMAN_CONF_OPTS += --with-systemdunitdir=/usr/lib/systemd/system
>> --
>> 2.20.1
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2, 1/1] package/connman: disable wireguard support
2020-03-26 20:30 ` Romain Naour
@ 2020-03-26 20:37 ` Yann E. MORIN
2020-03-26 20:43 ` Yann E. MORIN
0 siblings, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2020-03-26 20:37 UTC (permalink / raw)
To: buildroot
Romain, All,
On 2020-03-26 21:30 +0100, Romain Naour spake thusly:
> Le 26/03/2020 ? 20:01, Yann E. MORIN a ?crit?:
> > On 2020-03-26 16:25 +0100, Mikael Bourhis-Cloarec spake thusly:
> >> The new Connman 1.38 release uses 'WireGuard' and 'libmnl' by default now.
> >
> > For the libmnl part, we already have a pending patch:
> > https://patchwork.ozlabs.org/patch/1251106/
> >
> >> But to keep the same 'Connman' setup as previous setup, we need to
> >> explicitly disable the 'WireGuard' support.
> >>
> >> The support of all the new 'Connman' options will be added by follow-up commits
> >> (or patches).
> >>
> >> Fixes:
> >> http://autobuild.buildroot.org/?reason=connman-1.38
> >
> > AFAICS, all the failures have iptable support enabled, which should be
> > solved by the patch above...
> >
> > I don't see how wireguard fits in the picture...
>
> Sorry but our build still failing on current master with:
I was not trying to imply that master was fixed, just that we already
had a pending patch about libmnl.
[--SNIP--]
> It's unfortunate but we have several issues with the same error.
> The case fixed by James Hilliard is when BR2_PACKAGE_CONNMAN_NFTABLES is set.
Damn, iptables, not nftables. Your patch is still on the table, then.
;-)
Regards,
Yann E. MORIN.
> Best regards,
> Romain
>
> >
> > Regards,
> > Yann E. MORIN.
> >
> >> Signed-off-by: Mikael Bourhis-Cloarec <mikael.bourhis@smile.fr>
> >> ---
> >> Changes v1 -> v2 (after review of Romain Naour)
> >> - this fix concerns all Arch, not only x86_64
> >> - do not add a new '_CONF_OPTS' line but use the previous one
> >>
> >> package/connman/connman.mk | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/package/connman/connman.mk b/package/connman/connman.mk
> >> index 701be8b59d..62ae919862 100644
> >> --- a/package/connman/connman.mk
> >> +++ b/package/connman/connman.mk
> >> @@ -12,7 +12,8 @@ CONNMAN_INSTALL_STAGING = YES
> >> CONNMAN_LICENSE = GPL-2.0
> >> CONNMAN_LICENSE_FILES = COPYING
> >>
> >> -CONNMAN_CONF_OPTS = --with-dbusconfdir=/etc
> >> +CONNMAN_CONF_OPTS = --with-dbusconfdir=/etc \
> >> + --disable-wireguard
> >>
> >> ifeq ($(BR2_INIT_SYSTEMD),y)
> >> CONNMAN_CONF_OPTS += --with-systemdunitdir=/usr/lib/systemd/system
> >> --
> >> 2.20.1
> >> _______________________________________________
> >> buildroot mailing list
> >> buildroot at busybox.net
> >> http://lists.busybox.net/mailman/listinfo/buildroot
> >
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2, 1/1] package/connman: disable wireguard support
2020-03-26 20:37 ` Yann E. MORIN
@ 2020-03-26 20:43 ` Yann E. MORIN
0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2020-03-26 20:43 UTC (permalink / raw)
To: buildroot
Romain, Mikael, All,
On 2020-03-26 21:37 +0100, Yann E. MORIN spake thusly:
> On 2020-03-26 21:30 +0100, Romain Naour spake thusly:
> > Le 26/03/2020 ? 20:01, Yann E. MORIN a ?crit?:
> > > On 2020-03-26 16:25 +0100, Mikael Bourhis-Cloarec spake thusly:
> > >> The new Connman 1.38 release uses 'WireGuard' and 'libmnl' by default now.
> Damn, iptables, not nftables. Your patch is still on the table, then.
In the meantime, Thomas applied another earlier pending patch that
actually enabled wireguard support.
So I've marked your patch as not applicable in patchwork.
Thanks for the contribution nonetheless! :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-26 20:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-26 15:25 [Buildroot] [PATCH v2, 1/1] package/connman: disable wireguard support Mikael Bourhis-Cloarec
2020-03-26 17:01 ` Romain Naour
2020-03-26 19:01 ` Yann E. MORIN
2020-03-26 20:30 ` Romain Naour
2020-03-26 20:37 ` Yann E. MORIN
2020-03-26 20:43 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.