From: Sylwester Nawrocki <s.nawrocki@samsung.com> To: Lee Jones <lee.jones@linaro.org> Cc: broonie@kernel.org, robh@kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, ideal.song@samsung.com, inki.dae@samsung.com, b.zolnierkie@samsung.com, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/4] mfd: Add DT bindings documentation for Samsung Exynos LPASS Date: Fri, 05 Aug 2016 17:44:33 +0200 [thread overview] Message-ID: <ac95ed3f-a4c5-e1a9-8470-8d00b14b1f95@samsung.com> (raw) In-Reply-To: <20160805133628.GG5243@dell> On 08/05/2016 03:36 PM, Lee Jones wrote: > On Tue, 05 Jul 2016, Sylwester Nawrocki wrote: > >> This patch adds documentation of the DT bindings for the Samsung >> Exynos SoC Low Power Audio Subsystem. >> >> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> >> new file mode 100644 >> index 0000000..7e97c0d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt >> @@ -0,0 +1,21 @@ >> + > > Nit: This line is superfluous. > >> +Samsung Exynos SoC Low Power Audio Subsystem (LPASS) >> + >> +Required properties: >> + >> + - compatible : "samsung,exynos5433-lpass" >> + - reg : should contain the LPASS top SFR region location and size >> + - samsung,pmu-syscon : the phandle to the Power Management Unit node >> + - #address-cells: should be 1 >> + - #size-cells: should be 1 >> + - ranges: must be present > > These look so much better like: > > - compatible : "samsung,exynos5433-lpass" > - reg : should contain the LPASS top SFR region location and size > - samsung,pmu-syscon : the phandle to the Power Management Unit node > - #address-cells : should be 1 > - #size-cells : should be 1 > - ranges : must be present OK, will rewrite it this way. >> +Each IP block of the Low Power Audio Subsystem should be specified >> +as an optional sub-node. For "samsung,exynos5433-lpass" compatible >> +this includes: UART, SLIMBUS, PCM, I2S, DMAC, Timers 0...4, WDT 0...1 >> +devices. >> + >> +Bindings of the sub-nodes are described in: >> + Documentation/devicetree/bindings/serial/samsung_uart.txt >> + Documentation/devicetree/bindings/sound/samsung-i2s.txt >> + Documentation/devicetree/bindings/dma/arm-pl330.txt > > Use relative path names: > > ../serial/samsung_uart.txt > ../sound/samsung-i2s.txt > ../dma/arm-pl330.txt OK, actually I had it this way in one of the versions but somehow with full paths it appeared better to me. > Missing example? Yes, omitted deliberately as that appeared quite many more lines with fully specified subnodes. Perhaps I will add it with omitted all properties of the subnodes but compatible. audio-subsystem { compatible = "samsung,exynos5433-lpass"; reg = <0x11400000 0x100>, <0x11500000 0x08>; samsung,pmu-syscon = <&pmu_system_controller>; #address-cells = <1>; #size-cells = <1>; ranges; adma: adma@11420000 { compatible = "arm,pl330", "arm,primecell"; reg = <0x11420000 0x1000>; interrupts = <0 73 0>; clocks = <&cmu_aud CLK_ACLK_DMAC>; clock-names = "apb_pclk"; #dma-cells = <1>; #dma-channels = <8>; #dma-requests = <32>; }; i2s0: i2s0@11440000 { compatible = "samsung,exynos7-i2s"; reg = <0x11440000 0x100>; dmas = <&adma 0 &adma 2>; dma-names = "tx", "rx"; interrupts = <0 70 0>; clocks = <&cmu_aud CLK_PCLK_AUD_I2S>, <&cmu_aud CLK_SCLK_AUD_I2S>, <&cmu_aud CLK_SCLK_I2S_BCLK>; clock-names = "iis", "i2s_opclk0", "i2s_opclk1"; pinctrl-names = "default"; pinctrl-0 = <&i2s0_bus>; status = "disabled"; }; serial_3: serial@11460000 { compatible = "samsung,exynos5433-uart"; reg = <0x11460000 0x100>; interrupts = <0 67 0>; clocks = <&cmu_aud CLK_PCLK_AUD_UART>, <&cmu_aud CLK_SCLK_AUD_UART>; clock-names = "uart", "clk_uart_baud0"; pinctrl-names = "default"; pinctrl-0 = <&uart_aud_bus>; status = "disabled"; }; };
WARNING: multiple messages have this Message-ID (diff)
From: Sylwester Nawrocki <s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> To: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ideal.song-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, inki.dae-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH v4 1/4] mfd: Add DT bindings documentation for Samsung Exynos LPASS Date: Fri, 05 Aug 2016 17:44:33 +0200 [thread overview] Message-ID: <ac95ed3f-a4c5-e1a9-8470-8d00b14b1f95@samsung.com> (raw) In-Reply-To: <20160805133628.GG5243@dell> On 08/05/2016 03:36 PM, Lee Jones wrote: > On Tue, 05 Jul 2016, Sylwester Nawrocki wrote: > >> This patch adds documentation of the DT bindings for the Samsung >> Exynos SoC Low Power Audio Subsystem. >> >> Signed-off-by: Sylwester Nawrocki <s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> >> new file mode 100644 >> index 0000000..7e97c0d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt >> @@ -0,0 +1,21 @@ >> + > > Nit: This line is superfluous. > >> +Samsung Exynos SoC Low Power Audio Subsystem (LPASS) >> + >> +Required properties: >> + >> + - compatible : "samsung,exynos5433-lpass" >> + - reg : should contain the LPASS top SFR region location and size >> + - samsung,pmu-syscon : the phandle to the Power Management Unit node >> + - #address-cells: should be 1 >> + - #size-cells: should be 1 >> + - ranges: must be present > > These look so much better like: > > - compatible : "samsung,exynos5433-lpass" > - reg : should contain the LPASS top SFR region location and size > - samsung,pmu-syscon : the phandle to the Power Management Unit node > - #address-cells : should be 1 > - #size-cells : should be 1 > - ranges : must be present OK, will rewrite it this way. >> +Each IP block of the Low Power Audio Subsystem should be specified >> +as an optional sub-node. For "samsung,exynos5433-lpass" compatible >> +this includes: UART, SLIMBUS, PCM, I2S, DMAC, Timers 0...4, WDT 0...1 >> +devices. >> + >> +Bindings of the sub-nodes are described in: >> + Documentation/devicetree/bindings/serial/samsung_uart.txt >> + Documentation/devicetree/bindings/sound/samsung-i2s.txt >> + Documentation/devicetree/bindings/dma/arm-pl330.txt > > Use relative path names: > > ../serial/samsung_uart.txt > ../sound/samsung-i2s.txt > ../dma/arm-pl330.txt OK, actually I had it this way in one of the versions but somehow with full paths it appeared better to me. > Missing example? Yes, omitted deliberately as that appeared quite many more lines with fully specified subnodes. Perhaps I will add it with omitted all properties of the subnodes but compatible. audio-subsystem { compatible = "samsung,exynos5433-lpass"; reg = <0x11400000 0x100>, <0x11500000 0x08>; samsung,pmu-syscon = <&pmu_system_controller>; #address-cells = <1>; #size-cells = <1>; ranges; adma: adma@11420000 { compatible = "arm,pl330", "arm,primecell"; reg = <0x11420000 0x1000>; interrupts = <0 73 0>; clocks = <&cmu_aud CLK_ACLK_DMAC>; clock-names = "apb_pclk"; #dma-cells = <1>; #dma-channels = <8>; #dma-requests = <32>; }; i2s0: i2s0@11440000 { compatible = "samsung,exynos7-i2s"; reg = <0x11440000 0x100>; dmas = <&adma 0 &adma 2>; dma-names = "tx", "rx"; interrupts = <0 70 0>; clocks = <&cmu_aud CLK_PCLK_AUD_I2S>, <&cmu_aud CLK_SCLK_AUD_I2S>, <&cmu_aud CLK_SCLK_I2S_BCLK>; clock-names = "iis", "i2s_opclk0", "i2s_opclk1"; pinctrl-names = "default"; pinctrl-0 = <&i2s0_bus>; status = "disabled"; }; serial_3: serial@11460000 { compatible = "samsung,exynos5433-uart"; reg = <0x11460000 0x100>; interrupts = <0 67 0>; clocks = <&cmu_aud CLK_PCLK_AUD_UART>, <&cmu_aud CLK_SCLK_AUD_UART>; clock-names = "uart", "clk_uart_baud0"; pinctrl-names = "default"; pinctrl-0 = <&uart_aud_bus>; status = "disabled"; }; }; -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-08-05 15:44 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-05 17:13 [PATCH v4 1/4] mfd: Add DT bindings documentation for Samsung Exynos LPASS Sylwester Nawrocki 2016-07-05 17:13 ` Sylwester Nawrocki 2016-07-11 14:32 ` Rob Herring 2016-08-05 13:36 ` Lee Jones 2016-08-05 15:44 ` Sylwester Nawrocki [this message] 2016-08-05 15:44 ` Sylwester Nawrocki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ac95ed3f-a4c5-e1a9-8470-8d00b14b1f95@samsung.com \ --to=s.nawrocki@samsung.com \ --cc=alsa-devel@alsa-project.org \ --cc=b.zolnierkie@samsung.com \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=ideal.song@samsung.com \ --cc=inki.dae@samsung.com \ --cc=lee.jones@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.