All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
	xen-devel@lists.xenproject.org, devel@driverdev.osuosl.org,
	linux-tegra@vger.kernel.org, intel-gfx@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-media@vger.kernel.org, sstabellini@kernel.org,
	jgross@suse.com, digetx@gmail.com, gregkh@linuxfoundation.org,
	arnd@arndb.de, mchehab@kernel.org, kyungmin.park@samsung.com,
	m.szyprowski@samsung.com, pawel@osciak.com, jonathanh@nvidia.com,
	thierry.reding@gmail.com, tomi.valkeinen@ti.com,
	rodrigo.vivi@intel.com, joonas.lahtinen@linux.intel.com,
	jani.nikula@linux.intel.com, sean@poorly.run,
	maxime.ripard@bootlin.com, maarten.lankhorst@linux.intel.com,
	linux@armlinux.org.uk, sumit.semwal@linaro.org
Subject: Re: [PATCH] dma-buf: add struct dma_buf_attach_info v2
Date: Tue, 30 Apr 2019 12:59:23 -0400	[thread overview]
Message-ID: <acaa403e-ad0f-dcf5-bccb-6b7331381889@oracle.com> (raw)
In-Reply-To: <20190430111002.106168-1-christian.koenig@amd.com>

On 4/30/19 7:10 AM, Christian König wrote:
> diff --git a/drivers/xen/gntdev-dmabuf.c b/drivers/xen/gntdev-dmabuf.c
> index 2c4f324f8626..cacca830b482 100644
> --- a/drivers/xen/gntdev-dmabuf.c
> +++ b/drivers/xen/gntdev-dmabuf.c
> @@ -608,6 +608,7 @@ dmabuf_imp_to_refs(struct gntdev_dmabuf_priv *priv, struct device *dev,
>  		   int fd, int count, int domid)
>  {
>  	struct gntdev_dmabuf *gntdev_dmabuf, *ret;
> +	struct dma_buf_attach_info attach_info;
>  	struct dma_buf *dma_buf;
>  	struct dma_buf_attachment *attach;
>  	struct sg_table *sgt;
> @@ -627,6 +628,9 @@ dmabuf_imp_to_refs(struct gntdev_dmabuf_priv *priv, struct device *dev,
>  	gntdev_dmabuf->priv = priv;
>  	gntdev_dmabuf->fd = fd;
>  
> +	memset(&attach_info, 0, sizeof(attach_info));
> +	attach_info.dev = dev;
> +	attach_info.dmabuf = dma_buf;
>  	attach = dma_buf_attach(dma_buf, dev);
>  	if (IS_ERR(attach)) {
>  		ret = ERR_CAST(attach);

This won't build.

Did you mean

    attach = dma_buf_attach(&attach_info);

?

-boris
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

WARNING: multiple messages have this Message-ID (diff)
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
	xen-devel@lists.xenproject.org, devel@driverdev.osuosl.org,
	linux-tegra@vger.kernel.org, intel-gfx@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-media@vger.kernel.org, sstabellini@kernel.org,
	jgross@suse.com, digetx@gmail.com, gregkh@linuxfoundation.org,
	arnd@arndb.de, mchehab@kernel.org, kyungmin.park@samsung.com,
	m.szyprowski@samsung.com, pawel@osciak.com, jonathanh@nvidia.com,
	thierry.reding@gmail.com, tomi.valkeinen@ti.com,
	rodrigo.vivi@intel.com, joonas.lahtinen@linux.intel.com,
	jani.nikula@linux.intel.com, sean@poorly.run,
	maxime.ripard@bootlin.com, maarten.lankhorst@linux.intel.com,
	linux@armlinux.org.uk, sumit.semwal@linaro.org
Subject: Re: [PATCH] dma-buf: add struct dma_buf_attach_info v2
Date: Tue, 30 Apr 2019 12:59:23 -0400	[thread overview]
Message-ID: <acaa403e-ad0f-dcf5-bccb-6b7331381889@oracle.com> (raw)
In-Reply-To: <20190430111002.106168-1-christian.koenig@amd.com>

On 4/30/19 7:10 AM, Christian König wrote:
> diff --git a/drivers/xen/gntdev-dmabuf.c b/drivers/xen/gntdev-dmabuf.c
> index 2c4f324f8626..cacca830b482 100644
> --- a/drivers/xen/gntdev-dmabuf.c
> +++ b/drivers/xen/gntdev-dmabuf.c
> @@ -608,6 +608,7 @@ dmabuf_imp_to_refs(struct gntdev_dmabuf_priv *priv, struct device *dev,
>  		   int fd, int count, int domid)
>  {
>  	struct gntdev_dmabuf *gntdev_dmabuf, *ret;
> +	struct dma_buf_attach_info attach_info;
>  	struct dma_buf *dma_buf;
>  	struct dma_buf_attachment *attach;
>  	struct sg_table *sgt;
> @@ -627,6 +628,9 @@ dmabuf_imp_to_refs(struct gntdev_dmabuf_priv *priv, struct device *dev,
>  	gntdev_dmabuf->priv = priv;
>  	gntdev_dmabuf->fd = fd;
>  
> +	memset(&attach_info, 0, sizeof(attach_info));
> +	attach_info.dev = dev;
> +	attach_info.dmabuf = dma_buf;
>  	attach = dma_buf_attach(dma_buf, dev);
>  	if (IS_ERR(attach)) {
>  		ret = ERR_CAST(attach);

This won't build.

Did you mean

    attach = dma_buf_attach(&attach_info);

?

-boris

WARNING: multiple messages have this Message-ID (diff)
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
	xen-devel@lists.xenproject.org, devel@driverdev.osuosl.org,
	linux-tegra@vger.kernel.org, intel-gfx@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-media@vger.kernel.org, sstabellini@kernel.org,
	jgross@suse.com, digetx@gmail.com, gregkh@linuxfoundation.org,
	arnd@arndb.de, mchehab@kernel.org, kyungmin.park@samsung.com,
	m.szyprowski@samsung.com, pawel@osciak.com, jonathanh@nvidia.com,
	thierry.reding@gmail.com, tomi.valkeinen@ti.com,
	rodrigo.vivi@intel.com, joonas.lahtinen@linux.intel.com,
	jani.nikula@linux.intel.com, sean@poorly.run,
	maxime.ripard@bootlin.com, maarten.lankhorst@linux.intel.com,
	linux@armlinux.org.uk, sumit.semwal@linaro.org
Subject: Re: [Xen-devel] [PATCH] dma-buf: add struct dma_buf_attach_info v2
Date: Tue, 30 Apr 2019 12:59:23 -0400	[thread overview]
Message-ID: <acaa403e-ad0f-dcf5-bccb-6b7331381889@oracle.com> (raw)
In-Reply-To: <20190430111002.106168-1-christian.koenig@amd.com>

On 4/30/19 7:10 AM, Christian König wrote:
> diff --git a/drivers/xen/gntdev-dmabuf.c b/drivers/xen/gntdev-dmabuf.c
> index 2c4f324f8626..cacca830b482 100644
> --- a/drivers/xen/gntdev-dmabuf.c
> +++ b/drivers/xen/gntdev-dmabuf.c
> @@ -608,6 +608,7 @@ dmabuf_imp_to_refs(struct gntdev_dmabuf_priv *priv, struct device *dev,
>  		   int fd, int count, int domid)
>  {
>  	struct gntdev_dmabuf *gntdev_dmabuf, *ret;
> +	struct dma_buf_attach_info attach_info;
>  	struct dma_buf *dma_buf;
>  	struct dma_buf_attachment *attach;
>  	struct sg_table *sgt;
> @@ -627,6 +628,9 @@ dmabuf_imp_to_refs(struct gntdev_dmabuf_priv *priv, struct device *dev,
>  	gntdev_dmabuf->priv = priv;
>  	gntdev_dmabuf->fd = fd;
>  
> +	memset(&attach_info, 0, sizeof(attach_info));
> +	attach_info.dev = dev;
> +	attach_info.dmabuf = dma_buf;
>  	attach = dma_buf_attach(dma_buf, dev);
>  	if (IS_ERR(attach)) {
>  		ret = ERR_CAST(attach);

This won't build.

Did you mean

    attach = dma_buf_attach(&attach_info);

?

-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2019-04-30 16:59 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-30 11:10 [PATCH] dma-buf: add struct dma_buf_attach_info v2 Christian König
2019-04-30 11:10 ` [Xen-devel] " Christian König
2019-04-30 13:49 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-04-30 14:05 ` ✓ Fi.CI.BAT: success " Patchwork
2019-04-30 15:23 ` [PATCH] " kbuild test robot
2019-04-30 15:23   ` [Xen-devel] [Intel-gfx] " kbuild test robot
2019-04-30 15:23   ` kbuild test robot
2019-04-30 15:23 ` kbuild test robot
2019-04-30 16:59 ` Boris Ostrovsky
2019-04-30 16:59 ` Boris Ostrovsky [this message]
2019-04-30 16:59   ` [Xen-devel] " Boris Ostrovsky
2019-04-30 16:59   ` Boris Ostrovsky
2019-04-30 17:31 ` Russell King - ARM Linux admin
2019-04-30 17:31   ` [Xen-devel] " Russell King - ARM Linux admin
2019-05-03 12:05   ` Christian König
2019-05-03 12:05   ` Christian König
2019-05-03 12:05     ` [Xen-devel] " Christian König
2019-05-03 12:09     ` [Intel-gfx] " Daniel Vetter
2019-05-03 12:09       ` [Xen-devel] " Daniel Vetter
2019-05-03 12:09       ` Daniel Vetter
2019-05-03 12:15       ` Koenig, Christian
2019-05-03 12:15         ` [Xen-devel] " Koenig, Christian
2019-05-03 12:15         ` Koenig, Christian
2019-05-03 12:15       ` Koenig, Christian
2019-05-03 12:09     ` Daniel Vetter
2019-04-30 17:31 ` Russell King - ARM Linux admin
2019-04-30 23:06 ` [Intel-gfx] " kbuild test robot
2019-04-30 23:06 ` kbuild test robot
2019-04-30 23:06   ` [Xen-devel] [Intel-gfx] " kbuild test robot
2019-05-01  4:44 ` ✗ Fi.CI.IGT: failure for " Patchwork
2019-05-02  7:59 ` Patchwork
2019-05-02  8:54 ` Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2019-04-30 11:10 [PATCH] " Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acaa403e-ad0f-dcf5-bccb-6b7331381889@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=arnd@arndb.de \
    --cc=ckoenig.leichtzumerken@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=digetx@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=jgross@suse.com \
    --cc=jonathanh@nvidia.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=m.szyprowski@samsung.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=mchehab@kernel.org \
    --cc=pawel@osciak.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=sean@poorly.run \
    --cc=sstabellini@kernel.org \
    --cc=sumit.semwal@linaro.org \
    --cc=thierry.reding@gmail.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.