* [PATCHv2] iio: buffer: check if a buffer has been set up when poll is called
@ 2018-02-15 7:28 Stefan Windfeldt-Prytz
2018-02-15 7:33 ` Lars-Peter Clausen
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Windfeldt-Prytz @ 2018-02-15 7:28 UTC (permalink / raw)
To: jic23; +Cc: knaack.h, lars, ppmeerw, linux-iio, Stefan Windfeldt-Prytz
If no iio buffer has been set up and poll is called return 0.
Signed-off-by: Stefan Windfeldt-Prytz <stefan.windfeldt@axis.com>
---
Changes in v2:
- Removed Change-Id
drivers/iio/industrialio-buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
index 79abf70..cd5bfe3 100644
--- a/drivers/iio/industrialio-buffer.c
+++ b/drivers/iio/industrialio-buffer.c
@@ -175,7 +175,7 @@ __poll_t iio_buffer_poll(struct file *filp,
struct iio_dev *indio_dev = filp->private_data;
struct iio_buffer *rb = indio_dev->buffer;
- if (!indio_dev->info)
+ if (!indio_dev->info || rb == NULL)
return 0;
poll_wait(filp, &rb->pollq, wait);
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCHv2] iio: buffer: check if a buffer has been set up when poll is called
2018-02-15 7:28 [PATCHv2] iio: buffer: check if a buffer has been set up when poll is called Stefan Windfeldt-Prytz
@ 2018-02-15 7:33 ` Lars-Peter Clausen
0 siblings, 0 replies; 2+ messages in thread
From: Lars-Peter Clausen @ 2018-02-15 7:33 UTC (permalink / raw)
To: Stefan Windfeldt-Prytz, jic23
Cc: knaack.h, ppmeerw, linux-iio, Stefan Windfeldt-Prytz
On 02/15/2018 08:28 AM, Stefan Windfeldt-Prytz wrote:
> If no iio buffer has been set up and poll is called return 0.
>
This is a pretty bad bug, thanks for fixing this.
The commit message should include a section about the consequences of
missing check.
It looks like the issue goes back all the way to the beginning and the fix
needs to be backported to all stable releases.
> Signed-off-by: Stefan Windfeldt-Prytz <stefan.windfeldt@axis.com>
> ---
> Changes in v2:
> - Removed Change-Id
>
> drivers/iio/industrialio-buffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
> index 79abf70..cd5bfe3 100644
> --- a/drivers/iio/industrialio-buffer.c
> +++ b/drivers/iio/industrialio-buffer.c
> @@ -175,7 +175,7 @@ __poll_t iio_buffer_poll(struct file *filp,
> struct iio_dev *indio_dev = filp->private_data;
> struct iio_buffer *rb = indio_dev->buffer;
>
> - if (!indio_dev->info)
> + if (!indio_dev->info || rb == NULL)
> return 0;
>
> poll_wait(filp, &rb->pollq, wait);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-15 7:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-15 7:28 [PATCHv2] iio: buffer: check if a buffer has been set up when poll is called Stefan Windfeldt-Prytz
2018-02-15 7:33 ` Lars-Peter Clausen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.