All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] virt: acrn: Fix document of acrn_msi_inject()
@ 2021-03-10 15:37 shuo.a.liu
  2021-03-10 15:50 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 3+ messages in thread
From: shuo.a.liu @ 2021-03-10 15:37 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-kernel, lkp, Shuo Liu

From: Shuo Liu <shuo.a.liu@intel.com>

This fixes below sparse warning.

../drivers/virt/acrn/vm.c:105: warning: expecting prototype for
acrn_inject_msi(). Prototype was for acrn_msi_inject() instead

Fixes: c7cf8d27244f ("virt: acrn: Introduce interrupt injection interfaces")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Shuo Liu <shuo.a.liu@intel.com>
---
 drivers/virt/acrn/vm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/virt/acrn/vm.c b/drivers/virt/acrn/vm.c
index 7804a2492ad7..0d002a355a93 100644
--- a/drivers/virt/acrn/vm.c
+++ b/drivers/virt/acrn/vm.c
@@ -94,7 +94,7 @@ int acrn_vm_destroy(struct acrn_vm *vm)
 }
 
 /**
- * acrn_inject_msi() - Inject a MSI interrupt into a User VM
+ * acrn_msi_inject() - Inject a MSI interrupt into a User VM
  * @vm:		User VM
  * @msi_addr:	The MSI address
  * @msi_data:	The MSI data
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] virt: acrn: Fix document of acrn_msi_inject()
  2021-03-10 15:37 [PATCH] virt: acrn: Fix document of acrn_msi_inject() shuo.a.liu
@ 2021-03-10 15:50 ` Greg Kroah-Hartman
  2021-03-10 15:56   ` Liu, Shuo A
  0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2021-03-10 15:50 UTC (permalink / raw)
  To: shuo.a.liu; +Cc: linux-kernel, lkp

On Wed, Mar 10, 2021 at 11:37:51PM +0800, shuo.a.liu@intel.com wrote:
> From: Shuo Liu <shuo.a.liu@intel.com>
> 
> This fixes below sparse warning.
> 
> ../drivers/virt/acrn/vm.c:105: warning: expecting prototype for
> acrn_inject_msi(). Prototype was for acrn_msi_inject() instead

That is not a warning from sparse :(


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] virt: acrn: Fix document of acrn_msi_inject()
  2021-03-10 15:50 ` Greg Kroah-Hartman
@ 2021-03-10 15:56   ` Liu, Shuo A
  0 siblings, 0 replies; 3+ messages in thread
From: Liu, Shuo A @ 2021-03-10 15:56 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-kernel, lkp



On 3/10/2021 23:50, Greg Kroah-Hartman wrote:
> On Wed, Mar 10, 2021 at 11:37:51PM +0800, shuo.a.liu@intel.com wrote:
>> From: Shuo Liu <shuo.a.liu@intel.com>
>>
>> This fixes below sparse warning.
>>
>> ../drivers/virt/acrn/vm.c:105: warning: expecting prototype for
>> acrn_inject_msi(). Prototype was for acrn_msi_inject() instead
> 
> That is not a warning from sparse :(
> 

Oh. You are right. I was fixing another sparse warning and did
	make O=out -j24 W=1 C=1
to reproduce that warning.

It misled me that this warning coming out with sparse too.

Let me re-send the patch.

Thanks
shuo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-10 15:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-10 15:37 [PATCH] virt: acrn: Fix document of acrn_msi_inject() shuo.a.liu
2021-03-10 15:50 ` Greg Kroah-Hartman
2021-03-10 15:56   ` Liu, Shuo A

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.