* [PATCH v2] docs: update xenstore-migration.md
@ 2020-05-28 8:22 Juergen Gross
2020-05-28 8:34 ` Julien Grall
2020-05-28 8:53 ` Paul Durrant
0 siblings, 2 replies; 6+ messages in thread
From: Juergen Gross @ 2020-05-28 8:22 UTC (permalink / raw)
To: xen-devel
Cc: Juergen Gross, Stefano Stabellini, Julien Grall, Wei Liu,
Andrew Cooper, Ian Jackson, George Dunlap, Jan Beulich
Update connection record details: make flags common for sockets and
domains, and add pending incoming data.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- added out-resp-len to connection record
---
docs/designs/xenstore-migration.md | 71 +++++++++++++++++-------------
1 file changed, 40 insertions(+), 31 deletions(-)
diff --git a/docs/designs/xenstore-migration.md b/docs/designs/xenstore-migration.md
index 34a2afd17e..5736bbad94 100644
--- a/docs/designs/xenstore-migration.md
+++ b/docs/designs/xenstore-migration.md
@@ -147,43 +147,59 @@ the domain being migrated.
```
0 1 2 3 4 5 6 7 octet
+-------+-------+-------+-------+-------+-------+-------+-------+
-| conn-id | conn-type | conn-spec
+| conn-id | conn-type | flags |
++-------------------------------+---------------+---------------+
+| conn-spec
...
-+-------------------------------+-------------------------------+
-| data-len | data
-+-------------------------------+
++---------------+---------------+-------------------------------+
+| in-data-len | out-resp-len | out-data-len |
++---------------+---------------+-------------------------------+
+| data
...
```
-| Field | Description |
-|-------------|-------------------------------------------------|
-| `conn-id` | A non-zero number used to identify this |
-| | connection in subsequent connection-specific |
-| | records |
-| | |
-| `conn-type` | 0x0000: shared ring |
-| | 0x0001: socket |
-| | 0x0002 - 0xFFFF: reserved for future use |
-| | |
-| `conn-spec` | See below |
-| | |
-| `data-len` | The length (in octets) of any pending data not |
-| | yet written to the connection |
-| | |
-| `data` | Pending data (may be empty) |
+| Field | Description |
+|----------------|----------------------------------------------|
+| `conn-id` | A non-zero number used to identify this |
+| | connection in subsequent connection-specific |
+| | records |
+| | |
+| `flags` | A bit-wise OR of: |
+| | 0001: read-only |
+| | |
+| `conn-type` | 0x0000: shared ring |
+| | 0x0001: socket |
+| | 0x0002 - 0xFFFF: reserved for future use |
+| | |
+| `conn-spec` | See below |
+| | |
+| `in-data-len` | The length (in octets) of any data read |
+| | from the connection not yet processed |
+| | |
+| `out-resp-len` | The length (in octets) of a partial response |
+| | not yet written to the connection (included |
+| | in the following `out-data-len`) |
+| | |
+| `out-data-len` | The length (in octets) of any pending data |
+| | not yet written to the connection |
+| | |
+| `data` | Pending data, first read data, then written |
+| | data (any of both may be empty) |
-The format of `conn-spec` is dependent upon `conn-type`.
+In case of live update the connection record for the connection via which
+the live update command was issued will contain the response for the live
+update command in the pending write data.
\pagebreak
+The format of `conn-spec` is dependent upon `conn-type`.
+
For `shared ring` connections it is as follows:
```
0 1 2 3 4 5 6 7 octet
- +-------+-------+
- | flags |
+---------------+---------------+---------------+---------------+
| domid | tdomid | evtchn |
+-------------------------------+-------------------------------+
@@ -198,8 +214,6 @@ For `shared ring` connections it is as follows:
| | it has been subject to an SET_TARGET |
| | operation [2] or DOMID_INVALID [3] otherwise |
| | |
-| `flags` | Must be zero |
-| | |
| `evtchn` | The port number of the interdomain channel used |
| | by `domid` to communicate with xenstored |
| | |
@@ -211,8 +225,6 @@ For `socket` connections it is as follows:
```
- +-------+-------+
- | flags |
+---------------+---------------+---------------+---------------+
| socket-fd | pad |
+-------------------------------+-------------------------------+
@@ -221,9 +233,6 @@ For `socket` connections it is as follows:
| Field | Description |
|-------------|-------------------------------------------------|
-| `flags` | A bit-wise OR of: |
-| | 0001: read-only |
-| | |
| `socket-fd` | The file descriptor of the connected socket |
This type of connection is only relevant for live update, where the xenstored
@@ -398,4 +407,4 @@ explanation of node permissions.
[3] See https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/include/public/xen.h;hb=HEAD#l612
-[4] https://wiki.xen.org/wiki/XenBus
\ No newline at end of file
+[4] https://wiki.xen.org/wiki/XenBus
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] docs: update xenstore-migration.md
2020-05-28 8:22 [PATCH v2] docs: update xenstore-migration.md Juergen Gross
@ 2020-05-28 8:34 ` Julien Grall
2020-05-28 8:56 ` Jürgen Groß
2020-05-28 8:53 ` Paul Durrant
1 sibling, 1 reply; 6+ messages in thread
From: Julien Grall @ 2020-05-28 8:34 UTC (permalink / raw)
To: Juergen Gross, xen-devel
Cc: Stefano Stabellini, Wei Liu, Andrew Cooper, Ian Jackson,
George Dunlap, Jan Beulich
Hi Juergen,
On 28/05/2020 09:22, Juergen Gross wrote:
> -| Field | Description |
> -|-------------|-------------------------------------------------|
> -| `conn-id` | A non-zero number used to identify this |
> -| | connection in subsequent connection-specific |
> -| | records |
> -| | |
> -| `conn-type` | 0x0000: shared ring |
> -| | 0x0001: socket |
> -| | 0x0002 - 0xFFFF: reserved for future use |
> -| | |
> -| `conn-spec` | See below |
> -| | |
> -| `data-len` | The length (in octets) of any pending data not |
> -| | yet written to the connection |
> -| | |
> -| `data` | Pending data (may be empty) |
> +| Field | Description |
> +|----------------|----------------------------------------------|
> +| `conn-id` | A non-zero number used to identify this |
> +| | connection in subsequent connection-specific |
> +| | records |
> +| | |
> +| `flags` | A bit-wise OR of: |
> +| | 0001: read-only |
NIT: It is a bit odd the flags is in the header after `conn-type` and
described before.
> +| | |
> +| `conn-type` | 0x0000: shared ring |
> +| | 0x0001: socket |
> +| | 0x0002 - 0xFFFF: reserved for future use |
> +| | |
> +| `conn-spec` | See below |
> +| | |
> +| `in-data-len` | The length (in octets) of any data read |
> +| | from the connection not yet processed |
> +| | |
> +| `out-resp-len` | The length (in octets) of a partial response |
> +| | not yet written to the connection (included |
> +| | in the following `out-data-len`) |
This seems to come from nowhere. It would be good to explain in the
commit message why this is necessary.
> +| | |
> +| `out-data-len` | The length (in octets) of any pending data |
> +| | not yet written to the connection |
Cheers,
--
Julien Grall
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2] docs: update xenstore-migration.md
2020-05-28 8:22 [PATCH v2] docs: update xenstore-migration.md Juergen Gross
2020-05-28 8:34 ` Julien Grall
@ 2020-05-28 8:53 ` Paul Durrant
2020-05-28 8:58 ` Jürgen Groß
1 sibling, 1 reply; 6+ messages in thread
From: Paul Durrant @ 2020-05-28 8:53 UTC (permalink / raw)
To: 'Juergen Gross', xen-devel
Cc: 'Stefano Stabellini', 'Julien Grall',
'Wei Liu', 'Andrew Cooper', 'Ian Jackson',
'George Dunlap', 'Jan Beulich'
> -----Original Message-----
> From: Xen-devel <xen-devel-bounces@lists.xenproject.org> On Behalf Of Juergen Gross
> Sent: 28 May 2020 09:22
> To: xen-devel@lists.xenproject.org
> Cc: Juergen Gross <jgross@suse.com>; Stefano Stabellini <sstabellini@kernel.org>; Julien Grall
> <julien@xen.org>; Wei Liu <wl@xen.org>; Andrew Cooper <andrew.cooper3@citrix.com>; Ian Jackson
> <ian.jackson@eu.citrix.com>; George Dunlap <george.dunlap@citrix.com>; Jan Beulich <jbeulich@suse.com>
> Subject: [PATCH v2] docs: update xenstore-migration.md
>
> Update connection record details: make flags common for sockets and
> domains, and add pending incoming data.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> V2:
> - added out-resp-len to connection record
> ---
> docs/designs/xenstore-migration.md | 71 +++++++++++++++++-------------
> 1 file changed, 40 insertions(+), 31 deletions(-)
>
> diff --git a/docs/designs/xenstore-migration.md b/docs/designs/xenstore-migration.md
> index 34a2afd17e..5736bbad94 100644
> --- a/docs/designs/xenstore-migration.md
> +++ b/docs/designs/xenstore-migration.md
> @@ -147,43 +147,59 @@ the domain being migrated.
> ```
> 0 1 2 3 4 5 6 7 octet
> +-------+-------+-------+-------+-------+-------+-------+-------+
> -| conn-id | conn-type | conn-spec
> +| conn-id | conn-type | flags |
> ++-------------------------------+---------------+---------------+
> +| conn-spec
> ...
> -+-------------------------------+-------------------------------+
> -| data-len | data
> -+-------------------------------+
> ++---------------+---------------+-------------------------------+
> +| in-data-len | out-resp-len | out-data-len |
> ++---------------+---------------+-------------------------------+
> +| data
> ...
> ```
>
>
> -| Field | Description |
> -|-------------|-------------------------------------------------|
> -| `conn-id` | A non-zero number used to identify this |
> -| | connection in subsequent connection-specific |
> -| | records |
> -| | |
> -| `conn-type` | 0x0000: shared ring |
> -| | 0x0001: socket |
> -| | 0x0002 - 0xFFFF: reserved for future use |
> -| | |
> -| `conn-spec` | See below |
> -| | |
> -| `data-len` | The length (in octets) of any pending data not |
> -| | yet written to the connection |
> -| | |
> -| `data` | Pending data (may be empty) |
> +| Field | Description |
> +|----------------|----------------------------------------------|
> +| `conn-id` | A non-zero number used to identify this |
> +| | connection in subsequent connection-specific |
> +| | records |
> +| | |
> +| `flags` | A bit-wise OR of: |
> +| | 0001: read-only |
> +| | |
> +| `conn-type` | 0x0000: shared ring |
> +| | 0x0001: socket |
> +| | 0x0002 - 0xFFFF: reserved for future use |
> +| | |
Agreed with Julien... the above two would be better swapped to match the order of the fields in the record.
> +| `conn-spec` | See below |
> +| | |
> +| `in-data-len` | The length (in octets) of any data read |
> +| | from the connection not yet processed |
> +| | |
> +| `out-resp-len` | The length (in octets) of a partial response |
> +| | not yet written to the connection (included |
> +| | in the following `out-data-len`) |
> +| | |
> +| `out-data-len` | The length (in octets) of any pending data |
> +| | not yet written to the connection |
So, IIUC out-data-len is inclusive of out-resp-len?
> +| | |
> +| `data` | Pending data, first read data, then written |
> +| | data (any of both may be empty) |
Perhaps be more explicit here:
"Pending data: first in-data-len octets of read data, then out-data-len octets of written data"
>
> -The format of `conn-spec` is dependent upon `conn-type`.
> +In case of live update the connection record for the connection via which
> +the live update command was issued will contain the response for the live
> +update command in the pending write data.
s/write/written for consistency I think.
Paul
>
> \pagebreak
>
> +The format of `conn-spec` is dependent upon `conn-type`.
> +
> For `shared ring` connections it is as follows:
>
>
> ```
> 0 1 2 3 4 5 6 7 octet
> - +-------+-------+
> - | flags |
> +---------------+---------------+---------------+---------------+
> | domid | tdomid | evtchn |
> +-------------------------------+-------------------------------+
> @@ -198,8 +214,6 @@ For `shared ring` connections it is as follows:
> | | it has been subject to an SET_TARGET |
> | | operation [2] or DOMID_INVALID [3] otherwise |
> | | |
> -| `flags` | Must be zero |
> -| | |
> | `evtchn` | The port number of the interdomain channel used |
> | | by `domid` to communicate with xenstored |
> | | |
> @@ -211,8 +225,6 @@ For `socket` connections it is as follows:
>
>
> ```
> - +-------+-------+
> - | flags |
> +---------------+---------------+---------------+---------------+
> | socket-fd | pad |
> +-------------------------------+-------------------------------+
> @@ -221,9 +233,6 @@ For `socket` connections it is as follows:
>
> | Field | Description |
> |-------------|-------------------------------------------------|
> -| `flags` | A bit-wise OR of: |
> -| | 0001: read-only |
> -| | |
> | `socket-fd` | The file descriptor of the connected socket |
>
> This type of connection is only relevant for live update, where the xenstored
> @@ -398,4 +407,4 @@ explanation of node permissions.
>
> [3] See https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/include/public/xen.h;hb=HEAD#l612
>
> -[4] https://wiki.xen.org/wiki/XenBus
> \ No newline at end of file
> +[4] https://wiki.xen.org/wiki/XenBus
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] docs: update xenstore-migration.md
2020-05-28 8:34 ` Julien Grall
@ 2020-05-28 8:56 ` Jürgen Groß
0 siblings, 0 replies; 6+ messages in thread
From: Jürgen Groß @ 2020-05-28 8:56 UTC (permalink / raw)
To: Julien Grall, xen-devel
Cc: Stefano Stabellini, Wei Liu, Andrew Cooper, Ian Jackson,
George Dunlap, Jan Beulich
On 28.05.20 10:34, Julien Grall wrote:
> Hi Juergen,
>
> On 28/05/2020 09:22, Juergen Gross wrote:
>> -| Field | Description |
>> -|-------------|-------------------------------------------------|
>> -| `conn-id` | A non-zero number used to identify this |
>> -| | connection in subsequent connection-specific |
>> -| | records |
>> -| | |
>> -| `conn-type` | 0x0000: shared ring |
>> -| | 0x0001: socket |
>> -| | 0x0002 - 0xFFFF: reserved for future use |
>> -| | |
>> -| `conn-spec` | See below |
>> -| | |
>> -| `data-len` | The length (in octets) of any pending data not |
>> -| | yet written to the connection |
>> -| | |
>> -| `data` | Pending data (may be empty) |
>> +| Field | Description |
>> +|----------------|----------------------------------------------|
>> +| `conn-id` | A non-zero number used to identify this |
>> +| | connection in subsequent connection-specific |
>> +| | records |
>> +| | |
>> +| `flags` | A bit-wise OR of: |
>> +| | 0001: read-only |
>
> NIT: It is a bit odd the flags is in the header after `conn-type` and
> described before.
Okay, I'll swap the descriptions.
>
>> +| | |
>> +| `conn-type` | 0x0000: shared ring |
>> +| | 0x0001: socket |
>> +| | 0x0002 - 0xFFFF: reserved for future use |
>> +| | |
>> +| `conn-spec` | See below |
>> +| | |
>> +| `in-data-len` | The length (in octets) of any data read |
>> +| | from the connection not yet processed |
>> +| | |
>> +| `out-resp-len` | The length (in octets) of a partial response |
>> +| | not yet written to the connection (included |
>> +| | in the following `out-data-len`) |
>
> This seems to come from nowhere. It would be good to explain in the
> commit message why this is necessary.
Okay.
Juergen
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] docs: update xenstore-migration.md
2020-05-28 8:53 ` Paul Durrant
@ 2020-05-28 8:58 ` Jürgen Groß
2020-05-28 9:00 ` Paul Durrant
0 siblings, 1 reply; 6+ messages in thread
From: Jürgen Groß @ 2020-05-28 8:58 UTC (permalink / raw)
To: paul, xen-devel
Cc: 'Stefano Stabellini', 'Julien Grall',
'Wei Liu', 'Andrew Cooper', 'Ian Jackson',
'George Dunlap', 'Jan Beulich'
On 28.05.20 10:53, Paul Durrant wrote:
>> -----Original Message-----
>> From: Xen-devel <xen-devel-bounces@lists.xenproject.org> On Behalf Of Juergen Gross
>> Sent: 28 May 2020 09:22
>> To: xen-devel@lists.xenproject.org
>> Cc: Juergen Gross <jgross@suse.com>; Stefano Stabellini <sstabellini@kernel.org>; Julien Grall
>> <julien@xen.org>; Wei Liu <wl@xen.org>; Andrew Cooper <andrew.cooper3@citrix.com>; Ian Jackson
>> <ian.jackson@eu.citrix.com>; George Dunlap <george.dunlap@citrix.com>; Jan Beulich <jbeulich@suse.com>
>> Subject: [PATCH v2] docs: update xenstore-migration.md
>>
>> Update connection record details: make flags common for sockets and
>> domains, and add pending incoming data.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> ---
>> V2:
>> - added out-resp-len to connection record
>> ---
>> docs/designs/xenstore-migration.md | 71 +++++++++++++++++-------------
>> 1 file changed, 40 insertions(+), 31 deletions(-)
>>
>> diff --git a/docs/designs/xenstore-migration.md b/docs/designs/xenstore-migration.md
>> index 34a2afd17e..5736bbad94 100644
>> --- a/docs/designs/xenstore-migration.md
>> +++ b/docs/designs/xenstore-migration.md
>> @@ -147,43 +147,59 @@ the domain being migrated.
>> ```
>> 0 1 2 3 4 5 6 7 octet
>> +-------+-------+-------+-------+-------+-------+-------+-------+
>> -| conn-id | conn-type | conn-spec
>> +| conn-id | conn-type | flags |
>> ++-------------------------------+---------------+---------------+
>> +| conn-spec
>> ...
>> -+-------------------------------+-------------------------------+
>> -| data-len | data
>> -+-------------------------------+
>> ++---------------+---------------+-------------------------------+
>> +| in-data-len | out-resp-len | out-data-len |
>> ++---------------+---------------+-------------------------------+
>> +| data
>> ...
>> ```
>>
>>
>> -| Field | Description |
>> -|-------------|-------------------------------------------------|
>> -| `conn-id` | A non-zero number used to identify this |
>> -| | connection in subsequent connection-specific |
>> -| | records |
>> -| | |
>> -| `conn-type` | 0x0000: shared ring |
>> -| | 0x0001: socket |
>> -| | 0x0002 - 0xFFFF: reserved for future use |
>> -| | |
>> -| `conn-spec` | See below |
>> -| | |
>> -| `data-len` | The length (in octets) of any pending data not |
>> -| | yet written to the connection |
>> -| | |
>> -| `data` | Pending data (may be empty) |
>> +| Field | Description |
>> +|----------------|----------------------------------------------|
>> +| `conn-id` | A non-zero number used to identify this |
>> +| | connection in subsequent connection-specific |
>> +| | records |
>> +| | |
>> +| `flags` | A bit-wise OR of: |
>> +| | 0001: read-only |
>> +| | |
>> +| `conn-type` | 0x0000: shared ring |
>> +| | 0x0001: socket |
>> +| | 0x0002 - 0xFFFF: reserved for future use |
>> +| | |
>
> Agreed with Julien... the above two would be better swapped to match the order of the fields in the record.
Yes.
>
>> +| `conn-spec` | See below |
>> +| | |
>> +| `in-data-len` | The length (in octets) of any data read |
>> +| | from the connection not yet processed |
>> +| | |
>> +| `out-resp-len` | The length (in octets) of a partial response |
>> +| | not yet written to the connection (included |
>> +| | in the following `out-data-len`) |
>> +| | |
>> +| `out-data-len` | The length (in octets) of any pending data |
>> +| | not yet written to the connection |
>
> So, IIUC out-data-len is inclusive of out-resp-len?
Yes.
>
>> +| | |
>> +| `data` | Pending data, first read data, then written |
>> +| | data (any of both may be empty) |
>
> Perhaps be more explicit here:
>
> "Pending data: first in-data-len octets of read data, then out-data-len octets of written data"
Okay.
>
>>
>> -The format of `conn-spec` is dependent upon `conn-type`.
>> +In case of live update the connection record for the connection via which
>> +the live update command was issued will contain the response for the live
>> +update command in the pending write data.
>
> s/write/written for consistency I think.
I'll use "... in the pending not yet written data".
Juergen
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2] docs: update xenstore-migration.md
2020-05-28 8:58 ` Jürgen Groß
@ 2020-05-28 9:00 ` Paul Durrant
0 siblings, 0 replies; 6+ messages in thread
From: Paul Durrant @ 2020-05-28 9:00 UTC (permalink / raw)
To: 'Jürgen Groß', xen-devel
Cc: 'Stefano Stabellini', 'Julien Grall',
'Wei Liu', 'Andrew Cooper', 'Ian Jackson',
'George Dunlap', 'Jan Beulich'
> -----Original Message-----
> From: Jürgen Groß <jgross@suse.com>
> Sent: 28 May 2020 09:59
> To: paul@xen.org; xen-devel@lists.xenproject.org
> Cc: 'Stefano Stabellini' <sstabellini@kernel.org>; 'Julien Grall' <julien@xen.org>; 'Wei Liu'
> <wl@xen.org>; 'Andrew Cooper' <andrew.cooper3@citrix.com>; 'Ian Jackson' <ian.jackson@eu.citrix.com>;
> 'George Dunlap' <george.dunlap@citrix.com>; 'Jan Beulich' <jbeulich@suse.com>
> Subject: Re: [PATCH v2] docs: update xenstore-migration.md
>
> On 28.05.20 10:53, Paul Durrant wrote:
> >> -----Original Message-----
> >> From: Xen-devel <xen-devel-bounces@lists.xenproject.org> On Behalf Of Juergen Gross
> >> Sent: 28 May 2020 09:22
> >> To: xen-devel@lists.xenproject.org
> >> Cc: Juergen Gross <jgross@suse.com>; Stefano Stabellini <sstabellini@kernel.org>; Julien Grall
> >> <julien@xen.org>; Wei Liu <wl@xen.org>; Andrew Cooper <andrew.cooper3@citrix.com>; Ian Jackson
> >> <ian.jackson@eu.citrix.com>; George Dunlap <george.dunlap@citrix.com>; Jan Beulich
> <jbeulich@suse.com>
> >> Subject: [PATCH v2] docs: update xenstore-migration.md
> >>
> >> Update connection record details: make flags common for sockets and
> >> domains, and add pending incoming data.
> >>
> >> Signed-off-by: Juergen Gross <jgross@suse.com>
> >> ---
> >> V2:
> >> - added out-resp-len to connection record
> >> ---
> >> docs/designs/xenstore-migration.md | 71 +++++++++++++++++-------------
> >> 1 file changed, 40 insertions(+), 31 deletions(-)
> >>
> >> diff --git a/docs/designs/xenstore-migration.md b/docs/designs/xenstore-migration.md
> >> index 34a2afd17e..5736bbad94 100644
> >> --- a/docs/designs/xenstore-migration.md
> >> +++ b/docs/designs/xenstore-migration.md
> >> @@ -147,43 +147,59 @@ the domain being migrated.
> >> ```
> >> 0 1 2 3 4 5 6 7 octet
> >> +-------+-------+-------+-------+-------+-------+-------+-------+
> >> -| conn-id | conn-type | conn-spec
> >> +| conn-id | conn-type | flags |
> >> ++-------------------------------+---------------+---------------+
> >> +| conn-spec
> >> ...
> >> -+-------------------------------+-------------------------------+
> >> -| data-len | data
> >> -+-------------------------------+
> >> ++---------------+---------------+-------------------------------+
> >> +| in-data-len | out-resp-len | out-data-len |
> >> ++---------------+---------------+-------------------------------+
> >> +| data
> >> ...
> >> ```
> >>
> >>
> >> -| Field | Description |
> >> -|-------------|-------------------------------------------------|
> >> -| `conn-id` | A non-zero number used to identify this |
> >> -| | connection in subsequent connection-specific |
> >> -| | records |
> >> -| | |
> >> -| `conn-type` | 0x0000: shared ring |
> >> -| | 0x0001: socket |
> >> -| | 0x0002 - 0xFFFF: reserved for future use |
> >> -| | |
> >> -| `conn-spec` | See below |
> >> -| | |
> >> -| `data-len` | The length (in octets) of any pending data not |
> >> -| | yet written to the connection |
> >> -| | |
> >> -| `data` | Pending data (may be empty) |
> >> +| Field | Description |
> >> +|----------------|----------------------------------------------|
> >> +| `conn-id` | A non-zero number used to identify this |
> >> +| | connection in subsequent connection-specific |
> >> +| | records |
> >> +| | |
> >> +| `flags` | A bit-wise OR of: |
> >> +| | 0001: read-only |
> >> +| | |
> >> +| `conn-type` | 0x0000: shared ring |
> >> +| | 0x0001: socket |
> >> +| | 0x0002 - 0xFFFF: reserved for future use |
> >> +| | |
> >
> > Agreed with Julien... the above two would be better swapped to match the order of the fields in the
> record.
>
> Yes.
>
> >
> >> +| `conn-spec` | See below |
> >> +| | |
> >> +| `in-data-len` | The length (in octets) of any data read |
> >> +| | from the connection not yet processed |
> >> +| | |
> >> +| `out-resp-len` | The length (in octets) of a partial response |
> >> +| | not yet written to the connection (included |
> >> +| | in the following `out-data-len`) |
> >> +| | |
> >> +| `out-data-len` | The length (in octets) of any pending data |
> >> +| | not yet written to the connection |
> >
> > So, IIUC out-data-len is inclusive of out-resp-len?
>
> Yes.
>
> >
> >> +| | |
> >> +| `data` | Pending data, first read data, then written |
> >> +| | data (any of both may be empty) |
> >
> > Perhaps be more explicit here:
> >
> > "Pending data: first in-data-len octets of read data, then out-data-len octets of written data"
>
> Okay.
>
> >
> >>
> >> -The format of `conn-spec` is dependent upon `conn-type`.
> >> +In case of live update the connection record for the connection via which
> >> +the live update command was issued will contain the response for the live
> >> +update command in the pending write data.
> >
> > s/write/written for consistency I think.
>
> I'll use "... in the pending not yet written data".
>
Ok.
Paul
>
> Juergen
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-28 9:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28 8:22 [PATCH v2] docs: update xenstore-migration.md Juergen Gross
2020-05-28 8:34 ` Julien Grall
2020-05-28 8:56 ` Jürgen Groß
2020-05-28 8:53 ` Paul Durrant
2020-05-28 8:58 ` Jürgen Groß
2020-05-28 9:00 ` Paul Durrant
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.