All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikolay Aleksandrov <nikolay@nvidia.com>
To: Nikolay Aleksandrov <razor@blackwall.org>, netdev@vger.kernel.org
Cc: roopa@nvidia.com, bridge@lists.linux-foundation.org,
	kuba@kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next] net: bridge: mcast: remove unreachable EHT code
Date: Mon, 15 Mar 2021 17:44:19 +0200	[thread overview]
Message-ID: <ad95c2f3-a3c8-cd56-1e83-e4a7d53c7f7f@nvidia.com> (raw)
In-Reply-To: <20210315153835.190174-1-razor@blackwall.org>

On 15/03/2021 17:38, Nikolay Aleksandrov wrote:
> From: Nikolay Aleksandrov <nikolay@nvidia.com>
> 
> In the initial EHT versions there were common functions which handled
> allow/block messages for both INCLUDE and EXCLUDE modes, but later they
> were separated. It seems I've left some common code which cannot be
> reached because the filter mode is checked before calling the respective
> functions, i.e. the host filter is always in EXCLUDE mode when using
> __eht_allow_excl() and __eht_block_excl() thus we can drop the host_excl
> checks inside and simplify the code a bit.
> 
> Signed-off-by: Nikolay Aleksandrov <nikolay@nvidia.com>
> ---
>  net/bridge/br_multicast_eht.c | 54 ++++++++++-------------------------
>  1 file changed, 15 insertions(+), 39 deletions(-)
> 

Oh well, sent the wrong patch version. I'll send the proper version as v2.
Self-NAK and sorry for the noise



WARNING: multiple messages have this Message-ID (diff)
From: Nikolay Aleksandrov <nikolay@nvidia.com>
To: Nikolay Aleksandrov <razor@blackwall.org>, netdev@vger.kernel.org
Cc: kuba@kernel.org, bridge@lists.linux-foundation.org,
	davem@davemloft.net, roopa@nvidia.com
Subject: Re: [Bridge] [PATCH net-next] net: bridge: mcast: remove unreachable EHT code
Date: Mon, 15 Mar 2021 17:44:19 +0200	[thread overview]
Message-ID: <ad95c2f3-a3c8-cd56-1e83-e4a7d53c7f7f@nvidia.com> (raw)
In-Reply-To: <20210315153835.190174-1-razor@blackwall.org>

On 15/03/2021 17:38, Nikolay Aleksandrov wrote:
> From: Nikolay Aleksandrov <nikolay@nvidia.com>
> 
> In the initial EHT versions there were common functions which handled
> allow/block messages for both INCLUDE and EXCLUDE modes, but later they
> were separated. It seems I've left some common code which cannot be
> reached because the filter mode is checked before calling the respective
> functions, i.e. the host filter is always in EXCLUDE mode when using
> __eht_allow_excl() and __eht_block_excl() thus we can drop the host_excl
> checks inside and simplify the code a bit.
> 
> Signed-off-by: Nikolay Aleksandrov <nikolay@nvidia.com>
> ---
>  net/bridge/br_multicast_eht.c | 54 ++++++++++-------------------------
>  1 file changed, 15 insertions(+), 39 deletions(-)
> 

Oh well, sent the wrong patch version. I'll send the proper version as v2.
Self-NAK and sorry for the noise



  reply	other threads:[~2021-03-15 15:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-15 15:38 [PATCH net-next] net: bridge: mcast: remove unreachable EHT code Nikolay Aleksandrov
2021-03-15 15:38 ` [Bridge] " Nikolay Aleksandrov
2021-03-15 15:44 ` Nikolay Aleksandrov [this message]
2021-03-15 15:44   ` Nikolay Aleksandrov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad95c2f3-a3c8-cd56-1e83-e4a7d53c7f7f@nvidia.com \
    --to=nikolay@nvidia.com \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=razor@blackwall.org \
    --cc=roopa@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.