All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxim Mikityanskiy <maximmi@mellanox.com>
To: Magnus Karlsson <magnus.karlsson@intel.com>,
	"bjorn.topel@intel.com" <bjorn.topel@intel.com>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>
Cc: "maciej.fijalkowski@intel.com" <maciej.fijalkowski@intel.com>,
	"maciejromanfijalkowski@gmail.com"
	<maciejromanfijalkowski@gmail.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Tariq Toukan <tariqt@mellanox.com>,
	Saeed Mahameed <saeedm@mellanox.com>
Subject: Re: [PATCH net 1/2] i40e: need_wakeup flag might not be set for Tx
Date: Mon, 25 Nov 2019 15:24:33 +0000	[thread overview]
Message-ID: <adee745d-6522-309d-a944-7a54869ac945@mellanox.com> (raw)
In-Reply-To: <1573243090-2721-1-git-send-email-magnus.karlsson@intel.com>

Hi Magnus,

On 2019-11-08 21:58, Magnus Karlsson wrote:
> This happens if there is at least one
> outstanding packet that has not been completed by the hardware and we
> get that corresponding completion (which will not generate an
> interrupt since interrupts are disabled in the napi poll loop) between
> the time we stopped processing the Tx completions and interrupts are
> enabled again.

> But if this completion interrupt occurs before interrupts
> are enable, we lose it
Why can't it happen for regular traffic? From your description it looks 
to me as if you can miss a completion for non-AF_XDP traffic, too. Is 
there any detail that makes this issue AF_XDP-specific?

Thanks,
Max

WARNING: multiple messages have this Message-ID (diff)
From: Maxim Mikityanskiy <maximmi@mellanox.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net 1/2] i40e: need_wakeup flag might not be set for Tx
Date: Mon, 25 Nov 2019 15:24:33 +0000	[thread overview]
Message-ID: <adee745d-6522-309d-a944-7a54869ac945@mellanox.com> (raw)
In-Reply-To: <1573243090-2721-1-git-send-email-magnus.karlsson@intel.com>

Hi Magnus,

On 2019-11-08 21:58, Magnus Karlsson wrote:
> This happens if there is at least one
> outstanding packet that has not been completed by the hardware and we
> get that corresponding completion (which will not generate an
> interrupt since interrupts are disabled in the napi poll loop) between
> the time we stopped processing the Tx completions and interrupts are
> enabled again.

> But if this completion interrupt occurs before interrupts
> are enable, we lose it
Why can't it happen for regular traffic? From your description it looks 
to me as if you can miss a completion for non-AF_XDP traffic, too. Is 
there any detail that makes this issue AF_XDP-specific?

Thanks,
Max

  parent reply	other threads:[~2019-11-25 15:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-08 19:58 [PATCH net 1/2] i40e: need_wakeup flag might not be set for Tx Magnus Karlsson
2019-11-08 19:58 ` [Intel-wired-lan] " Magnus Karlsson
2019-11-08 19:58 ` [PATCH net 2/2] ixgbe: " Magnus Karlsson
2019-11-08 19:58   ` [Intel-wired-lan] " Magnus Karlsson
2019-11-09  0:02   ` Bowers, AndrewX
2019-11-09  0:02     ` Bowers, AndrewX
2019-11-08 22:11 ` [PATCH net 1/2] i40e: " David Miller
2019-11-08 22:11   ` [Intel-wired-lan] " David Miller
2019-11-08 22:46   ` Jeff Kirsher
2019-11-08 22:46     ` [Intel-wired-lan] " Jeff Kirsher
2019-11-09  0:01 ` Bowers, AndrewX
2019-11-09  0:01   ` Bowers, AndrewX
2019-11-25 15:24 ` Maxim Mikityanskiy [this message]
2019-11-25 15:24   ` Maxim Mikityanskiy
2019-11-25 16:44   ` Magnus Karlsson
2019-11-25 16:44     ` Magnus Karlsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adee745d-6522-309d-a944-7a54869ac945@mellanox.com \
    --to=maximmi@mellanox.com \
    --cc=bjorn.topel@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=maciej.fijalkowski@intel.com \
    --cc=maciejromanfijalkowski@gmail.com \
    --cc=magnus.karlsson@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    --cc=tariqt@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.