* [PATCH] tools/libs: fix build of stubdoms
@ 2021-09-08 12:43 Juergen Gross
2021-09-08 12:53 ` Andrew Cooper
0 siblings, 1 reply; 4+ messages in thread
From: Juergen Gross @ 2021-09-08 12:43 UTC (permalink / raw)
To: xen-devel; +Cc: Juergen Gross, Ian Jackson, Wei Liu
In case abi-dumper is available the stubdom builds will fail due to a
false dependency on dynamic loadable libraries. Fix that.
Fixes: d7c9f7a7a3959913b4 ("tools/libs: Write out an ABI analysis when abi-dumper is available")
Signed-off-by: Juergen Gross <jgross@suse.com>
---
tools/libs/libs.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
index 84130ccbaf..ebdb2a4782 100644
--- a/tools/libs/libs.mk
+++ b/tools/libs/libs.mk
@@ -98,10 +98,12 @@ lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR): $(PIC_OBJS) libxen$(LIBNAME).map
# If abi-dumper is available, write out the ABI analysis
ifneq ($(ABI_DUMPER),)
+ifneq ($(nosharedlibs),y)
libs: $(PKG_ABI)
$(PKG_ABI): lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) headers.lst
$(ABI_DUMPER) $< -o $@ -public-headers headers.lst -lver $(MAJOR).$(MINOR)
endif
+endif
.PHONY: install
install: build
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tools/libs: fix build of stubdoms
2021-09-08 12:43 [PATCH] tools/libs: fix build of stubdoms Juergen Gross
@ 2021-09-08 12:53 ` Andrew Cooper
2021-09-27 7:24 ` Juergen Gross
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Cooper @ 2021-09-08 12:53 UTC (permalink / raw)
To: Juergen Gross, xen-devel; +Cc: Ian Jackson, Wei Liu
On 08/09/2021 13:43, Juergen Gross wrote:
> In case abi-dumper is available the stubdom builds will fail due to a
> false dependency on dynamic loadable libraries. Fix that.
>
> Fixes: d7c9f7a7a3959913b4 ("tools/libs: Write out an ABI analysis when abi-dumper is available")
> Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tools/libs: fix build of stubdoms
2021-09-08 12:53 ` Andrew Cooper
@ 2021-09-27 7:24 ` Juergen Gross
2021-09-27 14:36 ` Ian Jackson
0 siblings, 1 reply; 4+ messages in thread
From: Juergen Gross @ 2021-09-27 7:24 UTC (permalink / raw)
To: Andrew Cooper, xen-devel; +Cc: Ian Jackson, Wei Liu
[-- Attachment #1.1.1: Type: text/plain, Size: 489 bytes --]
On 08.09.21 14:53, Andrew Cooper wrote:
> On 08/09/2021 13:43, Juergen Gross wrote:
>> In case abi-dumper is available the stubdom builds will fail due to a
>> false dependency on dynamic loadable libraries. Fix that.
>>
>> Fixes: d7c9f7a7a3959913b4 ("tools/libs: Write out an ABI analysis when abi-dumper is available")
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
Could this please be committed?
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tools/libs: fix build of stubdoms
2021-09-27 7:24 ` Juergen Gross
@ 2021-09-27 14:36 ` Ian Jackson
0 siblings, 0 replies; 4+ messages in thread
From: Ian Jackson @ 2021-09-27 14:36 UTC (permalink / raw)
To: Juergen Gross; +Cc: Andrew Cooper, xen-devel, Wei Liu
Juergen Gross writes ("Re: [PATCH] tools/libs: fix build of stubdoms"):
> On 08.09.21 14:53, Andrew Cooper wrote:
> > On 08/09/2021 13:43, Juergen Gross wrote:
> >> In case abi-dumper is available the stubdom builds will fail due to a
> >> false dependency on dynamic loadable libraries. Fix that.
> >>
> >> Fixes: d7c9f7a7a3959913b4 ("tools/libs: Write out an ABI analysis when abi-dumper is available")
> >> Signed-off-by: Juergen Gross <jgross@suse.com>
> >
> > Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
> >
>
> Could this please be committed?
Done
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-27 14:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-08 12:43 [PATCH] tools/libs: fix build of stubdoms Juergen Gross
2021-09-08 12:53 ` Andrew Cooper
2021-09-27 7:24 ` Juergen Gross
2021-09-27 14:36 ` Ian Jackson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.