All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Nicholas Piggin <npiggin@gmail.com>,
	Mike Kravetz <mike.kravetz@oracle.com>,
	Mike Rapoport <rppt@kernel.org>,
	naresh.kamboju@linaro.org, linux-arch@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, sparclinux@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH] arm64: Define only {pud/pmd}_{set/clear}_huge when usefull
Date: Sat, 15 May 2021 08:28:25 +0200	[thread overview]
Message-ID: <ae1be8a1-8412-1288-31d4-23dc2cf4e5e7@csgroup.eu> (raw)
In-Reply-To: <20210514144200.b49ee77c9b2a7f9998ffbf22@linux-foundation.org>



Le 14/05/2021 à 23:42, Andrew Morton a écrit :
> On Fri, 14 May 2021 11:08:53 +0000 (UTC) Christophe Leroy <christophe.leroy@csgroup.eu> wrote:
> 
>> When PUD and/or PMD are folded, those functions are useless
>> and we now have a stub in linux/pgtable.h
> 
> OK, help me out here please.  What patch does this fix?
> 

Both this one and the x86 one from the day before fix 1cff41494b15cd82c1ec418bb5c ("mm/pgtable: add 
stubs for {pmd/pub}_{set/clear}_huge")

I think both the x86 fix and the arm64 fix should be squashed into that patch at the end.

I checked, the only other architecture involving pud_set_huge() and friends is powerpc, and powerpc 
doesn't have this problem as it only defined those for book3s/64 platforms which have 4 level page 
tables by definition.

Thanks
Christophe

WARNING: multiple messages have this Message-ID (diff)
From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-arch@vger.kernel.org, naresh.kamboju@linaro.org,
	linux-kernel@vger.kernel.org, Nicholas Piggin <npiggin@gmail.com>,
	linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org,
	sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	Mike Rapoport <rppt@kernel.org>,
	Mike Kravetz <mike.kravetz@oracle.com>
Subject: Re: [PATCH] arm64: Define only {pud/pmd}_{set/clear}_huge when usefull
Date: Sat, 15 May 2021 08:28:25 +0200	[thread overview]
Message-ID: <ae1be8a1-8412-1288-31d4-23dc2cf4e5e7@csgroup.eu> (raw)
In-Reply-To: <20210514144200.b49ee77c9b2a7f9998ffbf22@linux-foundation.org>



Le 14/05/2021 à 23:42, Andrew Morton a écrit :
> On Fri, 14 May 2021 11:08:53 +0000 (UTC) Christophe Leroy <christophe.leroy@csgroup.eu> wrote:
> 
>> When PUD and/or PMD are folded, those functions are useless
>> and we now have a stub in linux/pgtable.h
> 
> OK, help me out here please.  What patch does this fix?
> 

Both this one and the x86 one from the day before fix 1cff41494b15cd82c1ec418bb5c ("mm/pgtable: add 
stubs for {pmd/pub}_{set/clear}_huge")

I think both the x86 fix and the arm64 fix should be squashed into that patch at the end.

I checked, the only other architecture involving pud_set_huge() and friends is powerpc, and powerpc 
doesn't have this problem as it only defined those for book3s/64 platforms which have 4 level page 
tables by definition.

Thanks
Christophe

WARNING: multiple messages have this Message-ID (diff)
From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Nicholas Piggin <npiggin@gmail.com>,
	Mike Kravetz <mike.kravetz@oracle.com>,
	Mike Rapoport <rppt@kernel.org>,
	naresh.kamboju@linaro.org, linux-arch@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, sparclinux@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH] arm64: Define only {pud/pmd}_{set/clear}_huge when usefull
Date: Sat, 15 May 2021 08:28:25 +0200	[thread overview]
Message-ID: <ae1be8a1-8412-1288-31d4-23dc2cf4e5e7@csgroup.eu> (raw)
In-Reply-To: <20210514144200.b49ee77c9b2a7f9998ffbf22@linux-foundation.org>



Le 14/05/2021 à 23:42, Andrew Morton a écrit :
> On Fri, 14 May 2021 11:08:53 +0000 (UTC) Christophe Leroy <christophe.leroy@csgroup.eu> wrote:
> 
>> When PUD and/or PMD are folded, those functions are useless
>> and we now have a stub in linux/pgtable.h
> 
> OK, help me out here please.  What patch does this fix?
> 

Both this one and the x86 one from the day before fix 1cff41494b15cd82c1ec418bb5c ("mm/pgtable: add 
stubs for {pmd/pub}_{set/clear}_huge")

I think both the x86 fix and the arm64 fix should be squashed into that patch at the end.

I checked, the only other architecture involving pud_set_huge() and friends is powerpc, and powerpc 
doesn't have this problem as it only defined those for book3s/64 platforms which have 4 level page 
tables by definition.

Thanks
Christophe

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-05-15  6:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14 11:08 [PATCH] arm64: Define only {pud/pmd}_{set/clear}_huge when usefull Christophe Leroy
2021-05-14 11:08 ` Christophe Leroy
2021-05-14 11:08 ` Christophe Leroy
2021-05-14 21:42 ` Andrew Morton
2021-05-14 21:42   ` Andrew Morton
2021-05-14 21:42   ` Andrew Morton
2021-05-15  3:58   ` Nathan Chancellor
2021-05-15  3:58     ` Nathan Chancellor
2021-05-15  3:58     ` Nathan Chancellor
2021-05-15  6:28   ` Christophe Leroy [this message]
2021-05-15  6:28     ` Christophe Leroy
2021-05-15  6:28     ` Christophe Leroy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae1be8a1-8412-1288-31d4-23dc2cf4e5e7@csgroup.eu \
    --to=christophe.leroy@csgroup.eu \
    --cc=akpm@linux-foundation.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mike.kravetz@oracle.com \
    --cc=naresh.kamboju@linaro.org \
    --cc=npiggin@gmail.com \
    --cc=rppt@kernel.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.