All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Sudeep Holla <sudeep.holla@arm.com>, Lukasz Luba <lukasz.luba@arm.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
	cristian.marussi@arm.com, rjw@rjwysocki.net
Subject: Re: [PATCH 0/4] CPUFreq statistics retrieved by drivers
Date: Tue, 4 Aug 2020 10:19:23 -0700	[thread overview]
Message-ID: <ae352c39-f7c4-c69e-0113-7c810c130ee0@gmail.com> (raw)
In-Reply-To: <20200731155650.GC14529@bogus>



On 7/31/2020 8:56 AM, Sudeep Holla wrote:
> On Thu, Jul 30, 2020 at 10:36:51AM +0100, Lukasz Luba wrote:
>>
>> In this case I think we would have to create debugfs.
>> Sudeep do you think these debugfs should be exposed from the protocol
>> layer:
>> drivers/firmware/arm_scmi/perf.c
> 
> I prefer above over cpufreq as we can support for all the devices not
> just cpus which avoids adding similar support elsewhere(mostly devfreq)
> 
>> or maybe from the cpufreq scmi driver? I would probably be safer to have
>> it in the cpufreq driver because we have scmi_handle there.
>>
> 
> Cristian was thinking if we can consolidate all such debugfs under one
> device may be and that should eliminate your handle restriction. I would
> like to see how that works out in implementation but I don't have any 
> better suggestion ATM.

debugfs is not enabled in production kernels, and especially not with
Android kernels, so sticking those in sysfs like the existing cpufreq
subsystem statistics may be a better choice.
-- 
Florian

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Sudeep Holla <sudeep.holla@arm.com>, Lukasz Luba <lukasz.luba@arm.com>
Cc: linux-pm@vger.kernel.org, Viresh Kumar <viresh.kumar@linaro.org>,
	rjw@rjwysocki.net, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, cristian.marussi@arm.com
Subject: Re: [PATCH 0/4] CPUFreq statistics retrieved by drivers
Date: Tue, 4 Aug 2020 10:19:23 -0700	[thread overview]
Message-ID: <ae352c39-f7c4-c69e-0113-7c810c130ee0@gmail.com> (raw)
In-Reply-To: <20200731155650.GC14529@bogus>



On 7/31/2020 8:56 AM, Sudeep Holla wrote:
> On Thu, Jul 30, 2020 at 10:36:51AM +0100, Lukasz Luba wrote:
>>
>> In this case I think we would have to create debugfs.
>> Sudeep do you think these debugfs should be exposed from the protocol
>> layer:
>> drivers/firmware/arm_scmi/perf.c
> 
> I prefer above over cpufreq as we can support for all the devices not
> just cpus which avoids adding similar support elsewhere(mostly devfreq)
> 
>> or maybe from the cpufreq scmi driver? I would probably be safer to have
>> it in the cpufreq driver because we have scmi_handle there.
>>
> 
> Cristian was thinking if we can consolidate all such debugfs under one
> device may be and that should eliminate your handle restriction. I would
> like to see how that works out in implementation but I don't have any 
> better suggestion ATM.

debugfs is not enabled in production kernels, and especially not with
Android kernels, so sticking those in sysfs like the existing cpufreq
subsystem statistics may be a better choice.
-- 
Florian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-08-04 17:19 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-29 15:12 [PATCH 0/4] CPUFreq statistics retrieved by drivers Lukasz Luba
2020-07-29 15:12 ` Lukasz Luba
2020-07-29 15:12 ` [PATCH 1/4] cpufreq: Add support for statistics read from drivers Lukasz Luba
2020-07-29 15:12   ` Lukasz Luba
2020-07-29 15:12 ` [PATCH 2/4] scmi: perf: Extend protocol to support performance statistics Lukasz Luba
2020-07-29 15:12   ` Lukasz Luba
2020-07-31  1:50   ` kernel test robot
2020-07-31  1:50     ` kernel test robot
2020-07-31  1:50     ` kernel test robot
2020-07-31 15:15   ` Cristian Marussi
2020-07-31 15:15     ` Cristian Marussi
2020-08-04 11:10     ` Lukasz Luba
2020-08-04 11:10       ` Lukasz Luba
2020-07-29 15:12 ` [PATCH 3/4] cpufreq: scmi: Move scmi_cpufreq_driver structure to the top Lukasz Luba
2020-07-29 15:12   ` Lukasz Luba
2020-07-29 15:12 ` [PATCH 4/4] cpufreq: scmi: Read statistics from FW shared memory Lukasz Luba
2020-07-29 15:12   ` Lukasz Luba
2020-07-30  8:53 ` [PATCH 0/4] CPUFreq statistics retrieved by drivers Viresh Kumar
2020-07-30  8:53   ` Viresh Kumar
2020-07-30  9:10   ` Sudeep Holla
2020-07-30  9:10     ` Sudeep Holla
2020-07-30  9:36     ` Lukasz Luba
2020-07-30  9:36       ` Lukasz Luba
2020-07-31 15:56       ` Sudeep Holla
2020-07-31 15:56         ` Sudeep Holla
2020-08-04 17:19         ` Florian Fainelli [this message]
2020-08-04 17:19           ` Florian Fainelli
2020-08-05 12:36           ` Sudeep Holla
2020-08-05 12:36             ` Sudeep Holla
2020-08-04  5:35       ` Viresh Kumar
2020-08-04  5:35         ` Viresh Kumar
2020-08-04 10:29         ` Lukasz Luba
2020-08-04 10:29           ` Lukasz Luba
2020-08-04 10:38           ` Viresh Kumar
2020-08-04 10:38             ` Viresh Kumar
2020-08-04 10:44             ` Lukasz Luba
2020-08-04 10:44               ` Lukasz Luba
2020-09-02  7:26               ` Viresh Kumar
2020-09-02  7:26                 ` Viresh Kumar
2020-08-04 17:27 ` Florian Fainelli
2020-08-04 17:27   ` Florian Fainelli
2020-08-05 11:04   ` Lukasz Luba
2020-08-05 11:04     ` Lukasz Luba
2020-08-05 13:04     ` Viresh Kumar
2020-08-05 13:04       ` Viresh Kumar
2020-08-05 16:03       ` Sudeep Holla
2020-08-05 16:03         ` Sudeep Holla
2020-08-05 17:33         ` Florian Fainelli
2020-08-05 17:33           ` Florian Fainelli
2020-08-06 13:37           ` Sudeep Holla
2020-08-06 13:37             ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae352c39-f7c4-c69e-0113-7c810c130ee0@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=cristian.marussi@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=rjw@rjwysocki.net \
    --cc=sudeep.holla@arm.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.