All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH] mtd: core: handle flashes without OTP gracefully
Date: Fri, 02 Jul 2021 15:53:49 +0200	[thread overview]
Message-ID: <ae770937ec2ddf12b294fbee3d815dd4@walle.cc> (raw)
In-Reply-To: <499cf369-c98a-ac48-dfe6-6903314e9606@roeck-us.net>

Am 2021-07-02 15:49, schrieb Guenter Roeck:
> On 7/2/21 2:38 AM, Michael Walle wrote:
>> There are flash drivers which registers the OTP callbacks although the
>> flash doesn't support OTP regions and return -ENODATA for these
>> callbacks if there is no OTP. If this happens, the probe of the whole
>> flash will fail. Fix it by handling the ENODATA return code and skip
>> the OTP region nvmem setup.
>> 
>> Fixes: 4b361cfa8624 ("mtd: core: add OTP nvmem provider support")
>> Reported-by: Guenter Roeck <linux@roeck-us.net>
>> Signed-off-by: Michael Walle <michael@walle.cc>
> 
> Tested-by: Guenter Roeck <linux@roeck-us.net>

Thanks for confirming, and sorry for the inconvenience.

-michael

WARNING: multiple messages have this Message-ID (diff)
From: Michael Walle <michael@walle.cc>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH] mtd: core: handle flashes without OTP gracefully
Date: Fri, 02 Jul 2021 15:53:49 +0200	[thread overview]
Message-ID: <ae770937ec2ddf12b294fbee3d815dd4@walle.cc> (raw)
In-Reply-To: <499cf369-c98a-ac48-dfe6-6903314e9606@roeck-us.net>

Am 2021-07-02 15:49, schrieb Guenter Roeck:
> On 7/2/21 2:38 AM, Michael Walle wrote:
>> There are flash drivers which registers the OTP callbacks although the
>> flash doesn't support OTP regions and return -ENODATA for these
>> callbacks if there is no OTP. If this happens, the probe of the whole
>> flash will fail. Fix it by handling the ENODATA return code and skip
>> the OTP region nvmem setup.
>> 
>> Fixes: 4b361cfa8624 ("mtd: core: add OTP nvmem provider support")
>> Reported-by: Guenter Roeck <linux@roeck-us.net>
>> Signed-off-by: Michael Walle <michael@walle.cc>
> 
> Tested-by: Guenter Roeck <linux@roeck-us.net>

Thanks for confirming, and sorry for the inconvenience.

-michael

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2021-07-02 13:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-02  9:38 [PATCH] mtd: core: handle flashes without OTP gracefully Michael Walle
2021-07-02  9:38 ` Michael Walle
2021-07-02 13:49 ` Guenter Roeck
2021-07-02 13:49   ` Guenter Roeck
2021-07-02 13:53   ` Michael Walle [this message]
2021-07-02 13:53     ` Michael Walle
2021-07-03  9:56 ` Tudor.Ambarus
2021-07-03  9:56   ` Tudor.Ambarus
2021-07-03 16:08   ` Michael Walle
2021-07-03 16:08     ` Michael Walle
2021-07-03 16:42     ` Tudor.Ambarus
2021-07-03 16:42       ` Tudor.Ambarus
2021-07-03 17:26       ` Guenter Roeck
2021-07-03 17:26         ` Guenter Roeck
2021-07-06 16:29         ` Miquel Raynal
2021-07-06 16:29           ` Miquel Raynal
2021-07-06 18:22           ` Guenter Roeck
2021-07-06 18:22             ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae770937ec2ddf12b294fbee3d815dd4@walle.cc \
    --to=michael@walle.cc \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux@roeck-us.net \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.