From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>, <xinlei.lee@mediatek.com>,
<chunkuang.hu@kernel.org>, <p.zabel@pengutronix.de>,
<airlied@linux.ie>, <daniel@ffwll.ch>, <robh+dt@kernel.org>,
<matthias.bgg@gmail.com>
Cc: <dri-devel@lists.freedesktop.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
<jitao.shi@mediatek.com>
Subject: Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
Date: Wed, 6 Apr 2022 15:08:58 +0800 [thread overview]
Message-ID: <ae8ba0030d42d078580233f1710c592992e7d778.camel@mediatek.com> (raw)
In-Reply-To: <4940e2e4ecb5f9f6857dc960ea5dbe43c551df77.camel@mediatek.com>
On Wed, 2022-04-06 at 14:38 +0800, CK Hu wrote:
> Hi,
>
> On Fri, 2022-04-01 at 09:38 +0800, Rex-BC Chen wrote:
> > On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > > From: Xinlei Lee <xinlei.lee@mediatek.com>
> > >
> > > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> > >
> > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > > ---
> > > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> > > |
> > > 1
> > > +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > index dd2896a40ff0..a73044c50b5f 100644
> > > ---
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > +++
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > @@ -22,6 +22,7 @@ properties:
> > > - mediatek,mt7623-dpi
> > > - mediatek,mt8173-dpi
> > > - mediatek,mt8183-dpi
> > > + - mediatek,mt8186-dpi
> > > - mediatek,mt8192-dpi
> > >
> > > reg:
> >
> > Hello Xinlei,
> >
> > From the dts we use, the dpi node needs other properties for
> > MT8186.
> > Please send another patch and add these properties to binding.
> >
> > assigned-clocks = <&topckgen CLK_TOP_DPI>;
> > assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
>
> According to [1], the assigned-clocks is initial value. Without this
> initial value, I think driver would set this clock again, wouldn't
> it?
>
> [1]
>
https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bindings.txt
>
> Regards,
> CK
>
Hello CK,
OK, Thanks for your explanation.
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
BRs,
Rex
> >
> > Thanks
> >
> > BRs,
> > Rex
> >
> >
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> >
>
>
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!wtF15QZZTCzWfRpxNLjZ1VQQ54i40D8STuOo0h18dtz3es-ksLfYQGTEFlb7lg$
> >
>
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>, <xinlei.lee@mediatek.com>,
<chunkuang.hu@kernel.org>, <p.zabel@pengutronix.de>,
<airlied@linux.ie>, <daniel@ffwll.ch>, <robh+dt@kernel.org>,
<matthias.bgg@gmail.com>
Cc: devicetree@vger.kernel.org, jitao.shi@mediatek.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
Date: Wed, 6 Apr 2022 15:08:58 +0800 [thread overview]
Message-ID: <ae8ba0030d42d078580233f1710c592992e7d778.camel@mediatek.com> (raw)
In-Reply-To: <4940e2e4ecb5f9f6857dc960ea5dbe43c551df77.camel@mediatek.com>
On Wed, 2022-04-06 at 14:38 +0800, CK Hu wrote:
> Hi,
>
> On Fri, 2022-04-01 at 09:38 +0800, Rex-BC Chen wrote:
> > On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > > From: Xinlei Lee <xinlei.lee@mediatek.com>
> > >
> > > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> > >
> > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > > ---
> > > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> > > |
> > > 1
> > > +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > index dd2896a40ff0..a73044c50b5f 100644
> > > ---
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > +++
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > @@ -22,6 +22,7 @@ properties:
> > > - mediatek,mt7623-dpi
> > > - mediatek,mt8173-dpi
> > > - mediatek,mt8183-dpi
> > > + - mediatek,mt8186-dpi
> > > - mediatek,mt8192-dpi
> > >
> > > reg:
> >
> > Hello Xinlei,
> >
> > From the dts we use, the dpi node needs other properties for
> > MT8186.
> > Please send another patch and add these properties to binding.
> >
> > assigned-clocks = <&topckgen CLK_TOP_DPI>;
> > assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
>
> According to [1], the assigned-clocks is initial value. Without this
> initial value, I think driver would set this clock again, wouldn't
> it?
>
> [1]
>
https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bindings.txt
>
> Regards,
> CK
>
Hello CK,
OK, Thanks for your explanation.
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
BRs,
Rex
> >
> > Thanks
> >
> > BRs,
> > Rex
> >
> >
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> >
>
>
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!wtF15QZZTCzWfRpxNLjZ1VQQ54i40D8STuOo0h18dtz3es-ksLfYQGTEFlb7lg$
> >
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>, <xinlei.lee@mediatek.com>,
<chunkuang.hu@kernel.org>, <p.zabel@pengutronix.de>,
<airlied@linux.ie>, <daniel@ffwll.ch>, <robh+dt@kernel.org>,
<matthias.bgg@gmail.com>
Cc: <dri-devel@lists.freedesktop.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
<jitao.shi@mediatek.com>
Subject: Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
Date: Wed, 6 Apr 2022 15:08:58 +0800 [thread overview]
Message-ID: <ae8ba0030d42d078580233f1710c592992e7d778.camel@mediatek.com> (raw)
In-Reply-To: <4940e2e4ecb5f9f6857dc960ea5dbe43c551df77.camel@mediatek.com>
On Wed, 2022-04-06 at 14:38 +0800, CK Hu wrote:
> Hi,
>
> On Fri, 2022-04-01 at 09:38 +0800, Rex-BC Chen wrote:
> > On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > > From: Xinlei Lee <xinlei.lee@mediatek.com>
> > >
> > > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> > >
> > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > > ---
> > > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> > > |
> > > 1
> > > +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > index dd2896a40ff0..a73044c50b5f 100644
> > > ---
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > +++
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > @@ -22,6 +22,7 @@ properties:
> > > - mediatek,mt7623-dpi
> > > - mediatek,mt8173-dpi
> > > - mediatek,mt8183-dpi
> > > + - mediatek,mt8186-dpi
> > > - mediatek,mt8192-dpi
> > >
> > > reg:
> >
> > Hello Xinlei,
> >
> > From the dts we use, the dpi node needs other properties for
> > MT8186.
> > Please send another patch and add these properties to binding.
> >
> > assigned-clocks = <&topckgen CLK_TOP_DPI>;
> > assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
>
> According to [1], the assigned-clocks is initial value. Without this
> initial value, I think driver would set this clock again, wouldn't
> it?
>
> [1]
>
https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bindings.txt
>
> Regards,
> CK
>
Hello CK,
OK, Thanks for your explanation.
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
BRs,
Rex
> >
> > Thanks
> >
> > BRs,
> > Rex
> >
> >
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> >
>
>
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!wtF15QZZTCzWfRpxNLjZ1VQQ54i40D8STuOo0h18dtz3es-ksLfYQGTEFlb7lg$
> >
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>, <xinlei.lee@mediatek.com>,
<chunkuang.hu@kernel.org>, <p.zabel@pengutronix.de>,
<airlied@linux.ie>, <daniel@ffwll.ch>, <robh+dt@kernel.org>,
<matthias.bgg@gmail.com>
Cc: <dri-devel@lists.freedesktop.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
<jitao.shi@mediatek.com>
Subject: Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
Date: Wed, 6 Apr 2022 15:08:58 +0800 [thread overview]
Message-ID: <ae8ba0030d42d078580233f1710c592992e7d778.camel@mediatek.com> (raw)
In-Reply-To: <4940e2e4ecb5f9f6857dc960ea5dbe43c551df77.camel@mediatek.com>
On Wed, 2022-04-06 at 14:38 +0800, CK Hu wrote:
> Hi,
>
> On Fri, 2022-04-01 at 09:38 +0800, Rex-BC Chen wrote:
> > On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > > From: Xinlei Lee <xinlei.lee@mediatek.com>
> > >
> > > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> > >
> > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > > ---
> > > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> > > |
> > > 1
> > > +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > index dd2896a40ff0..a73044c50b5f 100644
> > > ---
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > +++
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > @@ -22,6 +22,7 @@ properties:
> > > - mediatek,mt7623-dpi
> > > - mediatek,mt8173-dpi
> > > - mediatek,mt8183-dpi
> > > + - mediatek,mt8186-dpi
> > > - mediatek,mt8192-dpi
> > >
> > > reg:
> >
> > Hello Xinlei,
> >
> > From the dts we use, the dpi node needs other properties for
> > MT8186.
> > Please send another patch and add these properties to binding.
> >
> > assigned-clocks = <&topckgen CLK_TOP_DPI>;
> > assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
>
> According to [1], the assigned-clocks is initial value. Without this
> initial value, I think driver would set this clock again, wouldn't
> it?
>
> [1]
>
https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bindings.txt
>
> Regards,
> CK
>
Hello CK,
OK, Thanks for your explanation.
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
BRs,
Rex
> >
> > Thanks
> >
> > BRs,
> > Rex
> >
> >
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> >
>
>
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!wtF15QZZTCzWfRpxNLjZ1VQQ54i40D8STuOo0h18dtz3es-ksLfYQGTEFlb7lg$
> >
>
>
next prev parent reply other threads:[~2022-04-06 7:09 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 11:58 [PATCH v2,0/2] Add mt8186 dpi compatiable xinlei.lee
2022-03-31 11:58 ` xinlei.lee
2022-03-31 11:58 ` xinlei.lee
2022-03-31 11:58 ` xinlei.lee
2022-03-31 11:58 ` [PATCH v2, 1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186 xinlei.lee
2022-03-31 11:58 ` xinlei.lee
2022-03-31 11:58 ` xinlei.lee
2022-03-31 11:58 ` [PATCH v2,1/2] " xinlei.lee
2022-04-01 1:38 ` Rex-BC Chen
2022-04-01 1:38 ` Rex-BC Chen
2022-04-01 1:38 ` Rex-BC Chen
2022-04-01 1:38 ` Rex-BC Chen
2022-04-06 6:38 ` CK Hu
2022-04-06 6:38 ` CK Hu
2022-04-06 6:38 ` CK Hu
2022-04-06 6:38 ` CK Hu
2022-04-06 7:08 ` Rex-BC Chen [this message]
2022-04-06 7:08 ` Rex-BC Chen
2022-04-06 7:08 ` Rex-BC Chen
2022-04-06 7:08 ` Rex-BC Chen
2022-04-06 15:15 ` Rob Herring
2022-04-06 15:15 ` Rob Herring
2022-04-06 15:15 ` Rob Herring
2022-04-06 15:15 ` Rob Herring
2022-04-07 2:12 ` xinlei.lee
2022-04-07 2:12 ` xinlei.lee
2022-04-07 2:12 ` xinlei.lee
2022-04-06 15:15 ` Rob Herring
2022-04-06 15:15 ` Rob Herring
2022-04-06 15:15 ` Rob Herring
2022-04-06 15:15 ` Rob Herring
2022-03-31 11:58 ` [PATCH v2,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c xinlei.lee
2022-03-31 11:58 ` xinlei.lee
2022-03-31 11:58 ` xinlei.lee
2022-03-31 11:58 ` xinlei.lee
2022-04-06 7:13 ` Rex-BC Chen
2022-04-06 7:13 ` Rex-BC Chen
2022-04-06 7:13 ` Rex-BC Chen
2022-04-06 7:13 ` Rex-BC Chen
2022-04-06 13:44 ` xinlei.lee
2022-04-06 13:44 ` xinlei.lee
2022-04-06 13:44 ` xinlei.lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae8ba0030d42d078580233f1710c592992e7d778.camel@mediatek.com \
--to=rex-bc.chen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jitao.shi@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=xinlei.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.