From: Darren Hart <dvhart@linux.intel.com> To: Poky <poky@yoctoproject.org>, openembedded-core@lists.openembedded.org, Richard Purdie <richard.purdie@linuxfoundation.org> Cc: bitbake-devel@lists.openembedded.org Subject: [PATCH 3/8] bitbake: fetch2: Remove broken git variables from the environment Date: Tue, 5 Feb 2013 02:31:39 -0800 [thread overview] Message-ID: <ae9006152f5551b3eb019c8d639625d5f32e1366.1360059615.git.dvhart@linux.intel.com> (raw) In-Reply-To: <cover.1360059615.git.dvhart@linux.intel.com> In-Reply-To: <cover.1360059615.git.dvhart@linux.intel.com> The following variables perform no function outside of bitbake: GIT_CONFIG GIT_PROXY_HOST GIT_PROXY_PORT GIT_PROXY_IGNORE GIT_CONFIG only affects the git-config command which is not relevant to the fetcher. This was previously used with the OE GIT_CORE_CONFIG variable which would provide a basic git config to use instead of the user's config. This usage was deprecated by git for over a year now: http://git.661346.n2.nabble.com/Overriding-gitconfig-using-GIT-CONFIG-td6680977.html GIT_PROXY_HOST and GIT_PROXY_PORT are not used by git. GIT_PROXY_IGNORE was an OE construct used to create the custom git config and had no meaning outside of the OE environment. It is not used by git. Remove these variables from the fetcher environment. Users wishing to configure git to work with a proxy should define the GIT_PROXY_COMMAND environment variable to use an external script. NO_PROXY can be used within this script to skip the proxy for certain hosts. Signed-off-by: Darren Hart <dvhart@linux.intel.com> Cc: bitbake-devel@lists.openembedded.org --- bitbake/lib/bb/fetch2/__init__.py | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/bitbake/lib/bb/fetch2/__init__.py b/bitbake/lib/bb/fetch2/__init__.py index 7466a38..21f576e 100644 --- a/bitbake/lib/bb/fetch2/__init__.py +++ b/bitbake/lib/bb/fetch2/__init__.py @@ -458,16 +458,16 @@ def runfetchcmd(cmd, d, quiet = False, cleanup = []): # rather than host provided # Also include some other variables. # FIXME: Should really include all export varaiables? - exportvars = ['PATH', 'GIT_PROXY_COMMAND', 'GIT_PROXY_HOST', - 'GIT_PROXY_PORT', 'GIT_CONFIG', + exportvars = ['HOME', 'PATH', 'HTTP_PROXY', 'http_proxy', 'HTTPS_PROXY', 'https_proxy', 'FTP_PROXY', 'ftp_proxy', 'FTPS_PROXY', 'ftps_proxy', 'NO_PROXY', 'no_proxy', 'ALL_PROXY', 'all_proxy', - 'SSH_AUTH_SOCK', 'SSH_AGENT_PID', 'HOME', - 'GIT_PROXY_IGNORE', 'SOCKS5_USER', 'SOCKS5_PASSWD'] + 'GIT_PROXY_COMMAND', + 'SSH_AUTH_SOCK', 'SSH_AGENT_PID', + 'SOCKS5_USER', 'SOCKS5_PASSWD'] for var in exportvars: val = d.getVar(var, True) -- 1.7.5.4
WARNING: multiple messages have this Message-ID (diff)
From: Darren Hart <dvhart@linux.intel.com> To: Poky <poky@yoctoproject.org>, openembedded-core@lists.openembedded.org, Richard Purdie <richard.purdie@linuxfoundation.org> Cc: Darren Hart <dvhart@linux.intel.com>, bitbake-devel@lists.openembedded.org Subject: [PATCH 3/8] bitbake: fetch2: Remove broken git variables from the environment Date: Tue, 5 Feb 2013 02:31:39 -0800 [thread overview] Message-ID: <ae9006152f5551b3eb019c8d639625d5f32e1366.1360059615.git.dvhart@linux.intel.com> (raw) In-Reply-To: <cover.1360059615.git.dvhart@linux.intel.com> In-Reply-To: <cover.1360059615.git.dvhart@linux.intel.com> The following variables perform no function outside of bitbake: GIT_CONFIG GIT_PROXY_HOST GIT_PROXY_PORT GIT_PROXY_IGNORE GIT_CONFIG only affects the git-config command which is not relevant to the fetcher. This was previously used with the OE GIT_CORE_CONFIG variable which would provide a basic git config to use instead of the user's config. This usage was deprecated by git for over a year now: http://git.661346.n2.nabble.com/Overriding-gitconfig-using-GIT-CONFIG-td6680977.html GIT_PROXY_HOST and GIT_PROXY_PORT are not used by git. GIT_PROXY_IGNORE was an OE construct used to create the custom git config and had no meaning outside of the OE environment. It is not used by git. Remove these variables from the fetcher environment. Users wishing to configure git to work with a proxy should define the GIT_PROXY_COMMAND environment variable to use an external script. NO_PROXY can be used within this script to skip the proxy for certain hosts. Signed-off-by: Darren Hart <dvhart@linux.intel.com> Cc: bitbake-devel@lists.openembedded.org --- bitbake/lib/bb/fetch2/__init__.py | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/bitbake/lib/bb/fetch2/__init__.py b/bitbake/lib/bb/fetch2/__init__.py index 7466a38..21f576e 100644 --- a/bitbake/lib/bb/fetch2/__init__.py +++ b/bitbake/lib/bb/fetch2/__init__.py @@ -458,16 +458,16 @@ def runfetchcmd(cmd, d, quiet = False, cleanup = []): # rather than host provided # Also include some other variables. # FIXME: Should really include all export varaiables? - exportvars = ['PATH', 'GIT_PROXY_COMMAND', 'GIT_PROXY_HOST', - 'GIT_PROXY_PORT', 'GIT_CONFIG', + exportvars = ['HOME', 'PATH', 'HTTP_PROXY', 'http_proxy', 'HTTPS_PROXY', 'https_proxy', 'FTP_PROXY', 'ftp_proxy', 'FTPS_PROXY', 'ftps_proxy', 'NO_PROXY', 'no_proxy', 'ALL_PROXY', 'all_proxy', - 'SSH_AUTH_SOCK', 'SSH_AGENT_PID', 'HOME', - 'GIT_PROXY_IGNORE', 'SOCKS5_USER', 'SOCKS5_PASSWD'] + 'GIT_PROXY_COMMAND', + 'SSH_AUTH_SOCK', 'SSH_AGENT_PID', + 'SOCKS5_USER', 'SOCKS5_PASSWD'] for var in exportvars: val = d.getVar(var, True) -- 1.7.5.4
next prev parent reply other threads:[~2013-02-05 10:47 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-02-05 10:31 [PATCH 0/8] Git fetcher and proxy handling updates Darren Hart 2013-02-05 10:31 ` [PATCH 1/8] bitbake: fetch2: Print the complete SRCREV variable name when INVALID Darren Hart 2013-02-05 10:31 ` Darren Hart 2013-02-05 10:31 ` [PATCH 2/8] bitbake: fetch2: Export upper and lower case environment variables Darren Hart 2013-02-05 10:31 ` Darren Hart 2013-02-05 10:31 ` Darren Hart [this message] 2013-02-05 10:31 ` [PATCH 3/8] bitbake: fetch2: Remove broken git variables from the environment Darren Hart 2013-02-05 10:31 ` [PATCH 4/8] oe-buildenv-internal: Remove GIT variables from BB_ENV_EXTRAWHITE Darren Hart 2013-02-05 10:31 ` [PATCH 5/8] oe-buildenv-internal: Add upper and lower case proxy vars to BB_ENV_EXTRAWHITE Darren Hart 2013-02-05 10:31 ` [PATCH 6/8] base.bbclass: Remove generate_git_config() Darren Hart 2013-02-05 10:31 ` [PATCH 7/8] oe-git-proxy.sh: Add a new comprehensive git proxy script Darren Hart 2013-02-05 11:16 ` Enrico Scholz 2013-02-05 16:20 ` Darren Hart 2013-02-05 16:36 ` Enrico Scholz 2013-02-05 17:44 ` Darren Hart 2013-02-05 18:40 ` Otavio Salvador 2013-02-05 18:50 ` Darren Hart 2013-02-05 19:08 ` Enrico Scholz 2013-02-05 19:18 ` Darren Hart 2013-02-05 19:29 ` Otavio Salvador 2013-02-05 22:10 ` Richard Purdie 2013-02-05 10:31 ` [PATCH 8/8] git proxy: Document usage of oe-git-proxy.sh and remove alternatives Darren Hart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ae9006152f5551b3eb019c8d639625d5f32e1366.1360059615.git.dvhart@linux.intel.com \ --to=dvhart@linux.intel.com \ --cc=bitbake-devel@lists.openembedded.org \ --cc=openembedded-core@lists.openembedded.org \ --cc=poky@yoctoproject.org \ --cc=richard.purdie@linuxfoundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.