All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Raslan Darawsheh <rasland@mellanox.com>,
	"keith.wiles@intel.com" <keith.wiles@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
	"dev@dpdk.org" <dev@dpdk.org>,
	Shahaf Shuler <shahafs@mellanox.com>,
	Ori Kam <orika@mellanox.com>,
	Alejandro Lucero <alejandro.lucero@netronome.com>
Subject: Re: [PATCH v6 2/3] net/tap: move fds of Rx/Tx queues to be in process private
Date: Thu, 11 Oct 2018 17:19:34 +0100	[thread overview]
Message-ID: <aea08681-1cb7-e2db-a862-0478f9d135e5@intel.com> (raw)
In-Reply-To: <1539182356-15496-2-git-send-email-rasland@mellanox.com>

On 10/10/2018 3:39 PM, Raslan Darawsheh wrote:
> fd's cannot be shared between processes, and each process need to have
> it's own fd's pointer.
> 
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> ---
>  drivers/net/tap/rte_eth_tap.c | 93 +++++++++++++++++++++++++++++--------------
>  drivers/net/tap/rte_eth_tap.h |  7 +++-
>  drivers/net/tap/tap_flow.c    |  3 +-
>  drivers/net/tap/tap_intr.c    |  5 ++-
>  4 files changed, 73 insertions(+), 35 deletions(-)
> 
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index edfb7da..3372d54 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -315,6 +315,7 @@ static uint16_t
>  pmd_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
>  {
>  	struct rx_queue *rxq = queue;
> +	struct pmd_process_private *process_private;
>  	uint16_t num_rx;
>  	unsigned long num_rx_bytes = 0;
>  	uint32_t trigger = tap_trigger;
> @@ -323,6 +324,7 @@ pmd_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
>  		return 0;
>  	if (trigger)
>  		rxq->trigger_seen = trigger;
> +	process_private = rte_eth_devices[rxq->in_port].process_private;

This patch has a dependency to [1] which is waiting for new version, right?
Please note these kind of dependencies after "---" part of the commit log.

[1]
https://patches.dpdk.org/patch/46185/

  reply	other threads:[~2018-10-11 16:19 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10 14:39 [PATCH v6 1/3] net/tap: add queue and port ids in Rx/Tx queues structures Raslan Darawsheh
2018-10-10 14:39 ` [PATCH v6 2/3] net/tap: move fds of Rx/Tx queues to be in process private Raslan Darawsheh
2018-10-11 16:19   ` Ferruh Yigit [this message]
2018-10-16 10:07     ` Raslan Darawsheh
2018-10-16 11:24       ` Ferruh Yigit
2018-10-17  8:56   ` [PATCH v7 1/3] net/tap: add queue and port ids in Rx/Tx queues structures Raslan Darawsheh
2018-10-17  8:56     ` [PATCH v7 2/3] net/tap: move fds of Rx/Tx queues to be in process private Raslan Darawsheh
2018-10-17  8:56     ` [PATCH v7 3/3] net/tap: allow secondary process to access primary device queues Raslan Darawsheh
2018-10-17 12:06       ` Ferruh Yigit
2018-10-17 14:46         ` Raslan Darawsheh
2018-10-17 14:45   ` [PATCH v8 1/3] net/tap: add queue and port ids in Rx/Tx queues structures Raslan Darawsheh
2018-10-17 14:45     ` [PATCH v8 2/3] net/tap: move fds of Rx/Tx queues to be in process private Raslan Darawsheh
2018-10-17 14:45     ` [PATCH v8 3/3] net/tap: allow secondary process to access primary device queues Raslan Darawsheh
2018-10-17 16:02       ` Ferruh Yigit
2018-10-18  8:11         ` Raslan Darawsheh
2018-10-18  8:15   ` [PATCH v9 1/3] net/tap: add queue and port ids in Rx/Tx queues structures Raslan Darawsheh
2018-10-18  8:15     ` [PATCH v9 2/3] net/tap: move fds of Rx/Tx queues to be in process private Raslan Darawsheh
2018-10-18  8:15     ` [PATCH v9 3/3] net/tap: allow secondary process to access primary device queues Raslan Darawsheh
2018-10-18 10:09       ` Ferruh Yigit
2018-10-18 10:17   ` [PATCH v10 1/3] net/tap: add queue and port ids in Rx/Tx queues structures Raslan Darawsheh
2018-10-18 10:17     ` [PATCH v10 2/3] net/tap: move fds of Rx/Tx queues to be in process private Raslan Darawsheh
2018-10-18 10:17     ` [PATCH v10 3/3] net/tap: allow secondary process to access primary device queues Raslan Darawsheh
2018-10-18 11:22     ` [PATCH v10 1/3] net/tap: add queue and port ids in Rx/Tx queues structures Ferruh Yigit
2018-10-18 12:56     ` Ferruh Yigit
2018-10-10 14:39 ` [PATCH v6 3/3] net/tap: allow secondary process to access primary device queues Raslan Darawsheh
2018-10-11 16:32   ` Ferruh Yigit
2018-10-16 10:06     ` Raslan Darawsheh
2018-10-16 11:27       ` Ferruh Yigit
2018-10-17  6:54         ` Raslan Darawsheh
2018-10-17  7:59           ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aea08681-1cb7-e2db-a862-0478f9d135e5@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=alejandro.lucero@netronome.com \
    --cc=dev@dpdk.org \
    --cc=keith.wiles@intel.com \
    --cc=orika@mellanox.com \
    --cc=rasland@mellanox.com \
    --cc=shahafs@mellanox.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.