All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Tinghan Shen <tinghan.shen@mediatek.com>,
	Chaotian Jing <chaotian.jing@mediatek.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	Wenbin Mei <wenbin.mei@mediatek.com>
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com,
	ryder.lee@kernel.org, wenst@chromium.org,
	chunfeng.yun@mediatek.com
Subject: Re: [PATCH v13 1/2] dt-bindings: mmc: mtk-sd: increase reg items
Date: Thu, 31 Mar 2022 12:54:16 +0200	[thread overview]
Message-ID: <aebbb5c8-1d27-5e66-e18a-e2b647bc8cb4@gmail.com> (raw)
In-Reply-To: <20220330094532.21721-2-tinghan.shen@mediatek.com>



On 30/03/2022 11:45, Tinghan Shen wrote:
> MediaTek has a new version of mmc IP since mt8183. Some IO registers
> are moved to top to improve hardware design and named as "host top
> registers".
> 
> Add host top register in the reg binding description for mt8183 and
> successors.
> 
> Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
>   Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 15 ++++++++++++++-
>   1 file changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> index 297ada03e3de..2a2e9fa8c188 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> @@ -40,7 +40,10 @@ properties:
>             - const: mediatek,mt8183-mmc
>   
>     reg:
> -    maxItems: 1
> +    minItems: 1

 From my understanding adding minItems is correct, but you need to add also 
maxItems: 2 as there can't be more then two register entries.

Regards,
Matthias

> +    items:
> +      - description: base register (required).
> +      - description: top base register (required for MT8183).
>   
>     clocks:
>       description:
> @@ -168,6 +171,16 @@ required:
>     - vmmc-supply
>     - vqmmc-supply
>   
> +if:
> +  properties:
> +    compatible:
> +      contains:
> +        const: mediatek,mt8183-mmc
> +then:
> +  properties:
> +    reg:
> +      minItems: 2
> +
>   unevaluatedProperties: false
>   
>   examples:

WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Tinghan Shen <tinghan.shen@mediatek.com>,
	Chaotian Jing <chaotian.jing@mediatek.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Wenbin Mei <wenbin.mei@mediatek.com>
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com,
	ryder.lee@kernel.org, wenst@chromium.org,
	chunfeng.yun@mediatek.com
Subject: Re: [PATCH v13 1/2] dt-bindings: mmc: mtk-sd: increase reg items
Date: Thu, 31 Mar 2022 12:54:16 +0200	[thread overview]
Message-ID: <aebbb5c8-1d27-5e66-e18a-e2b647bc8cb4@gmail.com> (raw)
In-Reply-To: <20220330094532.21721-2-tinghan.shen@mediatek.com>



On 30/03/2022 11:45, Tinghan Shen wrote:
> MediaTek has a new version of mmc IP since mt8183. Some IO registers
> are moved to top to improve hardware design and named as "host top
> registers".
> 
> Add host top register in the reg binding description for mt8183 and
> successors.
> 
> Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
>   Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 15 ++++++++++++++-
>   1 file changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> index 297ada03e3de..2a2e9fa8c188 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> @@ -40,7 +40,10 @@ properties:
>             - const: mediatek,mt8183-mmc
>   
>     reg:
> -    maxItems: 1
> +    minItems: 1

 From my understanding adding minItems is correct, but you need to add also 
maxItems: 2 as there can't be more then two register entries.

Regards,
Matthias

> +    items:
> +      - description: base register (required).
> +      - description: top base register (required for MT8183).
>   
>     clocks:
>       description:
> @@ -168,6 +171,16 @@ required:
>     - vmmc-supply
>     - vqmmc-supply
>   
> +if:
> +  properties:
> +    compatible:
> +      contains:
> +        const: mediatek,mt8183-mmc
> +then:
> +  properties:
> +    reg:
> +      minItems: 2
> +
>   unevaluatedProperties: false
>   
>   examples:

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Tinghan Shen <tinghan.shen@mediatek.com>,
	Chaotian Jing <chaotian.jing@mediatek.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Wenbin Mei <wenbin.mei@mediatek.com>
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com,
	ryder.lee@kernel.org, wenst@chromium.org,
	chunfeng.yun@mediatek.com
Subject: Re: [PATCH v13 1/2] dt-bindings: mmc: mtk-sd: increase reg items
Date: Thu, 31 Mar 2022 12:54:16 +0200	[thread overview]
Message-ID: <aebbb5c8-1d27-5e66-e18a-e2b647bc8cb4@gmail.com> (raw)
In-Reply-To: <20220330094532.21721-2-tinghan.shen@mediatek.com>



On 30/03/2022 11:45, Tinghan Shen wrote:
> MediaTek has a new version of mmc IP since mt8183. Some IO registers
> are moved to top to improve hardware design and named as "host top
> registers".
> 
> Add host top register in the reg binding description for mt8183 and
> successors.
> 
> Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
>   Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 15 ++++++++++++++-
>   1 file changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> index 297ada03e3de..2a2e9fa8c188 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> @@ -40,7 +40,10 @@ properties:
>             - const: mediatek,mt8183-mmc
>   
>     reg:
> -    maxItems: 1
> +    minItems: 1

 From my understanding adding minItems is correct, but you need to add also 
maxItems: 2 as there can't be more then two register entries.

Regards,
Matthias

> +    items:
> +      - description: base register (required).
> +      - description: top base register (required for MT8183).
>   
>     clocks:
>       description:
> @@ -168,6 +171,16 @@ required:
>     - vmmc-supply
>     - vqmmc-supply
>   
> +if:
> +  properties:
> +    compatible:
> +      contains:
> +        const: mediatek,mt8183-mmc
> +then:
> +  properties:
> +    reg:
> +      minItems: 2
> +
>   unevaluatedProperties: false
>   
>   examples:

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-03-31 10:54 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-30  9:45 [PATCH v13 0/2] Add basic SoC support for mediatek mt8195 Tinghan Shen
2022-03-30  9:45 ` Tinghan Shen
2022-03-30  9:45 ` Tinghan Shen
2022-03-30  9:45 ` [PATCH v13 1/2] dt-bindings: mmc: mtk-sd: increase reg items Tinghan Shen
2022-03-30  9:45   ` Tinghan Shen
2022-03-30  9:45   ` Tinghan Shen
2022-03-31 10:54   ` Matthias Brugger [this message]
2022-03-31 10:54     ` Matthias Brugger
2022-03-31 10:54     ` Matthias Brugger
2022-04-01  2:18     ` Tinghan Shen
2022-04-01  2:18       ` Tinghan Shen
2022-04-01  2:18       ` Tinghan Shen
2022-04-02 16:21       ` Krzysztof Kozlowski
2022-04-02 16:21         ` Krzysztof Kozlowski
2022-04-02 16:21         ` Krzysztof Kozlowski
2022-04-04 19:22   ` Rob Herring
2022-04-04 19:22     ` Rob Herring
2022-04-04 19:22     ` Rob Herring
2022-04-06 14:55   ` Ulf Hansson
2022-04-06 14:55     ` Ulf Hansson
2022-04-06 14:55     ` Ulf Hansson
2022-03-30  9:45 ` [PATCH v13 2/2] arm64: dts: Add mediatek SoC mt8195 and evaluation board Tinghan Shen
2022-03-30  9:45   ` Tinghan Shen
2022-03-30  9:45   ` Tinghan Shen
2022-03-31  7:29   ` Chunfeng Yun
2022-03-31  7:29     ` Chunfeng Yun
2022-03-31  7:29     ` Chunfeng Yun
2022-04-01  2:19     ` Tinghan Shen
2022-04-01  2:19       ` Tinghan Shen
2022-04-01  2:19       ` Tinghan Shen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aebbb5c8-1d27-5e66-e18a-e2b647bc8cb4@gmail.com \
    --to=matthias.bgg@gmail.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chaotian.jing@mediatek.com \
    --cc=chunfeng.yun@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=ryder.lee@kernel.org \
    --cc=tinghan.shen@mediatek.com \
    --cc=ulf.hansson@linaro.org \
    --cc=wenbin.mei@mediatek.com \
    --cc=wenst@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.