From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: Tzung-Bi Shih <tzungbi@google.com>,
ALSA development <alsa-devel@alsa-project.org>,
Dylan Reid <dgreid@google.com>,
Jimmy Cheng-Yi Chiang <cychiang@google.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Linux Samsung SOC <linux-samsung-soc@vger.kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Takashi Iwai <tiwai@suse.de>
Subject: Re: [alsa-devel] [PATCH v2] ASoC: max98090: save and restore SHDN when changing sensitive registers
Date: Wed, 8 Jan 2020 12:54:30 +0100 [thread overview]
Message-ID: <aed6ff4e-1c04-e20c-aa55-4f2b05952f38@samsung.com> (raw)
In-Reply-To: <20191220120154.GB4790@sirena.org.uk>
Hi Mark,
On 20.12.2019 13:01, Mark Brown wrote:
> On Fri, Dec 20, 2019 at 10:05:52AM +0100, Marek Szyprowski wrote:
>> On 20.12.2019 09:28, Marek Szyprowski wrote:
>>> I've tried initially to cherry-pick it to v5.4, but the the code
>>> didn't compile due to lack of some macros, so I've gave up trying. I
>>> will check that now and backport needed macros too if you think this
>>> would help.
>> Same issue. I've tried backporting it to each kernel release: 5.4, 5.3,
>> 5.2, 5.1 and 5.0 (with additional backporting "ASoC: core: add
>> SND_SOC_BYTES_E" and "ASoC: Define a set of DAPM pre/post-up events").
>> In all cases the lockdep warning and oops is the same. Backporting to
>> v4.9 requires more changes to get it even compiled, so I gave up.
> OK, thanks - that's definitely not the recent refactorings then but
> something that's been a problem for a long time. I'm surprised nobody
> else ran into anything if that's the case...
It took me a while to get back into this issue and investigate it in
details. It turned out to be an incorrect helper to get component object
in max98090_dapm_put_enum_double() function. Following patches:
https://lkml.org/lkml/2020/1/8/358 fix this and (independent) lockdep
issues.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
WARNING: multiple messages have this Message-ID (diff)
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: ALSA development <alsa-devel@alsa-project.org>,
Linux Samsung SOC <linux-samsung-soc@vger.kernel.org>,
Jimmy Cheng-Yi Chiang <cychiang@google.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Takashi Iwai <tiwai@suse.de>,
Krzysztof Kozlowski <krzk@kernel.org>,
Tzung-Bi Shih <tzungbi@google.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Dylan Reid <dgreid@google.com>
Subject: Re: [alsa-devel] [PATCH v2] ASoC: max98090: save and restore SHDN when changing sensitive registers
Date: Wed, 8 Jan 2020 12:54:30 +0100 [thread overview]
Message-ID: <aed6ff4e-1c04-e20c-aa55-4f2b05952f38@samsung.com> (raw)
In-Reply-To: <20191220120154.GB4790@sirena.org.uk>
Hi Mark,
On 20.12.2019 13:01, Mark Brown wrote:
> On Fri, Dec 20, 2019 at 10:05:52AM +0100, Marek Szyprowski wrote:
>> On 20.12.2019 09:28, Marek Szyprowski wrote:
>>> I've tried initially to cherry-pick it to v5.4, but the the code
>>> didn't compile due to lack of some macros, so I've gave up trying. I
>>> will check that now and backport needed macros too if you think this
>>> would help.
>> Same issue. I've tried backporting it to each kernel release: 5.4, 5.3,
>> 5.2, 5.1 and 5.0 (with additional backporting "ASoC: core: add
>> SND_SOC_BYTES_E" and "ASoC: Define a set of DAPM pre/post-up events").
>> In all cases the lockdep warning and oops is the same. Backporting to
>> v4.9 requires more changes to get it even compiled, so I gave up.
> OK, thanks - that's definitely not the recent refactorings then but
> something that's been a problem for a long time. I'm surprised nobody
> else ran into anything if that's the case...
It took me a while to get back into this issue and investigate it in
details. It turned out to be an incorrect helper to get component object
in max98090_dapm_put_enum_double() function. Following patches:
https://lkml.org/lkml/2020/1/8/358 fix this and (independent) lockdep
issues.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2020-01-08 11:54 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191128152110epcas3p2b205b4b55f6d8bfac42fcb8faaade93c@epcas3p2.samsung.com>
2019-11-28 15:19 ` [alsa-devel] [PATCH v2] ASoC: max98090: save and restore SHDN when changing sensitive registers Tzung-Bi Shih
2019-12-09 18:59 ` [alsa-devel] Applied "ASoC: max98090: save and restore SHDN when changing sensitive registers" to the asoc tree Mark Brown
2019-12-12 14:09 ` [alsa-devel] [PATCH v2] ASoC: max98090: save and restore SHDN when changing sensitive registers Marek Szyprowski
2019-12-12 14:09 ` Marek Szyprowski
2019-12-12 16:02 ` Marek Szyprowski
2019-12-12 16:02 ` Marek Szyprowski
2019-12-12 16:48 ` Mark Brown
2019-12-12 16:48 ` Mark Brown
2019-12-12 18:05 ` Tzung-Bi Shih
2019-12-12 18:05 ` Tzung-Bi Shih
2019-12-17 14:18 ` Marek Szyprowski
2019-12-17 14:18 ` Marek Szyprowski
2019-12-18 13:26 ` Mark Brown
2019-12-18 13:26 ` Mark Brown
2019-12-18 14:48 ` Marek Szyprowski
2019-12-18 14:48 ` Marek Szyprowski
2019-12-18 16:24 ` Mark Brown
2019-12-18 16:24 ` Mark Brown
2019-12-19 8:03 ` Marek Szyprowski
2019-12-19 8:03 ` Marek Szyprowski
2019-12-19 12:37 ` Mark Brown
2019-12-19 12:37 ` Mark Brown
2019-12-19 12:54 ` Marek Szyprowski
2019-12-19 12:54 ` Marek Szyprowski
2019-12-19 13:05 ` Mark Brown
2019-12-19 13:05 ` Mark Brown
2019-12-19 13:41 ` Marek Szyprowski
2019-12-19 13:41 ` Marek Szyprowski
2019-12-19 19:16 ` Mark Brown
2019-12-19 19:16 ` Mark Brown
2019-12-20 8:28 ` Marek Szyprowski
2019-12-20 8:28 ` Marek Szyprowski
2019-12-20 9:05 ` Marek Szyprowski
2019-12-20 9:05 ` Marek Szyprowski
2019-12-20 12:01 ` Mark Brown
2019-12-20 12:01 ` Mark Brown
2020-01-08 11:54 ` Marek Szyprowski [this message]
2020-01-08 11:54 ` Marek Szyprowski
2020-01-09 21:18 ` Mark Brown
2020-01-09 21:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aed6ff4e-1c04-e20c-aa55-4f2b05952f38@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cychiang@google.com \
--cc=dgreid@google.com \
--cc=krzk@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=tiwai@suse.de \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.