All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shannon Nelson <snelson@pensando.io>
To: "Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Breno Leitão" <leitao@debian.org>,
	"Nayna Jain" <nayna@linux.ibm.com>,
	"Paulo Flabiano Smorigo" <pfsmorigo@gmail.com>,
	"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
	"Paul Mackerras" <paulus@samba.org>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"David S . Miller" <davem@davemloft.net>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	David@rox.of.borg, "David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Casey Leedom" <leedom@chelsio.com>,
	"Pensando Drivers" <drivers@pensando.io>,
	"Kevin Hilman" <khilman@kernel.org>, "Nishanth Menon" <nm@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	netdev@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] ionic: Use debugfs_create_bool() to export bool
Date: Mon, 21 Oct 2019 09:35:03 -0700	[thread overview]
Message-ID: <aeebbd5f-6100-2780-ef1c-6b1c261c9d23@pensando.io> (raw)
In-Reply-To: <20191021145149.31657-6-geert+renesas@glider.be>

On 10/21/19 7:51 AM, Geert Uytterhoeven wrote:
> Currently bool ionic_cq.done_color is exported using
> debugfs_create_u8(), which requires a cast, preventing further compiler
> checks.
>
> Fix this by switching to debugfs_create_bool(), and dropping the cast.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Shannon Nelson <snelson@pensando.io>

> ---
>   drivers/net/ethernet/pensando/ionic/ionic_debugfs.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c
> index bc03cecf80cc9eb4..5beba915f69d12dd 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c
> @@ -170,8 +170,7 @@ void ionic_debugfs_add_qcq(struct ionic_lif *lif, struct ionic_qcq *qcq)
>   	debugfs_create_x64("base_pa", 0400, cq_dentry, &cq->base_pa);
>   	debugfs_create_u32("num_descs", 0400, cq_dentry, &cq->num_descs);
>   	debugfs_create_u32("desc_size", 0400, cq_dentry, &cq->desc_size);
> -	debugfs_create_u8("done_color", 0400, cq_dentry,
> -			  (u8 *)&cq->done_color);
> +	debugfs_create_bool("done_color", 0400, cq_dentry, &cq->done_color);
>   
>   	debugfs_create_file("tail", 0400, cq_dentry, cq, &cq_tail_fops);
>   


WARNING: multiple messages have this Message-ID (diff)
From: Shannon Nelson <snelson@pensando.io>
To: "Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Breno Leitão" <leitao@debian.org>,
	"Nayna Jain" <nayna@linux.ibm.com>,
	"Paulo Flabiano Smorigo" <pfsmorigo@gmail.com>,
	"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
	"Paul Mackerras" <paulus@samba.org>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"David S . Miller" <davem@davemloft.net>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	David@rox.of.borg, "David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Casey Leedom" <leedom@chelsio.com>,
	"Pensando Drivers" <drivers@pensando.io>,
	"Kevin Hilman" <khilman@kernel.org>, "Nishanth Menon" <nm@ti.com>
Cc: amd-gfx@lists.freedesktop.org, linux-pm@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-crypto@vger.kernel.org, netdev@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 5/5] ionic: Use debugfs_create_bool() to export bool
Date: Mon, 21 Oct 2019 09:35:03 -0700	[thread overview]
Message-ID: <aeebbd5f-6100-2780-ef1c-6b1c261c9d23@pensando.io> (raw)
In-Reply-To: <20191021145149.31657-6-geert+renesas@glider.be>

On 10/21/19 7:51 AM, Geert Uytterhoeven wrote:
> Currently bool ionic_cq.done_color is exported using
> debugfs_create_u8(), which requires a cast, preventing further compiler
> checks.
>
> Fix this by switching to debugfs_create_bool(), and dropping the cast.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Shannon Nelson <snelson@pensando.io>

> ---
>   drivers/net/ethernet/pensando/ionic/ionic_debugfs.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c
> index bc03cecf80cc9eb4..5beba915f69d12dd 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c
> @@ -170,8 +170,7 @@ void ionic_debugfs_add_qcq(struct ionic_lif *lif, struct ionic_qcq *qcq)
>   	debugfs_create_x64("base_pa", 0400, cq_dentry, &cq->base_pa);
>   	debugfs_create_u32("num_descs", 0400, cq_dentry, &cq->num_descs);
>   	debugfs_create_u32("desc_size", 0400, cq_dentry, &cq->desc_size);
> -	debugfs_create_u8("done_color", 0400, cq_dentry,
> -			  (u8 *)&cq->done_color);
> +	debugfs_create_bool("done_color", 0400, cq_dentry, &cq->done_color);
>   
>   	debugfs_create_file("tail", 0400, cq_dentry, cq, &cq_tail_fops);
>   


  reply	other threads:[~2019-10-21 16:35 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-21 14:51 [PATCH 0/5] debugfs: Remove casts in debugfs_create_*() callers Geert Uytterhoeven
2019-10-21 14:51 ` Geert Uytterhoeven
2019-10-21 14:51 ` [PATCH 1/5] crypto: nx - Improve debugfs_create_u{32,64}() handling for atomics Geert Uytterhoeven
2019-10-21 14:51   ` [PATCH 1/5] crypto: nx - Improve debugfs_create_u{32, 64}() " Geert Uytterhoeven
2019-10-25 15:27   ` [PATCH 1/5] crypto: nx - Improve debugfs_create_u{32,64}() " Herbert Xu
2019-10-25 15:27     ` Herbert Xu
2019-10-25 15:27     ` Herbert Xu
2019-10-25 15:27     ` Herbert Xu
2019-10-25 15:27     ` Herbert Xu
2019-10-21 14:51 ` [PATCH 2/5] cxgb4/cxgb4vf: Remove superfluous void * cast in debugfs_create_file() call Geert Uytterhoeven
2019-10-21 14:51   ` Geert Uytterhoeven
2019-10-21 14:51 ` [PATCH 3/5] drm/amdgpu: " Geert Uytterhoeven
2019-10-21 14:51   ` Geert Uytterhoeven
2019-10-28 17:56   ` Alex Deucher
2019-10-28 17:56     ` Alex Deucher
2019-10-28 17:56     ` Alex Deucher
2019-10-28 17:56     ` Alex Deucher
2019-10-28 17:56     ` Alex Deucher
2019-10-21 14:51 ` [PATCH 4/5] power: avs: smartreflex: Remove superfluous " Geert Uytterhoeven
2019-10-21 14:51   ` Geert Uytterhoeven
2019-11-08 11:24   ` Rafael J. Wysocki
2019-11-08 11:24     ` Rafael J. Wysocki
2019-11-08 11:24     ` Rafael J. Wysocki
2019-11-08 11:24     ` Rafael J. Wysocki
2019-11-08 11:24     ` Rafael J. Wysocki
2019-11-08 11:37     ` Greg Kroah-Hartman
2019-11-08 11:37       ` Greg Kroah-Hartman
2019-11-08 11:37       ` Greg Kroah-Hartman
2019-11-08 11:37       ` Greg Kroah-Hartman
2019-11-08 11:37       ` Greg Kroah-Hartman
2019-11-13 11:02   ` Rafael J. Wysocki
2019-11-13 11:02     ` Rafael J. Wysocki
2019-11-13 11:02     ` Rafael J. Wysocki
2019-11-13 11:02     ` Rafael J. Wysocki
2019-11-13 11:02     ` Rafael J. Wysocki
2019-10-21 14:51 ` [PATCH 5/5] ionic: Use debugfs_create_bool() to export bool Geert Uytterhoeven
2019-10-21 14:51   ` Geert Uytterhoeven
2019-10-21 16:35   ` Shannon Nelson [this message]
2019-10-21 16:35     ` Shannon Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aeebbd5f-6100-2780-ef1c-6b1c261c9d23@pensando.io \
    --to=snelson@pensando.io \
    --cc=David@rox.of.borg \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=benh@kernel.crashing.org \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=davem@davemloft.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=drivers@pensando.io \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=khilman@kernel.org \
    --cc=leedom@chelsio.com \
    --cc=leitao@debian.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=nayna@linux.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=paulus@samba.org \
    --cc=pfsmorigo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.