All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David.Wu" <david.wu@rock-chips.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: thierry.reding@gmail.com, heiko@sntech.de, robh+dt@kernel.org,
	catalin.marinas@arm.com, briannorris@chromium.org,
	dianders@chromium.org, mark.rutland@arm.com,
	huangtao@rock-chips.com, linux-pwm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/7] pwm: rockchip: Remove the dumplicate rockchip_pwm_ops ops
Date: Wed, 2 Aug 2017 19:31:57 +0800	[thread overview]
Message-ID: <af056420-5c33-e6c8-62cb-bcd3456000a7@rock-chips.com> (raw)
In-Reply-To: <20170802105902.2d137072@bbrezillon>

Hi Boris,

在 2017/8/2 16:59, Boris Brezillon 写道:
> Actually, when I suggested to just implement ->apply_state() and be
> done with all other fields I was thinking that you could get rid of
> this rockchip_pwm_data struct entirely and just have 3 different
> pwm_ops. You seem to take the other direction here: you're removing
> rockchip_pwm_ops_v1 and renaming rockchip_pwm_ops_v2 into
> rockchip_pwm_ops.

Yes, i really didn't understand exactly what you mean.
Your mean is that remove the set_enable, get_state and other hooks,
then use the pwm_ops instead of them, which has 3 different version, and 
implement the pwm_ops's functions like apply(), enable(), get_state() 
and others...?

WARNING: multiple messages have this Message-ID (diff)
From: "David.Wu" <david.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
To: Boris Brezillon
	<boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	catalin.marinas-5wv7dgnIgG8@public.gmane.org,
	briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 3/7] pwm: rockchip: Remove the dumplicate rockchip_pwm_ops ops
Date: Wed, 2 Aug 2017 19:31:57 +0800	[thread overview]
Message-ID: <af056420-5c33-e6c8-62cb-bcd3456000a7@rock-chips.com> (raw)
In-Reply-To: <20170802105902.2d137072@bbrezillon>

Hi Boris,

在 2017/8/2 16:59, Boris Brezillon 写道:
> Actually, when I suggested to just implement ->apply_state() and be
> done with all other fields I was thinking that you could get rid of
> this rockchip_pwm_data struct entirely and just have 3 different
> pwm_ops. You seem to take the other direction here: you're removing
> rockchip_pwm_ops_v1 and renaming rockchip_pwm_ops_v2 into
> rockchip_pwm_ops.

Yes, i really didn't understand exactly what you mean.
Your mean is that remove the set_enable, get_state and other hooks,
then use the pwm_ops instead of them, which has 3 different version, and 
implement the pwm_ops's functions like apply(), enable(), get_state() 
and others...?

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: david.wu@rock-chips.com (David.Wu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/7] pwm: rockchip: Remove the dumplicate rockchip_pwm_ops ops
Date: Wed, 2 Aug 2017 19:31:57 +0800	[thread overview]
Message-ID: <af056420-5c33-e6c8-62cb-bcd3456000a7@rock-chips.com> (raw)
In-Reply-To: <20170802105902.2d137072@bbrezillon>

Hi Boris,

? 2017/8/2 16:59, Boris Brezillon ??:
> Actually, when I suggested to just implement ->apply_state() and be
> done with all other fields I was thinking that you could get rid of
> this rockchip_pwm_data struct entirely and just have 3 different
> pwm_ops. You seem to take the other direction here: you're removing
> rockchip_pwm_ops_v1 and renaming rockchip_pwm_ops_v2 into
> rockchip_pwm_ops.

Yes, i really didn't understand exactly what you mean.
Your mean is that remove the set_enable, get_state and other hooks,
then use the pwm_ops instead of them, which has 3 different version, and 
implement the pwm_ops's functions like apply(), enable(), get_state() 
and others...?

  reply	other threads:[~2017-08-02 11:32 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-08  4:03 [PATCH v2 0/7] Add rk3328 pwm support David Wu
2017-07-08  4:03 ` David Wu
2017-07-08  4:03 ` David Wu
2017-07-08  4:03 ` [PATCH v2 1/7] pwm: rockchip: Add APB and function both clocks support David Wu
2017-07-08  4:03   ` David Wu
2017-07-11 17:03   ` Doug Anderson
2017-07-11 17:03     ` Doug Anderson
2017-07-12  8:38     ` David.Wu
2017-07-12  8:38       ` David.Wu
2017-07-12  8:38       ` David.Wu
2017-07-12 19:09       ` Heiko Stübner
2017-07-12 19:09         ` Heiko Stübner
2017-07-12 19:09         ` Heiko Stübner
2017-07-08  4:03 ` [PATCH v2 2/7] pwm: rockchip: Remove the judge from return value of pwm_config David Wu
2017-07-08  4:03   ` David Wu
2017-07-08  4:03 ` [PATCH v2 3/7] pwm: rockchip: Remove the dumplicate rockchip_pwm_ops ops David Wu
2017-07-08  4:03   ` David Wu
2017-07-08  4:03   ` David Wu
2017-08-02  8:59   ` Boris Brezillon
2017-08-02  8:59     ` Boris Brezillon
2017-08-02 11:31     ` David.Wu [this message]
2017-08-02 11:31       ` David.Wu
2017-08-02 11:31       ` David.Wu
2017-08-02 11:40       ` Boris Brezillon
2017-08-02 11:40         ` Boris Brezillon
2017-08-02 11:40         ` Boris Brezillon
2017-08-04  2:38         ` David.Wu
2017-08-04  2:38           ` David.Wu
2017-08-04  2:38           ` David.Wu
2017-08-04  7:09           ` Boris Brezillon
2017-08-04  7:09             ` Boris Brezillon
2017-08-04  7:09             ` Boris Brezillon
2017-08-08 15:41             ` David.Wu
2017-08-08 15:41               ` David.Wu
2017-07-08  4:03 ` [PATCH v2 4/7] pwm: rockchip: Use pwm_apply instead of the pwm_enable David Wu
2017-07-08  4:03   ` David Wu
2017-07-08  4:08 ` [PATCH v2 5/7] pwm: rockchip: Move the configuration of polarity from rockchip_pwm_set_enable() to rockchip_pwm_config() David Wu
2017-07-08  4:08   ` David Wu
2017-07-08  4:08   ` David Wu
2017-07-08  4:09 ` [PATCH v2 6/7] pwm: rockchip: Add rk3328 pwm support David Wu
2017-07-08  4:09   ` David Wu
2017-07-08  4:10 ` [PATCH v2 7/7] arm64: dts: rockchip: Add pwm nodes for rk3328 David Wu
2017-07-08  4:10   ` David Wu
2017-07-08  4:25 ` [RESEND PATCH v2 6/7] pwm: rockchip: Add rk3328 pwm support David Wu
2017-07-08  4:25   ` David Wu
2017-07-08  4:25   ` David Wu
2017-08-02  8:46 ` [PATCH v2 0/7] " David.Wu
2017-08-02  8:46   ` David.Wu
2017-08-02  8:46   ` David.Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af056420-5c33-e6c8-62cb-bcd3456000a7@rock-chips.com \
    --to=david.wu@rock-chips.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=briannorris@chromium.org \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=heiko@sntech.de \
    --cc=huangtao@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.