From: Jaehoon Chung <jh80.chung@samsung.com>
To: John Keeping <john@metanate.com>, linux-mmc@vger.kernel.org
Cc: Heiko Stuebner <heiko@sntech.de>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH 2/4] mmc: dw_mmc: hi3798cv200: use common_caps
Date: Fri, 26 Nov 2021 08:37:09 +0900 [thread overview]
Message-ID: <af210f7b-01ee-40f4-f6c0-4cbdafd87a3d@samsung.com> (raw)
In-Reply-To: <20211124184603.3897245-3-john@metanate.com>
On 11/25/21 3:46 AM, John Keeping wrote:
> The capabilities for all instances are the same, so use common_caps
> instead of caps/num_caps to remove the dependency on the mshcN device
> tree alias.
>
> Signed-off-by: John Keeping <john@metanate.com>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
> ---
> drivers/mmc/host/dw_mmc-hi3798cv200.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-hi3798cv200.c b/drivers/mmc/host/dw_mmc-hi3798cv200.c
> index 39794f93826f..e9437ef8ef19 100644
> --- a/drivers/mmc/host/dw_mmc-hi3798cv200.c
> +++ b/drivers/mmc/host/dw_mmc-hi3798cv200.c
> @@ -23,12 +23,6 @@ struct hi3798cv200_priv {
> struct clk *drive_clk;
> };
>
> -static unsigned long dw_mci_hi3798cv200_caps[] = {
> - MMC_CAP_CMD23,
> - MMC_CAP_CMD23,
> - MMC_CAP_CMD23
> -};
> -
> static void dw_mci_hi3798cv200_set_ios(struct dw_mci *host, struct mmc_ios *ios)
> {
> struct hi3798cv200_priv *priv = host->priv;
> @@ -166,8 +160,7 @@ static int dw_mci_hi3798cv200_init(struct dw_mci *host)
> }
>
> static const struct dw_mci_drv_data hi3798cv200_data = {
> - .caps = dw_mci_hi3798cv200_caps,
> - .num_caps = ARRAY_SIZE(dw_mci_hi3798cv200_caps),
> + .common_caps = MMC_CAP_CMD23,
> .init = dw_mci_hi3798cv200_init,
> .set_ios = dw_mci_hi3798cv200_set_ios,
> .execute_tuning = dw_mci_hi3798cv200_execute_tuning,
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Jaehoon Chung <jh80.chung@samsung.com>
To: John Keeping <john@metanate.com>, linux-mmc@vger.kernel.org
Cc: Heiko Stuebner <heiko@sntech.de>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH 2/4] mmc: dw_mmc: hi3798cv200: use common_caps
Date: Fri, 26 Nov 2021 08:37:09 +0900 [thread overview]
Message-ID: <af210f7b-01ee-40f4-f6c0-4cbdafd87a3d@samsung.com> (raw)
In-Reply-To: <20211124184603.3897245-3-john@metanate.com>
On 11/25/21 3:46 AM, John Keeping wrote:
> The capabilities for all instances are the same, so use common_caps
> instead of caps/num_caps to remove the dependency on the mshcN device
> tree alias.
>
> Signed-off-by: John Keeping <john@metanate.com>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
> ---
> drivers/mmc/host/dw_mmc-hi3798cv200.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-hi3798cv200.c b/drivers/mmc/host/dw_mmc-hi3798cv200.c
> index 39794f93826f..e9437ef8ef19 100644
> --- a/drivers/mmc/host/dw_mmc-hi3798cv200.c
> +++ b/drivers/mmc/host/dw_mmc-hi3798cv200.c
> @@ -23,12 +23,6 @@ struct hi3798cv200_priv {
> struct clk *drive_clk;
> };
>
> -static unsigned long dw_mci_hi3798cv200_caps[] = {
> - MMC_CAP_CMD23,
> - MMC_CAP_CMD23,
> - MMC_CAP_CMD23
> -};
> -
> static void dw_mci_hi3798cv200_set_ios(struct dw_mci *host, struct mmc_ios *ios)
> {
> struct hi3798cv200_priv *priv = host->priv;
> @@ -166,8 +160,7 @@ static int dw_mci_hi3798cv200_init(struct dw_mci *host)
> }
>
> static const struct dw_mci_drv_data hi3798cv200_data = {
> - .caps = dw_mci_hi3798cv200_caps,
> - .num_caps = ARRAY_SIZE(dw_mci_hi3798cv200_caps),
> + .common_caps = MMC_CAP_CMD23,
> .init = dw_mci_hi3798cv200_init,
> .set_ios = dw_mci_hi3798cv200_set_ios,
> .execute_tuning = dw_mci_hi3798cv200_execute_tuning,
>
WARNING: multiple messages have this Message-ID (diff)
From: Jaehoon Chung <jh80.chung@samsung.com>
To: John Keeping <john@metanate.com>, linux-mmc@vger.kernel.org
Cc: Heiko Stuebner <heiko@sntech.de>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH 2/4] mmc: dw_mmc: hi3798cv200: use common_caps
Date: Fri, 26 Nov 2021 08:37:09 +0900 [thread overview]
Message-ID: <af210f7b-01ee-40f4-f6c0-4cbdafd87a3d@samsung.com> (raw)
In-Reply-To: <20211124184603.3897245-3-john@metanate.com>
On 11/25/21 3:46 AM, John Keeping wrote:
> The capabilities for all instances are the same, so use common_caps
> instead of caps/num_caps to remove the dependency on the mshcN device
> tree alias.
>
> Signed-off-by: John Keeping <john@metanate.com>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
> ---
> drivers/mmc/host/dw_mmc-hi3798cv200.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-hi3798cv200.c b/drivers/mmc/host/dw_mmc-hi3798cv200.c
> index 39794f93826f..e9437ef8ef19 100644
> --- a/drivers/mmc/host/dw_mmc-hi3798cv200.c
> +++ b/drivers/mmc/host/dw_mmc-hi3798cv200.c
> @@ -23,12 +23,6 @@ struct hi3798cv200_priv {
> struct clk *drive_clk;
> };
>
> -static unsigned long dw_mci_hi3798cv200_caps[] = {
> - MMC_CAP_CMD23,
> - MMC_CAP_CMD23,
> - MMC_CAP_CMD23
> -};
> -
> static void dw_mci_hi3798cv200_set_ios(struct dw_mci *host, struct mmc_ios *ios)
> {
> struct hi3798cv200_priv *priv = host->priv;
> @@ -166,8 +160,7 @@ static int dw_mci_hi3798cv200_init(struct dw_mci *host)
> }
>
> static const struct dw_mci_drv_data hi3798cv200_data = {
> - .caps = dw_mci_hi3798cv200_caps,
> - .num_caps = ARRAY_SIZE(dw_mci_hi3798cv200_caps),
> + .common_caps = MMC_CAP_CMD23,
> .init = dw_mci_hi3798cv200_init,
> .set_ios = dw_mci_hi3798cv200_set_ios,
> .execute_tuning = dw_mci_hi3798cv200_execute_tuning,
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-25 23:37 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 18:45 [PATCH 0/4] mmc: dw_mmc: start deprecating mshcN aliases John Keeping
2021-11-24 18:45 ` John Keeping
2021-11-24 18:45 ` John Keeping
2021-11-24 18:45 ` [PATCH 1/4] mmc: dw_mmc: add common capabilities to replace caps John Keeping
2021-11-24 18:45 ` John Keeping
2021-11-24 18:45 ` John Keeping
2021-11-25 23:37 ` Jaehoon Chung
2021-11-25 23:37 ` Jaehoon Chung
2021-11-25 23:37 ` Jaehoon Chung
2021-11-24 18:46 ` [PATCH 2/4] mmc: dw_mmc: hi3798cv200: use common_caps John Keeping
2021-11-24 18:46 ` John Keeping
2021-11-24 18:46 ` John Keeping
2021-11-25 23:37 ` Jaehoon Chung [this message]
2021-11-25 23:37 ` Jaehoon Chung
2021-11-25 23:37 ` Jaehoon Chung
2021-11-24 18:46 ` [PATCH 3/4] mmc: dw_mmc: rockchip: " John Keeping
2021-11-24 18:46 ` John Keeping
2021-11-24 18:46 ` John Keeping
2021-11-25 23:37 ` Jaehoon Chung
2021-11-25 23:37 ` Jaehoon Chung
2021-11-25 23:37 ` Jaehoon Chung
2021-11-24 18:46 ` [PATCH 4/4] mmc: dw_mmc: exynos: " John Keeping
2021-11-24 18:46 ` John Keeping
2021-11-24 18:46 ` John Keeping
2021-11-25 23:38 ` Jaehoon Chung
2021-11-25 23:38 ` Jaehoon Chung
2021-11-25 23:38 ` Jaehoon Chung
2021-11-26 12:39 ` John Keeping
2021-11-26 12:39 ` John Keeping
2021-11-26 12:39 ` John Keeping
2021-11-24 19:24 ` [PATCH 0/4] mmc: dw_mmc: start deprecating mshcN aliases Ulf Hansson
2021-11-24 19:24 ` Ulf Hansson
2021-11-24 19:24 ` Ulf Hansson
2021-11-26 13:31 ` Ulf Hansson
2021-11-26 13:31 ` Ulf Hansson
2021-11-26 13:31 ` Ulf Hansson
2021-11-25 11:48 ` Nicolas Frattaroli
2021-11-25 11:48 ` Nicolas Frattaroli
2021-11-25 11:48 ` Nicolas Frattaroli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af210f7b-01ee-40f4-f6c0-4cbdafd87a3d@samsung.com \
--to=jh80.chung@samsung.com \
--cc=heiko@sntech.de \
--cc=john@metanate.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.