* [PATCH 1/3] verify: add missing free(ptr);
@ 2017-05-26 19:25 kusumi.tomohiro
2017-05-26 19:25 ` [PATCH 2/3] verify: mention some default option values kusumi.tomohiro
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: kusumi.tomohiro @ 2017-05-26 19:25 UTC (permalink / raw)
To: axboe, fio; +Cc: Tomohiro Kusumi
From: Tomohiro Kusumi <tkusumi@tuxera.com>
Signed-off-by: Tomohiro Kusumi <tkusumi@tuxera.com>
---
verify.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/verify.c b/verify.c
index cadfe9c..1c39fa2 100644
--- a/verify.c
+++ b/verify.c
@@ -271,6 +271,7 @@ static void dump_buf(char *buf, unsigned int len, unsigned long long offset,
fd = open(fname, O_CREAT | O_TRUNC | O_WRONLY, 0644);
if (fd < 0) {
perror("open verify buf file");
+ free(ptr);
return;
}
--
2.9.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/3] verify: mention some default option values
2017-05-26 19:25 [PATCH 1/3] verify: add missing free(ptr); kusumi.tomohiro
@ 2017-05-26 19:25 ` kusumi.tomohiro
2017-05-26 19:29 ` Jens Axboe
2017-05-26 19:25 ` [PATCH 3/3] manpage: update URL links to HOWTO/README kusumi.tomohiro
2017-05-26 19:29 ` [PATCH 1/3] verify: add missing free(ptr); Jens Axboe
2 siblings, 1 reply; 5+ messages in thread
From: kusumi.tomohiro @ 2017-05-26 19:25 UTC (permalink / raw)
To: axboe, fio; +Cc: Tomohiro Kusumi
From: Tomohiro Kusumi <tkusumi@tuxera.com>
Signed-off-by: Tomohiro Kusumi <tkusumi@tuxera.com>
---
HOWTO | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/HOWTO b/HOWTO
index a899b90..8cfa12c 100644
--- a/HOWTO
+++ b/HOWTO
@@ -2467,6 +2467,7 @@ Verification
contents to one or more separate threads. If using this offload option, even
sync I/O engines can benefit from using an :option:`iodepth` setting higher
than 1, as it allows them to have I/O in flight while verifies are running.
+ Defaults to 0 async thread, i.e. verification is not asynchronous.
.. option:: verify_async_cpus=str
@@ -2503,7 +2504,7 @@ Verification
<type> is "local" for a local run, "sock" for a client/server socket
connection, and "ip" (192.168.0.1, for instance) for a networked
- client/server connection.
+ client/server connection. Defaults to true.
.. option:: verify_state_load=bool
--
2.9.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 3/3] manpage: update URL links to HOWTO/README
2017-05-26 19:25 [PATCH 1/3] verify: add missing free(ptr); kusumi.tomohiro
2017-05-26 19:25 ` [PATCH 2/3] verify: mention some default option values kusumi.tomohiro
@ 2017-05-26 19:25 ` kusumi.tomohiro
2017-05-26 19:29 ` [PATCH 1/3] verify: add missing free(ptr); Jens Axboe
2 siblings, 0 replies; 5+ messages in thread
From: kusumi.tomohiro @ 2017-05-26 19:25 UTC (permalink / raw)
To: axboe, fio; +Cc: Tomohiro Kusumi
From: Tomohiro Kusumi <tkusumi@tuxera.com>
Web frontend of the official git repository seems to have been changed
after 9040e236 (manpage: Add URL links to HOWTO/README).
Signed-off-by: Tomohiro Kusumi <tkusumi@tuxera.com>
---
fio.1 | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fio.1 b/fio.1
index 301a708..9956867 100644
--- a/fio.1
+++ b/fio.1
@@ -1,4 +1,4 @@
-.TH fio 1 "March 2017" "User Manual"
+.TH fio 1 "May 2017" "User Manual"
.SH NAME
fio \- flexible I/O tester
.SH SYNOPSIS
@@ -2594,7 +2594,7 @@ Sample jobfiles are available in the \fBexamples\fR directory.
.br
These are typically located under /usr/share/doc/fio.
-\fBHOWTO\fR: http://git.kernel.dk/?p=fio.git;a=blob_plain;f=HOWTO
+\fBHOWTO\fR: http://git.kernel.dk/cgit/fio/plain/HOWTO
.br
-\fBREADME\fR: http://git.kernel.dk/?p=fio.git;a=blob_plain;f=README
+\fBREADME\fR: http://git.kernel.dk/cgit/fio/plain/README
.br
--
2.9.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3] verify: add missing free(ptr);
2017-05-26 19:25 [PATCH 1/3] verify: add missing free(ptr); kusumi.tomohiro
2017-05-26 19:25 ` [PATCH 2/3] verify: mention some default option values kusumi.tomohiro
2017-05-26 19:25 ` [PATCH 3/3] manpage: update URL links to HOWTO/README kusumi.tomohiro
@ 2017-05-26 19:29 ` Jens Axboe
2 siblings, 0 replies; 5+ messages in thread
From: Jens Axboe @ 2017-05-26 19:29 UTC (permalink / raw)
To: kusumi.tomohiro, fio; +Cc: Tomohiro Kusumi
On 05/26/2017 01:25 PM, kusumi.tomohiro@gmail.com wrote:
> From: Tomohiro Kusumi <tkusumi@tuxera.com>
Applied 1-3, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/3] verify: mention some default option values
2017-05-26 19:25 ` [PATCH 2/3] verify: mention some default option values kusumi.tomohiro
@ 2017-05-26 19:29 ` Jens Axboe
0 siblings, 0 replies; 5+ messages in thread
From: Jens Axboe @ 2017-05-26 19:29 UTC (permalink / raw)
To: kusumi.tomohiro, fio; +Cc: Tomohiro Kusumi
On 05/26/2017 01:25 PM, kusumi.tomohiro@gmail.com wrote:
> From: Tomohiro Kusumi <tkusumi@tuxera.com>
>
> Signed-off-by: Tomohiro Kusumi <tkusumi@tuxera.com>
> ---
> HOWTO | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/HOWTO b/HOWTO
> index a899b90..8cfa12c 100644
> --- a/HOWTO
> +++ b/HOWTO
> @@ -2467,6 +2467,7 @@ Verification
> contents to one or more separate threads. If using this offload option, even
> sync I/O engines can benefit from using an :option:`iodepth` setting higher
> than 1, as it allows them to have I/O in flight while verifies are running.
> + Defaults to 0 async thread, i.e. verification is not asynchronous.
Should be 'threads' there, I made that correction before applying.
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-26 19:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-26 19:25 [PATCH 1/3] verify: add missing free(ptr); kusumi.tomohiro
2017-05-26 19:25 ` [PATCH 2/3] verify: mention some default option values kusumi.tomohiro
2017-05-26 19:29 ` Jens Axboe
2017-05-26 19:25 ` [PATCH 3/3] manpage: update URL links to HOWTO/README kusumi.tomohiro
2017-05-26 19:29 ` [PATCH 1/3] verify: add missing free(ptr); Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.