All of lore.kernel.org
 help / color / mirror / Atom feed
From: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
To: Alexandre TORGUE <alexandre.torgue@foss.st.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: <linux-stm32@st-md-mailman.stormreply.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	David Airlie <airlied@gmail.com>,
	Yannick Fertre <yannick.fertre@foss.st.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Conor Dooley <conor.dooley@microchip.com>,
	<kernel@dh-electronics.com>, Marek Vasut <marex@denx.de>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<dri-devel@lists.freedesktop.org>,
	Rob Herring <robh+dt@kernel.org>,
	Philippe Cornu <philippe.cornu@foss.st.com>,
	<linux-arm-kernel@lists.infradead.org>,
	Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v4 2/4] dt-bindings: display: st,stm32-dsi: Remove unnecessary fields
Date: Tue, 30 May 2023 15:38:37 +0200	[thread overview]
Message-ID: <af31ae21-2711-2fac-e885-b3bbbcb12be8@foss.st.com> (raw)
In-Reply-To: <92d5a699-9f5d-2e40-ca73-4604f3e5a657@foss.st.com>


On 5/30/23 15:30, Alexandre TORGUE wrote:
> On 5/30/23 14:27, Krzysztof Kozlowski wrote:
>> On Mon, 29 May 2023 11:13:57 +0200, Raphael Gallais-Pou wrote:
>>> "#address-cells" and "#size-cells" are two properties that are not
>>> mandatory. For instance, the DSI could refer to a bridge outside the scope
>>> of the node rather than include a 'panel@0' subnode. By doing so, address
>>> and size fields become then unnecessary, creating a warning at build time.
>>>
>>> Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
>>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>>> Reviewed-by: Marek Vasut <marex@denx.de>
>>> ---
>>>   Documentation/devicetree/bindings/display/st,stm32-dsi.yaml | 2 --
>>>   1 file changed, 2 deletions(-)
>>>
>>
>> Running 'make dtbs_check' with the schema in this patch gives the
>> following warnings. Consider if they are expected or the schema is
>> incorrect. These may not be new warnings
> I checked it before merging the series on stm32-next tree. I didn't get this
> error. I didn't check commit per commit.
>
> Do you get this error after merging the whole series ?


I think this is because of the order of the patches within the serie. The patch
correcting the yaml is before those modifying the device-trees. This could
explain warnings rise up when checking patch per patch. However I did not get
any errors on top of  the whole serie.

>
>
>>
>> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
>> This will change in the future.
>>
>> Full log is available here: https://patchwork.ozlabs.org/patch/1787034
>>
>>
>> dsi@40016c00: Unevaluated properties are not allowed ('panel-dsi@0' was
>> unexpected)
>>     arch/arm/boot/dts/stm32f469-disco.dtb
>>
>> dsi@5a000000: Unevaluated properties are not allowed ('panel-dsi@0' was
>> unexpected)
>>     arch/arm/boot/dts/stm32mp157c-ev1.dtb
>>     arch/arm/boot/dts/stm32mp157c-ev1-scmi.dtb
>

WARNING: multiple messages have this Message-ID (diff)
From: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
To: Alexandre TORGUE <alexandre.torgue@foss.st.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: <linux-stm32@st-md-mailman.stormreply.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	David Airlie <airlied@gmail.com>,
	Yannick Fertre <yannick.fertre@foss.st.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Conor Dooley <conor.dooley@microchip.com>,
	<kernel@dh-electronics.com>, Marek Vasut <marex@denx.de>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<dri-devel@lists.freedesktop.org>,
	Rob Herring <robh+dt@kernel.org>,
	Philippe Cornu <philippe.cornu@foss.st.com>,
	<linux-arm-kernel@lists.infradead.org>,
	Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v4 2/4] dt-bindings: display: st,stm32-dsi: Remove unnecessary fields
Date: Tue, 30 May 2023 15:38:37 +0200	[thread overview]
Message-ID: <af31ae21-2711-2fac-e885-b3bbbcb12be8@foss.st.com> (raw)
In-Reply-To: <92d5a699-9f5d-2e40-ca73-4604f3e5a657@foss.st.com>


On 5/30/23 15:30, Alexandre TORGUE wrote:
> On 5/30/23 14:27, Krzysztof Kozlowski wrote:
>> On Mon, 29 May 2023 11:13:57 +0200, Raphael Gallais-Pou wrote:
>>> "#address-cells" and "#size-cells" are two properties that are not
>>> mandatory. For instance, the DSI could refer to a bridge outside the scope
>>> of the node rather than include a 'panel@0' subnode. By doing so, address
>>> and size fields become then unnecessary, creating a warning at build time.
>>>
>>> Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
>>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>>> Reviewed-by: Marek Vasut <marex@denx.de>
>>> ---
>>>   Documentation/devicetree/bindings/display/st,stm32-dsi.yaml | 2 --
>>>   1 file changed, 2 deletions(-)
>>>
>>
>> Running 'make dtbs_check' with the schema in this patch gives the
>> following warnings. Consider if they are expected or the schema is
>> incorrect. These may not be new warnings
> I checked it before merging the series on stm32-next tree. I didn't get this
> error. I didn't check commit per commit.
>
> Do you get this error after merging the whole series ?


I think this is because of the order of the patches within the serie. The patch
correcting the yaml is before those modifying the device-trees. This could
explain warnings rise up when checking patch per patch. However I did not get
any errors on top of  the whole serie.

>
>
>>
>> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
>> This will change in the future.
>>
>> Full log is available here: https://patchwork.ozlabs.org/patch/1787034
>>
>>
>> dsi@40016c00: Unevaluated properties are not allowed ('panel-dsi@0' was
>> unexpected)
>>     arch/arm/boot/dts/stm32f469-disco.dtb
>>
>> dsi@5a000000: Unevaluated properties are not allowed ('panel-dsi@0' was
>> unexpected)
>>     arch/arm/boot/dts/stm32mp157c-ev1.dtb
>>     arch/arm/boot/dts/stm32mp157c-ev1-scmi.dtb
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
To: Alexandre TORGUE <alexandre.torgue@foss.st.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Marek Vasut <marex@denx.de>,
	devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Yannick Fertre <yannick.fertre@foss.st.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Rob Herring <robh+dt@kernel.org>,
	Conor Dooley <conor.dooley@microchip.com>,
	kernel@dh-electronics.com,
	Philippe Cornu <philippe.cornu@foss.st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/4] dt-bindings: display: st,stm32-dsi: Remove unnecessary fields
Date: Tue, 30 May 2023 15:38:37 +0200	[thread overview]
Message-ID: <af31ae21-2711-2fac-e885-b3bbbcb12be8@foss.st.com> (raw)
In-Reply-To: <92d5a699-9f5d-2e40-ca73-4604f3e5a657@foss.st.com>


On 5/30/23 15:30, Alexandre TORGUE wrote:
> On 5/30/23 14:27, Krzysztof Kozlowski wrote:
>> On Mon, 29 May 2023 11:13:57 +0200, Raphael Gallais-Pou wrote:
>>> "#address-cells" and "#size-cells" are two properties that are not
>>> mandatory. For instance, the DSI could refer to a bridge outside the scope
>>> of the node rather than include a 'panel@0' subnode. By doing so, address
>>> and size fields become then unnecessary, creating a warning at build time.
>>>
>>> Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
>>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>>> Reviewed-by: Marek Vasut <marex@denx.de>
>>> ---
>>>   Documentation/devicetree/bindings/display/st,stm32-dsi.yaml | 2 --
>>>   1 file changed, 2 deletions(-)
>>>
>>
>> Running 'make dtbs_check' with the schema in this patch gives the
>> following warnings. Consider if they are expected or the schema is
>> incorrect. These may not be new warnings
> I checked it before merging the series on stm32-next tree. I didn't get this
> error. I didn't check commit per commit.
>
> Do you get this error after merging the whole series ?


I think this is because of the order of the patches within the serie. The patch
correcting the yaml is before those modifying the device-trees. This could
explain warnings rise up when checking patch per patch. However I did not get
any errors on top of  the whole serie.

>
>
>>
>> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
>> This will change in the future.
>>
>> Full log is available here: https://patchwork.ozlabs.org/patch/1787034
>>
>>
>> dsi@40016c00: Unevaluated properties are not allowed ('panel-dsi@0' was
>> unexpected)
>>     arch/arm/boot/dts/stm32f469-disco.dtb
>>
>> dsi@5a000000: Unevaluated properties are not allowed ('panel-dsi@0' was
>> unexpected)
>>     arch/arm/boot/dts/stm32mp157c-ev1.dtb
>>     arch/arm/boot/dts/stm32mp157c-ev1-scmi.dtb
>

  reply	other threads:[~2023-05-30 13:39 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-29  9:13 [PATCH v4 0/4] STM32 warning cleanup Raphael Gallais-Pou
2023-05-29  9:13 ` Raphael Gallais-Pou
2023-05-29  9:13 ` Raphael Gallais-Pou
2023-05-29  9:13 ` [PATCH v4 1/4] ARM: dts: stm32: fix warnings on stm32f469-disco board Raphael Gallais-Pou
2023-05-29  9:13   ` Raphael Gallais-Pou
2023-05-29  9:13   ` Raphael Gallais-Pou
2023-05-29  9:13 ` [PATCH v4 2/4] dt-bindings: display: st,stm32-dsi: Remove unnecessary fields Raphael Gallais-Pou
2023-05-29  9:13   ` [PATCH v4 2/4] dt-bindings: display: st, stm32-dsi: " Raphael Gallais-Pou
2023-05-29  9:13   ` [PATCH v4 2/4] dt-bindings: display: st,stm32-dsi: " Raphael Gallais-Pou
2023-05-30 12:27   ` Krzysztof Kozlowski
2023-05-30 12:27     ` Krzysztof Kozlowski
2023-05-30 12:27     ` Krzysztof Kozlowski
2023-05-30 13:30     ` Alexandre TORGUE
2023-05-30 13:30       ` Alexandre TORGUE
2023-05-30 13:30       ` Alexandre TORGUE
2023-05-30 13:38       ` Raphael Gallais-Pou [this message]
2023-05-30 13:38         ` Raphael Gallais-Pou
2023-05-30 13:38         ` Raphael Gallais-Pou
2023-05-30 15:13         ` Krzysztof Kozlowski
2023-05-30 15:13           ` Krzysztof Kozlowski
2023-05-30 15:13           ` Krzysztof Kozlowski
2023-05-29  9:13 ` [PATCH v4 3/4] ARM: dts: stm32: fix dsi warnings on stm32mp15 boards Raphael Gallais-Pou
2023-05-29  9:13   ` Raphael Gallais-Pou
2023-05-29  9:13   ` Raphael Gallais-Pou
2023-05-29  9:51   ` Marek Vasut
2023-05-29  9:51     ` Marek Vasut
2023-05-29  9:51     ` Marek Vasut
2023-05-29  9:13 ` [PATCH v4 4/4] ARM: dts: stm32: fix ltdc warnings in " Raphael Gallais-Pou
2023-05-29  9:13   ` Raphael Gallais-Pou
2023-05-29  9:13   ` Raphael Gallais-Pou
2023-05-29  9:54   ` Marek Vasut
2023-05-29  9:54     ` Marek Vasut
2023-05-29  9:54     ` Marek Vasut
2023-05-30  8:19 ` [PATCH v4 0/4] STM32 warning cleanup Alexandre TORGUE
2023-05-30  8:19   ` Alexandre TORGUE
2023-05-30  8:19   ` Alexandre TORGUE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af31ae21-2711-2fac-e885-b3bbbcb12be8@foss.st.com \
    --to=raphael.gallais-pou@foss.st.com \
    --cc=airlied@gmail.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@dh-electronics.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=marex@denx.de \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=philippe.cornu@foss.st.com \
    --cc=robh+dt@kernel.org \
    --cc=yannick.fertre@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.