All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] thermal: imx_sc_thermal: Fix refcount leak in imx_sc_thermal_probe
@ 2022-05-16  7:31 ` Miaoqian Lin
  0 siblings, 0 replies; 4+ messages in thread
From: Miaoqian Lin @ 2022-05-16  7:31 UTC (permalink / raw)
  To: Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
	Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, Anson Huang, linux-pm, linux-arm-kernel,
	linux-kernel
  Cc: linmq006

of_find_node_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.

Fixes: e20db70dba1c ("thermal: imx_sc: add i.MX system controller thermal support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
 drivers/thermal/imx_sc_thermal.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c
index 8d76dbfde6a9..1ab854c228e5 100644
--- a/drivers/thermal/imx_sc_thermal.c
+++ b/drivers/thermal/imx_sc_thermal.c
@@ -95,6 +95,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
 		if (!sensor) {
 			of_node_put(child);
 			of_node_put(sensor_np);
+			of_node_put(np);
 			return -ENOMEM;
 		}
 
@@ -125,6 +126,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
 	}
 
 	of_node_put(sensor_np);
+	of_node_put(np);
 
 	return ret;
 }
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] thermal: imx_sc_thermal: Fix refcount leak in imx_sc_thermal_probe
@ 2022-05-16  7:31 ` Miaoqian Lin
  0 siblings, 0 replies; 4+ messages in thread
From: Miaoqian Lin @ 2022-05-16  7:31 UTC (permalink / raw)
  To: Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
	Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, Anson Huang, linux-pm, linux-arm-kernel,
	linux-kernel
  Cc: linmq006

of_find_node_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.

Fixes: e20db70dba1c ("thermal: imx_sc: add i.MX system controller thermal support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
 drivers/thermal/imx_sc_thermal.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c
index 8d76dbfde6a9..1ab854c228e5 100644
--- a/drivers/thermal/imx_sc_thermal.c
+++ b/drivers/thermal/imx_sc_thermal.c
@@ -95,6 +95,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
 		if (!sensor) {
 			of_node_put(child);
 			of_node_put(sensor_np);
+			of_node_put(np);
 			return -ENOMEM;
 		}
 
@@ -125,6 +126,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
 	}
 
 	of_node_put(sensor_np);
+	of_node_put(np);
 
 	return ret;
 }
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] thermal: imx_sc_thermal: Fix refcount leak in imx_sc_thermal_probe
  2022-05-16  7:31 ` Miaoqian Lin
@ 2022-05-16  9:58   ` Daniel Lezcano
  -1 siblings, 0 replies; 4+ messages in thread
From: Daniel Lezcano @ 2022-05-16  9:58 UTC (permalink / raw)
  To: Miaoqian Lin, Rafael J. Wysocki, Amit Kucheria, Zhang Rui,
	Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, Anson Huang, linux-pm, linux-arm-kernel,
	linux-kernel

On 16/05/2022 09:31, Miaoqian Lin wrote:
> of_find_node_by_name() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when done.
> Add missing of_node_put() to avoid refcount leak.
> 
> Fixes: e20db70dba1c ("thermal: imx_sc: add i.MX system controller thermal support")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
>   drivers/thermal/imx_sc_thermal.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c
> index 8d76dbfde6a9..1ab854c228e5 100644
> --- a/drivers/thermal/imx_sc_thermal.c
> +++ b/drivers/thermal/imx_sc_thermal.c
> @@ -95,6 +95,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
>   		if (!sensor) {
>   			of_node_put(child);
>   			of_node_put(sensor_np);
> +			of_node_put(np);
>   			return -ENOMEM;
>   		}


Please use goto statement

> @@ -125,6 +126,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
>   	}
>   
>   	of_node_put(sensor_np);
> +	of_node_put(np);
>   
>   	return ret;
>   }


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] thermal: imx_sc_thermal: Fix refcount leak in imx_sc_thermal_probe
@ 2022-05-16  9:58   ` Daniel Lezcano
  0 siblings, 0 replies; 4+ messages in thread
From: Daniel Lezcano @ 2022-05-16  9:58 UTC (permalink / raw)
  To: Miaoqian Lin, Rafael J. Wysocki, Amit Kucheria, Zhang Rui,
	Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, Anson Huang, linux-pm, linux-arm-kernel,
	linux-kernel

On 16/05/2022 09:31, Miaoqian Lin wrote:
> of_find_node_by_name() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when done.
> Add missing of_node_put() to avoid refcount leak.
> 
> Fixes: e20db70dba1c ("thermal: imx_sc: add i.MX system controller thermal support")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
>   drivers/thermal/imx_sc_thermal.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c
> index 8d76dbfde6a9..1ab854c228e5 100644
> --- a/drivers/thermal/imx_sc_thermal.c
> +++ b/drivers/thermal/imx_sc_thermal.c
> @@ -95,6 +95,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
>   		if (!sensor) {
>   			of_node_put(child);
>   			of_node_put(sensor_np);
> +			of_node_put(np);
>   			return -ENOMEM;
>   		}


Please use goto statement

> @@ -125,6 +126,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
>   	}
>   
>   	of_node_put(sensor_np);
> +	of_node_put(np);
>   
>   	return ret;
>   }


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-16 10:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-16  7:31 [PATCH] thermal: imx_sc_thermal: Fix refcount leak in imx_sc_thermal_probe Miaoqian Lin
2022-05-16  7:31 ` Miaoqian Lin
2022-05-16  9:58 ` Daniel Lezcano
2022-05-16  9:58   ` Daniel Lezcano

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.