* [PATCH] bcache: fix error return value in memory shrink
@ 2018-01-31 3:30 tang.junhui
2018-03-05 21:55 ` Michael Lyle
0 siblings, 1 reply; 2+ messages in thread
From: tang.junhui @ 2018-01-31 3:30 UTC (permalink / raw)
To: colyli, mlyle; +Cc: linux-bcache, linux-block, tang.junhui
From: Tang Junhui <tang.junhui@zte.com.cn>
In bch_mca_scan(), the return value should not be the number of freed btree
nodes, but the number of pages of freed btree nodes.
Signed-off-by: Tang Junhui <tang.junhui@zte.com.cn>
---
drivers/md/bcache/btree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
index 81e8dc3..a5fbccc 100644
--- a/drivers/md/bcache/btree.c
+++ b/drivers/md/bcache/btree.c
@@ -718,7 +718,7 @@ static unsigned long bch_mca_scan(struct shrinker *shrink,
}
out:
mutex_unlock(&c->bucket_lock);
- return freed;
+ return freed * c->btree_pages;
}
static unsigned long bch_mca_count(struct shrinker *shrink,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bcache: fix error return value in memory shrink
2018-01-31 3:30 [PATCH] bcache: fix error return value in memory shrink tang.junhui
@ 2018-03-05 21:55 ` Michael Lyle
0 siblings, 0 replies; 2+ messages in thread
From: Michael Lyle @ 2018-03-05 21:55 UTC (permalink / raw)
To: tang.junhui, colyli; +Cc: linux-bcache, linux-block
LGTM, applied
On 01/30/2018 07:30 PM, tang.junhui@zte.com.cn wrote:
> From: Tang Junhui <tang.junhui@zte.com.cn>
>
> In bch_mca_scan(), the return value should not be the number of freed btree
> nodes, but the number of pages of freed btree nodes.
>
> Signed-off-by: Tang Junhui <tang.junhui@zte.com.cn>
> ---
> drivers/md/bcache/btree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
> index 81e8dc3..a5fbccc 100644
> --- a/drivers/md/bcache/btree.c
> +++ b/drivers/md/bcache/btree.c
> @@ -718,7 +718,7 @@ static unsigned long bch_mca_scan(struct shrinker *shrink,
> }
> out:
> mutex_unlock(&c->bucket_lock);
> - return freed;
> + return freed * c->btree_pages;
> }
>
> static unsigned long bch_mca_count(struct shrinker *shrink,
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-05 21:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-31 3:30 [PATCH] bcache: fix error return value in memory shrink tang.junhui
2018-03-05 21:55 ` Michael Lyle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.