From: Casey Schaufler <casey@schaufler-ca.com> To: David Herrmann <dh.herrmann@gmail.com>, linux-kernel@vger.kernel.org Cc: James Morris <jmorris@namei.org>, Paul Moore <paul@paul-moore.com>, teg@jklm.no, Stephen Smalley <sds@tycho.nsa.gov>, selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org, Eric Paris <eparis@parisplace.org>, serge@hallyn.com, davem@davemloft.net, netdev@vger.kernel.org Subject: Re: [PATCH v2 4/4] smack: provide socketpair callback Date: Fri, 4 May 2018 15:01:19 -0700 [thread overview] Message-ID: <af4cf2cc-1335-557d-8790-633ff10371de@schaufler-ca.com> (raw) In-Reply-To: <20180504142822.15233-5-dh.herrmann@gmail.com> On 5/4/2018 7:28 AM, David Herrmann wrote: > From: Tom Gundersen <teg@jklm.no> > > Make sure to implement the new socketpair callback so the SO_PEERSEC > call on socketpair(2)s will return correct information. > > Signed-off-by: Tom Gundersen <teg@jklm.no> > Signed-off-by: David Herrmann <dh.herrmann@gmail.com> This doesn't look like it will cause any problems. I've only been able to test it in a general way. I haven't created specific tests, but it passes the usual Smack use cases. Acked-by: Casey Schaufler <casey@schaufler-ca.com> > --- > security/smack/smack_lsm.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c > index 0b414836bebd..dcb976f98df2 100644 > --- a/security/smack/smack_lsm.c > +++ b/security/smack/smack_lsm.c > @@ -2842,6 +2842,27 @@ static int smack_socket_post_create(struct socket *sock, int family, > return smack_netlabel(sock->sk, SMACK_CIPSO_SOCKET); > } > > +/** > + * smack_socket_socketpair - create socket pair > + * @socka: one socket > + * @sockb: another socket > + * > + * Cross reference the peer labels for SO_PEERSEC > + * > + * Returns 0 on success, and error code otherwise > + */ > +static int smack_socket_socketpair(struct socket *socka, > + struct socket *sockb) > +{ > + struct socket_smack *asp = socka->sk->sk_security; > + struct socket_smack *bsp = sockb->sk->sk_security; > + > + asp->smk_packet = bsp->smk_out; > + bsp->smk_packet = asp->smk_out; > + > + return 0; > +} > + > #ifdef SMACK_IPV6_PORT_LABELING > /** > * smack_socket_bind - record port binding information. > @@ -4724,6 +4745,7 @@ static struct security_hook_list smack_hooks[] __lsm_ro_after_init = { > LSM_HOOK_INIT(unix_may_send, smack_unix_may_send), > > LSM_HOOK_INIT(socket_post_create, smack_socket_post_create), > + LSM_HOOK_INIT(socket_socketpair, smack_socket_socketpair), > #ifdef SMACK_IPV6_PORT_LABELING > LSM_HOOK_INIT(socket_bind, smack_socket_bind), > #endif
WARNING: multiple messages have this Message-ID (diff)
From: casey@schaufler-ca.com (Casey Schaufler) To: linux-security-module@vger.kernel.org Subject: [PATCH v2 4/4] smack: provide socketpair callback Date: Fri, 4 May 2018 15:01:19 -0700 [thread overview] Message-ID: <af4cf2cc-1335-557d-8790-633ff10371de@schaufler-ca.com> (raw) In-Reply-To: <20180504142822.15233-5-dh.herrmann@gmail.com> On 5/4/2018 7:28 AM, David Herrmann wrote: > From: Tom Gundersen <teg@jklm.no> > > Make sure to implement the new socketpair callback so the SO_PEERSEC > call on socketpair(2)s will return correct information. > > Signed-off-by: Tom Gundersen <teg@jklm.no> > Signed-off-by: David Herrmann <dh.herrmann@gmail.com> This doesn't look like it will cause any problems. I've only been able to test it in a general way. I haven't created specific tests, but it passes the usual Smack use cases. Acked-by: Casey Schaufler <casey@schaufler-ca.com> > --- > security/smack/smack_lsm.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c > index 0b414836bebd..dcb976f98df2 100644 > --- a/security/smack/smack_lsm.c > +++ b/security/smack/smack_lsm.c > @@ -2842,6 +2842,27 @@ static int smack_socket_post_create(struct socket *sock, int family, > return smack_netlabel(sock->sk, SMACK_CIPSO_SOCKET); > } > > +/** > + * smack_socket_socketpair - create socket pair > + * @socka: one socket > + * @sockb: another socket > + * > + * Cross reference the peer labels for SO_PEERSEC > + * > + * Returns 0 on success, and error code otherwise > + */ > +static int smack_socket_socketpair(struct socket *socka, > + struct socket *sockb) > +{ > + struct socket_smack *asp = socka->sk->sk_security; > + struct socket_smack *bsp = sockb->sk->sk_security; > + > + asp->smk_packet = bsp->smk_out; > + bsp->smk_packet = asp->smk_out; > + > + return 0; > +} > + > #ifdef SMACK_IPV6_PORT_LABELING > /** > * smack_socket_bind - record port binding information. > @@ -4724,6 +4745,7 @@ static struct security_hook_list smack_hooks[] __lsm_ro_after_init = { > LSM_HOOK_INIT(unix_may_send, smack_unix_may_send), > > LSM_HOOK_INIT(socket_post_create, smack_socket_post_create), > + LSM_HOOK_INIT(socket_socketpair, smack_socket_socketpair), > #ifdef SMACK_IPV6_PORT_LABELING > LSM_HOOK_INIT(socket_bind, smack_socket_bind), > #endif -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-05-04 22:01 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-04 14:28 [PATCH v2 0/4] Introduce LSM-hook for socketpair(2) David Herrmann 2018-05-04 14:28 ` David Herrmann 2018-05-04 14:28 ` [PATCH v2 1/4] security: add hook for socketpair() David Herrmann 2018-05-04 14:28 ` David Herrmann 2018-05-04 14:28 ` [PATCH v2 2/4] net: hook socketpair() into LSM David Herrmann 2018-05-04 14:28 ` David Herrmann 2018-05-04 17:31 ` David Miller 2018-05-04 17:31 ` David Miller 2018-05-04 14:28 ` [PATCH v2 3/4] selinux: provide socketpair callback David Herrmann 2018-05-04 14:28 ` David Herrmann 2018-05-04 14:28 ` [PATCH v2 4/4] smack: " David Herrmann 2018-05-04 14:28 ` David Herrmann 2018-05-04 22:01 ` Casey Schaufler [this message] 2018-05-04 22:01 ` Casey Schaufler 2018-05-04 19:51 ` [PATCH v2 0/4] Introduce LSM-hook for socketpair(2) James Morris 2018-05-04 19:51 ` James Morris
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=af4cf2cc-1335-557d-8790-633ff10371de@schaufler-ca.com \ --to=casey@schaufler-ca.com \ --cc=davem@davemloft.net \ --cc=dh.herrmann@gmail.com \ --cc=eparis@parisplace.org \ --cc=jmorris@namei.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=paul@paul-moore.com \ --cc=sds@tycho.nsa.gov \ --cc=selinux@tycho.nsa.gov \ --cc=serge@hallyn.com \ --cc=teg@jklm.no \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.