From: John Garry <john.garry@huawei.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: <jslaby@suse.com>, <joel@jms.id.au>, <p.zabel@pengutronix.de>,
<arnd@arndb.de>, <fcooper@ti.com>,
<sergei.shtylyov@cogentembedded.com>,
<yamada.masahiro@socionext.com>, <khoroshilov@ispras.ru>,
<linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<andriy.shevchenko@linux.intel.com>, <linuxarm@huawei.com>
Subject: Re: [PATCH] serial: 8250_of: Add IO space support
Date: Mon, 23 Apr 2018 10:22:40 +0100 [thread overview]
Message-ID: <af71a628-d9c8-bfbd-5772-8fced7c51b6b@huawei.com> (raw)
In-Reply-To: <20180423081402.GA19169@kroah.com>
On 23/04/2018 09:14, Greg KH wrote:
> On Thu, Apr 19, 2018 at 11:37:48PM +0800, John Garry wrote:
>> Currently the 8250_of driver only supports MEM IO type
>> accesses.
>>
>> Some development boards (Huawei D03, specifically) require
>> IO space access for 8250-compatible OF driver support, so
>> add it.
>>
>> The modification is quite simple: just set the port iotype
>> and associated flags depending on the device address
>> resource type.
>>
>> Signed-off-by: John Garry <john.garry@huawei.com>
>
> This no longer applies to my tree due to a patch that was sent before
> yours that conflicts in the same area. Can you rebase it against my
> tty-testing branch and resend?
>
Hi Greg,
OK, I'll do that. I will also make this small improvement to this patch:
+ if ((resource.flags & IORESOURCE_TYPE_BITS) == IORESOURCE_IO) {
+ port->iotype = UPIO_PORT;
|
V
+ if (resource_type(&resource) == IORESOURCE_IO) {
+ port->iotype = UPIO_PORT;
All the best,
John
> thanks,
>
> greg k-h
>
> .
>
WARNING: multiple messages have this Message-ID (diff)
From: John Garry <john.garry@huawei.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: jslaby@suse.com, joel@jms.id.au, p.zabel@pengutronix.de,
arnd@arndb.de, fcooper@ti.com,
sergei.shtylyov@cogentembedded.com,
yamada.masahiro@socionext.com, khoroshilov@ispras.ru,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
andriy.shevchenko@linux.intel.com, linuxarm@huawei.com
Subject: Re: [PATCH] serial: 8250_of: Add IO space support
Date: Mon, 23 Apr 2018 10:22:40 +0100 [thread overview]
Message-ID: <af71a628-d9c8-bfbd-5772-8fced7c51b6b@huawei.com> (raw)
In-Reply-To: <20180423081402.GA19169@kroah.com>
On 23/04/2018 09:14, Greg KH wrote:
> On Thu, Apr 19, 2018 at 11:37:48PM +0800, John Garry wrote:
>> Currently the 8250_of driver only supports MEM IO type
>> accesses.
>>
>> Some development boards (Huawei D03, specifically) require
>> IO space access for 8250-compatible OF driver support, so
>> add it.
>>
>> The modification is quite simple: just set the port iotype
>> and associated flags depending on the device address
>> resource type.
>>
>> Signed-off-by: John Garry <john.garry@huawei.com>
>
> This no longer applies to my tree due to a patch that was sent before
> yours that conflicts in the same area. Can you rebase it against my
> tty-testing branch and resend?
>
Hi Greg,
OK, I'll do that. I will also make this small improvement to this patch:
+ if ((resource.flags & IORESOURCE_TYPE_BITS) == IORESOURCE_IO) {
+ port->iotype = UPIO_PORT;
|
V
+ if (resource_type(&resource) == IORESOURCE_IO) {
+ port->iotype = UPIO_PORT;
All the best,
John
> thanks,
>
> greg k-h
>
> .
>
next prev parent reply other threads:[~2018-04-23 9:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 15:37 [PATCH] serial: 8250_of: Add IO space support John Garry
2018-04-19 15:37 ` John Garry
2018-04-23 8:14 ` Greg KH
2018-04-23 9:22 ` John Garry [this message]
2018-04-23 9:22 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af71a628-d9c8-bfbd-5772-8fced7c51b6b@huawei.com \
--to=john.garry@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=fcooper@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=jslaby@suse.com \
--cc=khoroshilov@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=p.zabel@pengutronix.de \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.