* net-next: regression: patch "iwlwifi: acpi: move ppag code from mvm to fw/acpi" (e8e10a37c51c) breaks wifi
@ 2022-03-17 19:56 Oliver Hartkopp
2022-03-17 19:58 ` Johannes Berg
0 siblings, 1 reply; 6+ messages in thread
From: Oliver Hartkopp @ 2022-03-17 19:56 UTC (permalink / raw)
To: Johannes Berg, Matt Chen; +Cc: netdev, linux-wireless
Hi all,
the patch "iwlwifi: acpi: move ppag code from mvm to fw/acpi" (net-next
commit e8e10a37c51c) breaks the wifi on my HP Elitebook 840 G5.
I detected the problem when working on the latest net-next tree and the
wifi was fine until this patch.
Please let me know if you need support for testing.
Regards,
Oliver
[ 0.000000] Linux version 5.17.0-rc3-nn-01325-ge8e10a37c51c (xxx)
(gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian)
2.35.2) #15 SMP PREEMPT Thu Mar 17 20:41:21 CET 2022
(..)
[ 12.001911] cfg80211: Loading compiled-in X.509 certificates for
regulatory database
[ 12.029737] cfg80211: Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7'
[ 12.034170] cfg80211: loaded regulatory.db is malformed or signature
is missing/invalid
[ 12.086287] Bluetooth: Core ver 2.22
[ 12.087533] NET: Registered PF_BLUETOOTH protocol family
[ 12.090401] Bluetooth: HCI device and connection manager initialized
[ 12.090452] Bluetooth: HCI socket layer initialized
[ 12.090457] Bluetooth: L2CAP socket layer initialized
[ 12.090516] Bluetooth: SCO socket layer initialized
[ 12.136999] Intel(R) Wireless WiFi driver for Linux
[ 12.138353] iwlwifi 0000:01:00.0: enabling device (0000 -> 0002)
[ 12.144928] iwlwifi 0000:01:00.0: loaded firmware version
36.ad812ee0.0 8265-36.ucode op_mode iwlmvm
[ 12.224682] usbcore: registered new interface driver btusb
[ 12.248689] Bluetooth: hci0: Bootloader revision 0.0 build 26 week 38
2015
[ 12.250374] Bluetooth: hci0: Device revision is 16
[ 12.251288] Bluetooth: hci0: Secure boot is enabled
[ 12.252377] Bluetooth: hci0: OTP lock is enabled
[ 12.253229] Bluetooth: hci0: API lock is enabled
[ 12.254090] Bluetooth: hci0: Debug lock is disabled
[ 12.255009] Bluetooth: hci0: Minimum firmware build 1 week 10 2014
[ 12.260320] Bluetooth: hci0: Found device firmware: intel/ibt-12-16.sfi
[ 12.373476] iwlwifi 0000:01:00.0: Detected Intel(R) Dual Band
Wireless AC 8265, REV=0x230
[ 12.442732] iwlwifi 0000:01:00.0: base HW address: 48:89:e7:1b:ee:64,
OTP minor version: 0x0
[ 12.545287] intel_rapl_common: Found RAPL domain package
[ 12.545326] intel_rapl_common: Found RAPL domain core
[ 12.545350] intel_rapl_common: Found RAPL domain uncore
[ 12.545375] intel_rapl_common: Found RAPL domain psys
[ 12.545785] ieee80211 phy0: Selected rate control algorithm 'iwl-mvm-rs'
[ 12.850332] hp_wmi: query 0x4 returned error 0x5
[ 12.852738] hp_wmi: query 0xd returned error 0x5
[ 12.894436] input: HP WMI hotkeys as /devices/virtual/input/input23
[ 12.960086] hp_wmi: query 0x1b returned error 0x5
[ 13.053127] iwlwifi 0000:01:00.0 wlp1s0: renamed from wlan0
[ 13.114622] Bluetooth: BNEP (Ethernet Emulation) ver 1.3
[ 13.114625] Bluetooth: BNEP filters: protocol multicast
[ 13.114631] Bluetooth: BNEP socket layer initialized
[ 13.811222] Bluetooth: hci0: Waiting for firmware download to complete
[ 13.811636] Bluetooth: hci0: Firmware loaded in 1514074 usecs
[ 13.812493] Bluetooth: hci0: Waiting for device to boot
[ 13.824416] Bluetooth: hci0: Device booted in 12199 usecs
[ 13.824418] Bluetooth: hci0: Malformed MSFT vendor event: 0x02
[ 13.824806] Bluetooth: hci0: Found Intel DDC parameters:
intel/ibt-12-16.ddc
[ 13.827429] Bluetooth: hci0: Applying Intel DDC parameters completed
[ 13.828449] Bluetooth: hci0: Firmware revision 0.1 build 50 week 12 2019
[ 13.845837] iwlwifi 0000:01:00.0: mac start retry 0
[ 13.895993] NET: Registered PF_ALG protocol family
[ 14.100027] iwlwifi 0000:01:00.0: mac start retry 1
[ 14.349522] iwlwifi 0000:01:00.0: mac start retry 2
[ 14.594141] iwlwifi 0000:01:00.0: mac start retry 0
[ 14.835957] iwlwifi 0000:01:00.0: mac start retry 1
[ 15.075966] iwlwifi 0000:01:00.0: mac start retry 2
[ 15.326159] iwlwifi 0000:01:00.0: mac start retry 0
[ 15.568003] iwlwifi 0000:01:00.0: mac start retry 1
[ 15.570772] Bluetooth: RFCOMM TTY layer initialized
[ 15.570784] Bluetooth: RFCOMM socket layer initialized
[ 15.570800] Bluetooth: RFCOMM ver 1.11
[ 15.832467] iwlwifi 0000:01:00.0: mac start retry 2
[ 16.109220] iwlwifi 0000:01:00.0: mac start retry 0
[ 16.378910] iwlwifi 0000:01:00.0: mac start retry 1
[ 16.646092] iwlwifi 0000:01:00.0: mac start retry 2
[ 27.288232] iwlwifi 0000:01:00.0: mac start retry 0
[ 27.553616] iwlwifi 0000:01:00.0: mac start retry 1
[ 27.818481] iwlwifi 0000:01:00.0: mac start retry 2
[ 28.088457] iwlwifi 0000:01:00.0: mac start retry 0
[ 28.354671] iwlwifi 0000:01:00.0: mac start retry 1
[ 28.620348] iwlwifi 0000:01:00.0: mac start retry 2
[ 39.290524] iwlwifi 0000:01:00.0: mac start retry 0
[ 39.554416] iwlwifi 0000:01:00.0: mac start retry 1
[ 39.820355] iwlwifi 0000:01:00.0: mac start retry 2
[ 40.085494] iwlwifi 0000:01:00.0: mac start retry 0
[ 40.348142] iwlwifi 0000:01:00.0: mac start retry 1
[ 40.614622] iwlwifi 0000:01:00.0: mac start retry 2
[ 51.296158] iwlwifi 0000:01:00.0: mac start retry 0
[ 51.564189] iwlwifi 0000:01:00.0: mac start retry 1
[ 51.832335] iwlwifi 0000:01:00.0: mac start retry 2
[ 52.100712] iwlwifi 0000:01:00.0: mac start retry 0
[ 52.366818] iwlwifi 0000:01:00.0: mac start retry 1
[ 52.630498] iwlwifi 0000:01:00.0: mac start retry 2
[ 63.300472] iwlwifi 0000:01:00.0: mac start retry 0
[ 63.570028] iwlwifi 0000:01:00.0: mac start retry 1
[ 63.836321] iwlwifi 0000:01:00.0: mac start retry 2
[ 64.107436] iwlwifi 0000:01:00.0: mac start retry 0
[ 64.377235] iwlwifi 0000:01:00.0: mac start retry 1
[ 64.646305] iwlwifi 0000:01:00.0: mac start retry 2
[ 75.298137] iwlwifi 0000:01:00.0: mac start retry 0
[ 75.564421] iwlwifi 0000:01:00.0: mac start retry 1
[ 75.829962] iwlwifi 0000:01:00.0: mac start retry 2
[ 76.102979] iwlwifi 0000:01:00.0: mac start retry 0
[ 76.372426] iwlwifi 0000:01:00.0: mac start retry 1
[ 76.641806] iwlwifi 0000:01:00.0: mac start retry 2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: net-next: regression: patch "iwlwifi: acpi: move ppag code from mvm to fw/acpi" (e8e10a37c51c) breaks wifi
2022-03-17 19:56 net-next: regression: patch "iwlwifi: acpi: move ppag code from mvm to fw/acpi" (e8e10a37c51c) breaks wifi Oliver Hartkopp
@ 2022-03-17 19:58 ` Johannes Berg
2022-03-17 20:31 ` Oliver Hartkopp
2022-03-18 17:21 ` Jakub Kicinski
0 siblings, 2 replies; 6+ messages in thread
From: Johannes Berg @ 2022-03-17 19:58 UTC (permalink / raw)
To: Oliver Hartkopp, Matt Chen; +Cc: netdev, linux-wireless
On Thu, 2022-03-17 at 20:56 +0100, Oliver Hartkopp wrote:
> Hi all,
>
> the patch "iwlwifi: acpi: move ppag code from mvm to fw/acpi" (net-next
> commit e8e10a37c51c) breaks the wifi on my HP Elitebook 840 G5.
>
> I detected the problem when working on the latest net-next tree and the
> wifi was fine until this patch.
>
Something like this should get submitted soon:
https://p.sipsolutions.net/3b84353278ed68c6.txt
johannes
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: net-next: regression: patch "iwlwifi: acpi: move ppag code from mvm to fw/acpi" (e8e10a37c51c) breaks wifi
2022-03-17 19:58 ` Johannes Berg
@ 2022-03-17 20:31 ` Oliver Hartkopp
2022-03-18 17:21 ` Jakub Kicinski
1 sibling, 0 replies; 6+ messages in thread
From: Oliver Hartkopp @ 2022-03-17 20:31 UTC (permalink / raw)
To: Johannes Berg, Matt Chen; +Cc: netdev, linux-wireless
Hi Johannes,
On 17.03.22 20:58, Johannes Berg wrote:
> On Thu, 2022-03-17 at 20:56 +0100, Oliver Hartkopp wrote:
>> Hi all,
>>
>> the patch "iwlwifi: acpi: move ppag code from mvm to fw/acpi" (net-next
>> commit e8e10a37c51c) breaks the wifi on my HP Elitebook 840 G5.
>>
>> I detected the problem when working on the latest net-next tree and the
>> wifi was fine until this patch.
>>
Thanks for the fast reply!
> Something like this should get submitted soon:
> https://p.sipsolutions.net/3b84353278ed68c6.txt
I applied this patch on the latest net-next tree:
patching file drivers/net/wireless/intel/iwlwifi/mvm/fw.c
Hunk #1 succeeded at 1015 (offset -114 lines).
And it fixed the wifi issue with my system! \o/
Tested-by: Oliver Hartkopp <socketcan@hartkopp.net>
Thanks & best regards,
Oliver
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: net-next: regression: patch "iwlwifi: acpi: move ppag code from mvm to fw/acpi" (e8e10a37c51c) breaks wifi
2022-03-17 19:58 ` Johannes Berg
2022-03-17 20:31 ` Oliver Hartkopp
@ 2022-03-18 17:21 ` Jakub Kicinski
2022-03-21 18:46 ` Johannes Berg
1 sibling, 1 reply; 6+ messages in thread
From: Jakub Kicinski @ 2022-03-18 17:21 UTC (permalink / raw)
To: Johannes Berg; +Cc: Oliver Hartkopp, Matt Chen, netdev, linux-wireless
On Thu, 17 Mar 2022 20:58:46 +0100 Johannes Berg wrote:
> On Thu, 2022-03-17 at 20:56 +0100, Oliver Hartkopp wrote:
> > Hi all,
> >
> > the patch "iwlwifi: acpi: move ppag code from mvm to fw/acpi" (net-next
> > commit e8e10a37c51c) breaks the wifi on my HP Elitebook 840 G5.
> >
> > I detected the problem when working on the latest net-next tree and the
> > wifi was fine until this patch.
> >
>
> Something like this should get submitted soon:
> https://p.sipsolutions.net/3b84353278ed68c6.txt
Hi Johannes, we're readying up for the merge window, feels like this
may be something we want fixed before we ship net-next off to Linus.
Do you have an ETA on the fix? Am I overestimating the importance?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: net-next: regression: patch "iwlwifi: acpi: move ppag code from mvm to fw/acpi" (e8e10a37c51c) breaks wifi
2022-03-18 17:21 ` Jakub Kicinski
@ 2022-03-21 18:46 ` Johannes Berg
2022-03-22 12:21 ` Luca Coelho
0 siblings, 1 reply; 6+ messages in thread
From: Johannes Berg @ 2022-03-21 18:46 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Oliver Hartkopp, Matt Chen, netdev, linux-wireless, Luca Coelho
Hi,
On Fri, 2022-03-18 at 10:21 -0700, Jakub Kicinski wrote:
>
> Hi Johannes, we're readying up for the merge window, feels like this
> may be something we want fixed before we ship net-next off to Linus.
> Do you have an ETA on the fix? Am I overestimating the importance?
>
Hm, right. Depends on the machine if you need it or not!
Luca, any thoughts? Can we send out the patch quickly?
johannes
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: net-next: regression: patch "iwlwifi: acpi: move ppag code from mvm to fw/acpi" (e8e10a37c51c) breaks wifi
2022-03-21 18:46 ` Johannes Berg
@ 2022-03-22 12:21 ` Luca Coelho
0 siblings, 0 replies; 6+ messages in thread
From: Luca Coelho @ 2022-03-22 12:21 UTC (permalink / raw)
To: Johannes Berg, Jakub Kicinski
Cc: Oliver Hartkopp, Matt Chen, netdev, linux-wireless
On Mon, 2022-03-21 at 19:46 +0100, Johannes Berg wrote:
> Hi,
>
> On Fri, 2022-03-18 at 10:21 -0700, Jakub Kicinski wrote:
> >
> > Hi Johannes, we're readying up for the merge window, feels like this
> > may be something we want fixed before we ship net-next off to Linus.
> > Do you have an ETA on the fix? Am I overestimating the importance?
> >
> Hm, right. Depends on the machine if you need it or not!
>
> Luca, any thoughts? Can we send out the patch quickly?
Hmmm, I think we should get it in asap. Not all machines will have
this issue, but the ones that do will not have a working WiFi...
I'll send Miri's patch that fixes this issue soon.
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-22 12:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-17 19:56 net-next: regression: patch "iwlwifi: acpi: move ppag code from mvm to fw/acpi" (e8e10a37c51c) breaks wifi Oliver Hartkopp
2022-03-17 19:58 ` Johannes Berg
2022-03-17 20:31 ` Oliver Hartkopp
2022-03-18 17:21 ` Jakub Kicinski
2022-03-21 18:46 ` Johannes Berg
2022-03-22 12:21 ` Luca Coelho
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.