All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] rockchip: clk: add clocks to px30_clk_enable
@ 2022-03-25 17:09 Chris Morgan
  2022-03-28 12:39 ` Kever Yang
  0 siblings, 1 reply; 2+ messages in thread
From: Chris Morgan @ 2022-03-25 17:09 UTC (permalink / raw)
  To: u-boot; +Cc: kever.yang, philipp.tomsich, sjg, seanga2, lukma, Chris Morgan

From: Chris Morgan <macromorgan@hotmail.com>

Add the HCLK_OTG, HCLK_SFC, and SCLK_SFC clocks to px30_clk_enable.
Without this change U-Boot reports an error of "Enable
clock-controller@ff2b0000 failed" on boot when using the SFC or USB in
U-Boot.

Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
 drivers/clk/rockchip/clk_px30.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/clk/rockchip/clk_px30.c b/drivers/clk/rockchip/clk_px30.c
index ea874e3f4b..5d467447a1 100644
--- a/drivers/clk/rockchip/clk_px30.c
+++ b/drivers/clk/rockchip/clk_px30.c
@@ -1403,10 +1403,13 @@ static int px30_clk_enable(struct clk *clk)
 {
 	switch (clk->id) {
 	case HCLK_HOST:
+	case HCLK_OTG:
+	case HCLK_SFC:
 	case SCLK_GMAC:
 	case SCLK_GMAC_RX_TX:
 	case SCLK_MAC_REF:
 	case SCLK_MAC_REFOUT:
+	case SCLK_SFC:
 	case ACLK_GMAC:
 	case PCLK_GMAC:
 	case SCLK_GMAC_RMII:
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] rockchip: clk: add clocks to px30_clk_enable
  2022-03-25 17:09 [PATCH] rockchip: clk: add clocks to px30_clk_enable Chris Morgan
@ 2022-03-28 12:39 ` Kever Yang
  0 siblings, 0 replies; 2+ messages in thread
From: Kever Yang @ 2022-03-28 12:39 UTC (permalink / raw)
  To: Chris Morgan, u-boot; +Cc: philipp.tomsich, sjg, seanga2, lukma, Chris Morgan

Hi Chris,

     Thanks for your patch.

On 2022/3/26 01:09, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Add the HCLK_OTG, HCLK_SFC, and SCLK_SFC clocks to px30_clk_enable.
> Without this change U-Boot reports an error of "Enable
> clock-controller@ff2b0000 failed" on boot when using the SFC or USB in
> U-Boot.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   drivers/clk/rockchip/clk_px30.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/clk/rockchip/clk_px30.c b/drivers/clk/rockchip/clk_px30.c
> index ea874e3f4b..5d467447a1 100644
> --- a/drivers/clk/rockchip/clk_px30.c
> +++ b/drivers/clk/rockchip/clk_px30.c
> @@ -1403,10 +1403,13 @@ static int px30_clk_enable(struct clk *clk)
>   {
>   	switch (clk->id) {
>   	case HCLK_HOST:
> +	case HCLK_OTG:
> +	case HCLK_SFC:
>   	case SCLK_GMAC:
>   	case SCLK_GMAC_RX_TX:
>   	case SCLK_MAC_REF:
>   	case SCLK_MAC_REFOUT:
> +	case SCLK_SFC:
>   	case ACLK_GMAC:
>   	case PCLK_GMAC:
>   	case SCLK_GMAC_RMII:

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-28 12:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-25 17:09 [PATCH] rockchip: clk: add clocks to px30_clk_enable Chris Morgan
2022-03-28 12:39 ` Kever Yang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.