* [PATCH] mmc/sdhci-spear: Don't set power gpio to 1 on probe
@ 2011-09-12 11:22 Viresh Kumar
2011-09-21 17:55 ` Chris Ball
0 siblings, 1 reply; 2+ messages in thread
From: Viresh Kumar @ 2011-09-12 11:22 UTC (permalink / raw)
To: akpm, linux-mmc
Cc: armando.visconti, shiraz.hashim, vipin.kumar, rajeev-dlh.kumar,
deepak.sikri, vipulkumar.samar, amit.virdi, viresh.kumar,
pratyush.anand, bhupesh.sharma, viresh.linux, bhavna.yadav
Currently if card_power_gpio is passed from platform data, it is acquired and
its value is either set or reset. After that its value is written 1, which is
not required.
So, this patch removes this extra line while sets its value.
Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
---
drivers/mmc/host/sdhci-spear.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
index a152b5c..63cc8b6 100644
--- a/drivers/mmc/host/sdhci-spear.c
+++ b/drivers/mmc/host/sdhci-spear.c
@@ -178,8 +178,6 @@ static int __devinit sdhci_probe(struct platform_device *pdev)
sdhci->data->card_power_gpio);
goto err_pgpio_direction;
}
-
- gpio_set_value(sdhci->data->card_power_gpio, 1);
}
if (sdhci->data->card_int_gpio >= 0) {
--
1.7.2.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc/sdhci-spear: Don't set power gpio to 1 on probe
2011-09-12 11:22 [PATCH] mmc/sdhci-spear: Don't set power gpio to 1 on probe Viresh Kumar
@ 2011-09-21 17:55 ` Chris Ball
0 siblings, 0 replies; 2+ messages in thread
From: Chris Ball @ 2011-09-21 17:55 UTC (permalink / raw)
To: Viresh Kumar
Cc: akpm, linux-mmc, armando.visconti, shiraz.hashim, vipin.kumar,
rajeev-dlh.kumar, deepak.sikri, vipulkumar.samar, amit.virdi,
pratyush.anand, bhupesh.sharma, viresh.linux, bhavna.yadav
Hi Viresh,
On Mon, Sep 12 2011, Viresh Kumar wrote:
> Currently if card_power_gpio is passed from platform data, it is acquired and
> its value is either set or reset. After that its value is written 1, which is
> not required.
>
> So, this patch removes this extra line while sets its value.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
Pushed to mmc-next for 3.2, thanks.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-21 17:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-12 11:22 [PATCH] mmc/sdhci-spear: Don't set power gpio to 1 on probe Viresh Kumar
2011-09-21 17:55 ` Chris Ball
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.