* Issue with vl.c: move -m parsing after memory backends has been processed. Commit a1b18df9a4848fc8a906e40c275063bfe9ca2047
@ 2020-02-26 7:36 Howard Spoelstra
2020-02-26 11:38 ` BALATON Zoltan
0 siblings, 1 reply; 3+ messages in thread
From: Howard Spoelstra @ 2020-02-26 7:36 UTC (permalink / raw)
To: qemu-ppc, qemu-devel qemu-devel, Paolo Bonzini, David Gibson
[-- Attachment #1: Type: text/plain, Size: 1503 bytes --]
Hi all,
Commit a1b18df9a4848fc8a906e40c275063bfe9ca2047 on the ppc-for-50 branch
makes qemu-system-ppc running Mac OS 9 extremely slow. I bisected to the
result below.
Command line used:
./qemu-system-ppc -L pc-bios -M mac99,via=pmu -m 512 -boot c \
-hda 9.2.img \
-serial stdio -sdl
Best,
Howard
a1b18df9a4848fc8a906e40c275063bfe9ca2047 is the first bad commit
commit a1b18df9a4848fc8a906e40c275063bfe9ca2047
Author: Igor Mammedov <imammedo@redhat.com>
Date: Wed Feb 19 11:08:40 2020 -0500
vl.c: move -m parsing after memory backends has been processed
It will be possible for main RAM to come from memory-backend
and we should check that size specified in -m matches the size
of the backend and [MachineState::]ram_size also matches
backend's size.
However -m parsing (set_memory_options()) happens before backends
are intialized (object_create_delayed()) which complicates it.
Consolidate set_memory_options() and assigning parsed results to
current_machine after backends are initialized, so it would be
possible access the initialized backend instance to compare
sizes.
This patch only consolidates scattered places touching ram_size
within vl.c. And follow up patch will integrate backend handling
to set_memory_options().
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20200219160953.13771-7-imammedo@redhat.com>
vl.c | 27 ++++++++++++++-------------
1 file changed, 14 insertions(+), 13 deletions(-)
[-- Attachment #2: Type: text/html, Size: 1978 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Issue with vl.c: move -m parsing after memory backends has been processed. Commit a1b18df9a4848fc8a906e40c275063bfe9ca2047
2020-02-26 7:36 Issue with vl.c: move -m parsing after memory backends has been processed. Commit a1b18df9a4848fc8a906e40c275063bfe9ca2047 Howard Spoelstra
@ 2020-02-26 11:38 ` BALATON Zoltan
2020-02-27 10:02 ` Howard Spoelstra
0 siblings, 1 reply; 3+ messages in thread
From: BALATON Zoltan @ 2020-02-26 11:38 UTC (permalink / raw)
To: Howard Spoelstra
Cc: Paolo Bonzini, Igor Mammedov, qemu-ppc, qemu-devel qemu-devel,
David Gibson
Hello,
On Wed, 26 Feb 2020, Howard Spoelstra wrote:
> Hi all,
>
> Commit a1b18df9a4848fc8a906e40c275063bfe9ca2047 on the ppc-for-50 branch
> makes qemu-system-ppc running Mac OS 9 extremely slow. I bisected to the
> result below.
>
> Command line used:
> ./qemu-system-ppc -L pc-bios -M mac99,via=pmu -m 512 -boot c \
> -hda 9.2.img \
> -serial stdio -sdl
>
> Best,
> Howard
>
> a1b18df9a4848fc8a906e40c275063bfe9ca2047 is the first bad commit
> commit a1b18df9a4848fc8a906e40c275063bfe9ca2047
> Author: Igor Mammedov <imammedo@redhat.com>
Isn't this the same as what's discussed in
https://lists.nongnu.org/archive/html/qemu-devel/2020-02/msg07229.html
Regards,
BALATON Zoltan
> Date: Wed Feb 19 11:08:40 2020 -0500
>
> vl.c: move -m parsing after memory backends has been processed
>
> It will be possible for main RAM to come from memory-backend
> and we should check that size specified in -m matches the size
> of the backend and [MachineState::]ram_size also matches
> backend's size.
>
> However -m parsing (set_memory_options()) happens before backends
> are intialized (object_create_delayed()) which complicates it.
> Consolidate set_memory_options() and assigning parsed results to
> current_machine after backends are initialized, so it would be
> possible access the initialized backend instance to compare
> sizes.
>
> This patch only consolidates scattered places touching ram_size
> within vl.c. And follow up patch will integrate backend handling
> to set_memory_options().
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Message-Id: <20200219160953.13771-7-imammedo@redhat.com>
>
> vl.c | 27 ++++++++++++++-------------
> 1 file changed, 14 insertions(+), 13 deletions(-)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Issue with vl.c: move -m parsing after memory backends has been processed. Commit a1b18df9a4848fc8a906e40c275063bfe9ca2047
2020-02-26 11:38 ` BALATON Zoltan
@ 2020-02-27 10:02 ` Howard Spoelstra
0 siblings, 0 replies; 3+ messages in thread
From: Howard Spoelstra @ 2020-02-27 10:02 UTC (permalink / raw)
To: BALATON Zoltan
Cc: Paolo Bonzini, Igor Mammedov, qemu-ppc, qemu-devel qemu-devel,
David Gibson
[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]
On Wed, Feb 26, 2020 at 12:38 PM BALATON Zoltan <balaton@eik.bme.hu> wrote:
> Hello,
>
> On Wed, 26 Feb 2020, Howard Spoelstra wrote:
> > Hi all,
> >
> > Commit a1b18df9a4848fc8a906e40c275063bfe9ca2047 on the ppc-for-50 branch
> > makes qemu-system-ppc running Mac OS 9 extremely slow. I bisected to the
> > result below.
> >
> > Command line used:
> > ./qemu-system-ppc -L pc-bios -M mac99,via=pmu -m 512 -boot c \
> > -hda 9.2.img \
> > -serial stdio -sdl
> >
> > Best,
> > Howard
> >
> > a1b18df9a4848fc8a906e40c275063bfe9ca2047 is the first bad commit
> > commit a1b18df9a4848fc8a906e40c275063bfe9ca2047
> > Author: Igor Mammedov <imammedo@redhat.com>
>
> Isn't this the same as what's discussed in
>
> https://lists.nongnu.org/archive/html/qemu-devel/2020-02/msg07229.html
>
> Regards,
> BALATON Zoltan
>
> Yes, this refers to the same issue. I responded there too with reference
to the bisection result I got.
As it is being dealt with, there is no further need to follow up on this
particular report..
Best,
Howard
[-- Attachment #2: Type: text/html, Size: 1717 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-27 10:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-26 7:36 Issue with vl.c: move -m parsing after memory backends has been processed. Commit a1b18df9a4848fc8a906e40c275063bfe9ca2047 Howard Spoelstra
2020-02-26 11:38 ` BALATON Zoltan
2020-02-27 10:02 ` Howard Spoelstra
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.