* [Qemu-devel] [PATCH] call make with quite-command
@ 2009-08-29 0:40 Juan Quintela
2009-08-30 18:14 ` Johannes Schindelin
0 siblings, 1 reply; 4+ messages in thread
From: Juan Quintela @ 2009-08-29 0:40 UTC (permalink / raw)
To: qemu-devel; +Cc: aliguori
On top of new config series. Remove the make directory printing.
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
Makefile | 3 ++-
Makefile.target | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 1befee0..236fb03 100644
--- a/Makefile
+++ b/Makefile
@@ -28,6 +28,7 @@ DOCS=
endif
SUBDIR_DEVICES_MAK=$(patsubst %, %/config-devices.mak, $(TARGET_DIRS))
+SUBDIR_MAKEFLAGS=$(if $(V),,--no-print-directory)
config-all-devices.mak: $(SUBDIR_DEVICES_MAK)
$(call quiet-command,grep "=y$$" $(SUBDIR_DEVICES_MAK) | sort -u > $@," GEN $@")
@@ -35,7 +36,7 @@ config-all-devices.mak: $(SUBDIR_DEVICES_MAK)
include config-all-devices.mak
build-all: config-host.h
- $(MAKE) $(TOOLS) $(DOCS) recurse-all
+ $(call quiet-command, $(MAKE) $(SUBDIR_MAKEFLAGS) $(TOOLS) $(DOCS) recurse-all,)
config-host.h: config-host.h-timestamp
config-host.h-timestamp: config-host.mak
diff --git a/Makefile.target b/Makefile.target
index d244f7a..f1887e2 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -31,7 +31,7 @@ config-target.h: config-target.h-timestamp
config-target.h-timestamp: config-target.mak
all: config-target.h
- $(MAKE) $(PROGS)
+ $(call quiet-command, $(MAKE) $(PROGS),)
# Dummy command so that make thinks it has done something
@true
--
1.6.2.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] call make with quite-command
2009-08-29 0:40 [Qemu-devel] [PATCH] call make with quite-command Juan Quintela
@ 2009-08-30 18:14 ` Johannes Schindelin
2009-08-30 20:05 ` [Qemu-devel] " Juan Quintela
0 siblings, 1 reply; 4+ messages in thread
From: Johannes Schindelin @ 2009-08-30 18:14 UTC (permalink / raw)
To: Juan Quintela; +Cc: aliguori, qemu-devel
Hi,
"quite command"?
On Sat, 29 Aug 2009, Juan Quintela wrote:
> + $(call quiet-command, $(MAKE) $(SUBDIR_MAKEFLAGS) $(TOOLS) $(DOCS) recurse-all,)
Ah. "quiet" command.
How dependent is that on GNU make?
Ciao,
Dscho
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Qemu-devel] Re: [PATCH] call make with quite-command
2009-08-30 18:14 ` Johannes Schindelin
@ 2009-08-30 20:05 ` Juan Quintela
2009-08-31 6:50 ` Paolo Bonzini
0 siblings, 1 reply; 4+ messages in thread
From: Juan Quintela @ 2009-08-30 20:05 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: aliguori, qemu-devel
Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
> "quite command"?
>
> On Sat, 29 Aug 2009, Juan Quintela wrote:
>
>> + $(call quiet-command, $(MAKE) $(SUBDIR_MAKEFLAGS) $(TOOLS) $(DOCS) recurse-all,)
>
> Ah. "quiet" command.
>
> How dependent is that on GNU make?
I hope nothing.
quiet-command = $(if $(V),$1,$(if $(2),@echo $2 && $1, @$1))
that is its definition. I hope/guess that $(if ...) is normal make.
Humm, looking at POSIX, it appears that they don't have functions at
all, but they don't have % rules either :p
Later, Juan.
> Ciao,
> Dscho
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Qemu-devel] Re: [PATCH] call make with quite-command
2009-08-30 20:05 ` [Qemu-devel] " Juan Quintela
@ 2009-08-31 6:50 ` Paolo Bonzini
0 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2009-08-31 6:50 UTC (permalink / raw)
To: Juan Quintela; +Cc: aliguori, qemu-devel
On 08/30/2009 10:05 PM, Juan Quintela wrote:
> Johannes Schindelin<Johannes.Schindelin@gmx.de> wrote:
>> Hi,
>>
>> "quite command"?
>>
>> On Sat, 29 Aug 2009, Juan Quintela wrote:
>>
>>> + $(call quiet-command, $(MAKE) $(SUBDIR_MAKEFLAGS) $(TOOLS) $(DOCS) recurse-all,)
>>
>> Ah. "quiet" command.
>>
>> How dependent is that on GNU make?
>
> I hope nothing.
Actually, very. :-) But anyway qemu does not compile without GNU make.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-08-31 6:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-29 0:40 [Qemu-devel] [PATCH] call make with quite-command Juan Quintela
2009-08-30 18:14 ` Johannes Schindelin
2009-08-30 20:05 ` [Qemu-devel] " Juan Quintela
2009-08-31 6:50 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.