All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Walmsley <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>
To: Felipe Balbi <me-uiRdBs8odbtmTBlB0Cgj/Q@public.gmane.org>
Cc: Ari Kauppi
	<Ext-Ari.Kauppi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>,
	Ben Dooks <ben-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>,
	ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] i2c: i2c-omap: Call request_irq with IRQF_DISABLED
Date: Wed, 11 Mar 2009 21:30:50 -0600 (MDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.0903112118140.26959@utopia.booyaka.com> (raw)
In-Reply-To: <20090312002353.GD19038@gandalf>

Hi Felipe,

On Thu, 12 Mar 2009, Felipe Balbi wrote:

> This is the link where Ingo discusses why !IRQF_DISABLED could cause
> stack overflow:
> 
> http://lkml.org/lkml/2009/3/3/71
> 
> You probably wanna take a look at the whole thread to figure out the
> discussion, but basically Ingo and Peter (Zijlstra) believe
> !IRQF_DISABLED is a bug and drivers needing that probably should be
> using threaded irqs (which is not yet merged) or the hw is broken, and
> for those an IRQF_ENABLED flag will be created and a TAINT will also be
> placed.
> 
> Once that gets merged, all drivers will be forced (at some point) to
> IRQF_DISABLED and those which don't want that will be moved gradually to
> threaded irq.
> 
> This patch is also interesting:
> 
> http://lkml.org/lkml/2009/3/2/33

Thanks for the links.  Those issues are indeed distinct from the spurious 
IRQ problem that Ari is reporting.


- Paul

  reply	other threads:[~2009-03-12  3:30 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-06 13:34 [PATCH 0/2] i2c: i2c-omap: Reliablity and register fixes Ari Kauppi
     [not found] ` <cover.1236345858.git.Ext-Ari.Kauppi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2009-03-06 13:34   ` [PATCH 1/2] i2c: i2c-omap: Fix BUFSTAT_REG reading Ari Kauppi
2009-03-06 13:34 ` [PATCH 2/2] i2c: i2c-omap: Call request_irq with IRQF_DISABLED Ari Kauppi
     [not found]   ` <7d7e7dd1a4c64c732a21bdfcf2bd42556be708c3.1236345858.git.Ext-Ari.Kauppi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2009-03-06 14:54     ` Woodruff, Richard
2009-03-10  0:52     ` Ben Dooks
2009-03-11 19:16       ` Felipe Balbi
2009-03-11 23:55       ` Paul Walmsley
     [not found]         ` <alpine.DEB.2.00.0903111741270.26959-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
2009-03-11 23:59           ` Felipe Balbi
2009-03-12  0:07             ` Paul Walmsley
     [not found]               ` <alpine.DEB.2.00.0903111804510.26959-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
2009-03-12  0:20                 ` Kevin Hilman
2009-03-12  0:23               ` Felipe Balbi
2009-03-12  3:30                 ` Paul Walmsley [this message]
2009-03-12  0:11             ` Felipe Contreras
2009-03-12  0:25               ` Felipe Balbi
2009-03-12  1:28             ` David Brownell
2009-03-12  0:04           ` Paul Walmsley
2009-03-12  6:26             ` Kauppi Ari (EXT-Ixonos/Oulu)
2009-03-12  6:46               ` Paul Walmsley
2009-03-12  7:54                 ` Kauppi Ari (EXT-Ixonos/Oulu)
2009-03-12  9:58                   ` Paul Walmsley
     [not found]                     ` <alpine.DEB.2.00.0903120356230.26959-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
2009-03-12 11:33                       ` Kauppi Ari (EXT-Ixonos/Oulu)
2009-03-12 15:04                         ` Woodruff, Richard
2009-03-13  0:04                         ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.0903112118140.26959@utopia.booyaka.com \
    --to=paul-dwxlp4yu+b8avxtiumwx3w@public.gmane.org \
    --cc=Ext-Ari.Kauppi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org \
    --cc=ben-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org \
    --cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=me-uiRdBs8odbtmTBlB0Cgj/Q@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.