All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Walmsley <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>
To: "Kauppi Ari (EXT-Ixonos/Oulu)"
	<ext-ari.kauppi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
Cc: Ben Dooks <ben-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>,
	"ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org"
	<ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
	"linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/2] i2c: i2c-omap: Call request_irq with IRQF_DISABLED
Date: Thu, 12 Mar 2009 00:46:49 -0600 (MDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.0903120041020.26959@utopia.booyaka.com> (raw)
In-Reply-To: <1236839178.6478.40.camel@kauppi-desktop>

Hello Ari,

On Thu, 12 Mar 2009, Kauppi Ari (EXT-Ixonos/Oulu) wrote:

> I was seeing some Spurious irq's for the I2C1 (IRQ 56).
> 
> I'm aware of flushing posted write and the very first thing I tried was
> to use read-after-write for OMAP_I2C_STAT_REG (in all applicable
> places). However, it didn't make any difference.

Strange.

> Applying Richard Woodruff's patch (mentioned earlier in thread) that
> disables dev->b_hw hack for 3430 (STT/STP bits written together) and
> double clears ARDY fixed the spurious IRQ issues for I2C1.
> 
> However, with the STT/STP+ARDY patch I was seeing Spurious interrupts
> all over the place and the IRQF_DISABLED in i2c-omap seemed to tame them
> quite well. I do agree that my approach might not be the proper one in
> long term.

Could you clarify this?  Do Richard's patches fix the spurious IRQs, or 
cause spurious interrupts to appear?


regards,

- Paul

  reply	other threads:[~2009-03-12  6:46 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-06 13:34 [PATCH 0/2] i2c: i2c-omap: Reliablity and register fixes Ari Kauppi
     [not found] ` <cover.1236345858.git.Ext-Ari.Kauppi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2009-03-06 13:34   ` [PATCH 1/2] i2c: i2c-omap: Fix BUFSTAT_REG reading Ari Kauppi
2009-03-06 13:34 ` [PATCH 2/2] i2c: i2c-omap: Call request_irq with IRQF_DISABLED Ari Kauppi
     [not found]   ` <7d7e7dd1a4c64c732a21bdfcf2bd42556be708c3.1236345858.git.Ext-Ari.Kauppi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2009-03-06 14:54     ` Woodruff, Richard
2009-03-10  0:52     ` Ben Dooks
2009-03-11 19:16       ` Felipe Balbi
2009-03-11 23:55       ` Paul Walmsley
     [not found]         ` <alpine.DEB.2.00.0903111741270.26959-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
2009-03-11 23:59           ` Felipe Balbi
2009-03-12  0:07             ` Paul Walmsley
     [not found]               ` <alpine.DEB.2.00.0903111804510.26959-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
2009-03-12  0:20                 ` Kevin Hilman
2009-03-12  0:23               ` Felipe Balbi
2009-03-12  3:30                 ` Paul Walmsley
2009-03-12  0:11             ` Felipe Contreras
2009-03-12  0:25               ` Felipe Balbi
2009-03-12  1:28             ` David Brownell
2009-03-12  0:04           ` Paul Walmsley
2009-03-12  6:26             ` Kauppi Ari (EXT-Ixonos/Oulu)
2009-03-12  6:46               ` Paul Walmsley [this message]
2009-03-12  7:54                 ` Kauppi Ari (EXT-Ixonos/Oulu)
2009-03-12  9:58                   ` Paul Walmsley
     [not found]                     ` <alpine.DEB.2.00.0903120356230.26959-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
2009-03-12 11:33                       ` Kauppi Ari (EXT-Ixonos/Oulu)
2009-03-12 15:04                         ` Woodruff, Richard
2009-03-13  0:04                         ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.0903120041020.26959@utopia.booyaka.com \
    --to=paul-dwxlp4yu+b8avxtiumwx3w@public.gmane.org \
    --cc=ben-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org \
    --cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
    --cc=ext-ari.kauppi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.