[Cluster-devel] [PATCH] add -l option support to umount

[Cluster-devel] [PATCH] add -l option support to umount

[Kadlecsik Jozsef]

Hi,

umount.gfs[2] does not support the '-l' flag, which is passed by recent(?) 
umount to the filesystem-specific umount program. The trivial patch below 
adds the flag so that umount.gfs[2] does not fail seeing the flag:

--- mount.orig/umount.gfs2.c	2009-01-22 13:33:51.000000000 +0100
+++ mount/umount.gfs2.c	2009-04-01 11:28:15.000000000 +0200
@@ -44,7 +44,7 @@
 	/* FIXME: check for "quiet" option and don't print in that case */
 
 	while (cont) {
-		optchar = getopt(argc, argv, "fhVvX:r");
+		optchar = getopt(argc, argv, "fhVvX:rl");
 
 		switch (optchar) {
 		case EOF:
@@ -74,6 +74,9 @@
 		case 'r':
 			break; /* used by umount to remount ro if umount fails */
 
+		case 'l':
+			break; /* lazy umount option used by umount */
+
 		default:
 			break;
 		}

Best regards,
Jozsef
--
E-mail : kadlec at mail.kfki.hu, kadlec at blackhole.kfki.hu
PGP key: http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address: KFKI Research Institute for Particle and Nuclear Physics
         H-1525 Budapest 114, POB. 49, Hungary

[Cluster-devel] [PATCH] add -l option support to umount

[Fabio M. Di Nitto]

Hi Kadlecsik,

thanks for the patch.

On Wed, 2009-04-01 at 11:39 +0200, Kadlecsik Jozsef wrote:
> Hi,
> 
> umount.gfs[2] does not support the '-l' flag, which is passed by recent(?) 
> umount to the filesystem-specific umount program. The trivial patch below 
> adds the flag so that umount.gfs[2] does not fail seeing the flag:

against what branch has this been tested?

Fabio

[Cluster-devel] [PATCH] add -l option support to umount

[Kadlecsik Jozsef]

On Wed, 1 Apr 2009, Fabio M. Di Nitto wrote:

> On Wed, 2009-04-01 at 11:39 +0200, Kadlecsik Jozsef wrote:
> > 
> > umount.gfs[2] does not support the '-l' flag, which is passed by recent(?) 
> > umount to the filesystem-specific umount program. The trivial patch below 
> > adds the flag so that umount.gfs[2] does not fail seeing the flag:
> 
> against what branch has this been tested?

The branch is cluster-2.03.11.

Best regards,
Jozsef
--
E-mail : kadlec at mail.kfki.hu, kadlec at blackhole.kfki.hu
PGP key: http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address: KFKI Research Institute for Particle and Nuclear Physics
         H-1525 Budapest 114, POB. 49, Hungary